View Issue Details

IDProjectCategoryView StatusLast Update
06753Development Survey Designpublic2016-11-17 01:05
ReporterDenisChenu Assigned To 
PrioritynormalSeverityminor 
Status newResolutionopen 
Product Version2.00 
Summary06753: css files are in a bad directory
DescriptionDefault css files are in ./styles-public/ .
I think it's not a clean solution.

Maybe same think for js files.
Steps To ReproduceLook at default css files directory.
Additional InformationPublic js files are in ./scripts/ but maybe is not a good situation too. Think we have to move whole public survey files in a better directory.

1st solution:
Move actual styles/* dirs in styles/admin/* dirs. And move styles-public/* in styles/*

2nd solution (think it's better)
- Move styles-public/*.css and styles-public/*/ in
templates/default/
- Move scripts/* used by public survey in templates/default/

With the second solution, css and js files are clearly identified by templating issue.

Denis
TagsNo tags attached.

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-10-22 11:34

developer   ~26898

Last edited: 2013-10-22 11:35

View 2 revisions

Use themes for core admin templates and upload/themes for user admin template.

@sammousa Is it for this for 2.1 ? Or did we wait using twig ?

DenisChenu

DenisChenu

2016-11-15 10:02

developer   ~41952

Last edited: 2016-11-15 10:03

View 2 revisions

Must be moved to QuestionObject when we have it or each in own "package".

I can do it for 'package'. It's not lost when moving to QuestionObject (or new attribute) : QuestionObject can register own pachage (and use it)

DenisChenu

DenisChenu

2016-11-17 00:07

developer   ~42006

https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/config/packages.php

in core.questions.questiontype : seems really clean

@all go for it ?

Related Changesets

LimeSurvey: develop 3998d61c

2016-11-17 00:56:06

DenisChenu

Details Diff
Dev: move fontawesome to depend of survey package (removed only from layout)
Dev: little issue with ranking
Dev: create core package question-ranking see 06753
Dev: remove uneeded jqueryui from default template
Affected Issues
06753, 11918
mod - application/config/packages.php Diff File
mod - application/config/third_party.php Diff File
add - application/core/packages/questions/ranking/ranking.css Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - application/models/TemplateConfiguration.php Diff File
mod - application/views/survey/questions/ranking/answer.php Diff File
rm - styles-public/ranking.css Diff File
mod - templates/default/config.xml Diff File

Issue History

Date Modified Username Field Change
2012-10-23 08:43 DenisChenu New Issue
2013-10-22 11:34 DenisChenu Note Added: 26898
2013-10-22 11:34 DenisChenu Issue Monitored: sammousa
2013-10-22 11:35 DenisChenu Note Edited: 26898 View Revisions
2016-11-15 10:02 DenisChenu Note Added: 41952
2016-11-15 10:03 DenisChenu Note Edited: 41952 View Revisions
2016-11-17 00:07 DenisChenu Note Added: 42006
2016-11-17 01:05 DenisChenu Changeset attached => LimeSurvey develop 3998d61c