View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
06744Bug reportsSurvey editingpublic2012-10-30 14:52
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary06744: Expressionmanager show false error if admin lang are not in survey lang
Description

After updating a question, EM show error even if there are no error.

Steps To Reproduce

Create a survey
Create a group
create a question : code Q1, Long free text
create another question : code Q2, text {Q1}, relevance Q1!=""
Save:

Q1 shown in error.
Click on "check survey logic for group" > all is OK
Reload the the question page : all is OK

Same think if you use "condition", add the condition (for example): Q1 are not empty. EM show (( ! is_empty(868539X81X1164.NAOK))) with 868539X81X1164 in red.

Additional Information

Seems again a cache session issue with EM.

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)121021
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

parent of 06768 closedc_schmitz Relevance equation works at question level but not at the group level 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2012-10-24 09:01

administrator   ~21578

Thomas, do you have an idea about this?

I can see that SetDirtyFlag is properly used after the question was inserted in the database. (see /controllers/database.php line 358) and then it redirects to the right URL.

Still the syntax highlighting is wrong.

TMSWhite

TMSWhite

2012-10-25 06:19

reporter   ~21641

I can't reproduce this. It works fine for me when I follow those instructions.

c_schmitz

c_schmitz

2012-10-25 09:46

administrator   ~21644

Shnoulle, can you still reproduce this? Because I can't anymore.

DenisChenu

DenisChenu

2012-10-25 10:00

developer   ~21645

Yes, do just this minute:
git reset --hard
git pull

Create a survey (title : Test)
Add a group (group)
Add a "Radio list question" : Q1 (without question text
Add 2 answer (default A1,A2,A3)
Add Q2 question : put in question text {Q1=="A1"} and in Relevance equation Q1=="A1"
Click on save : Q1 in red with "Undefined variable" in red.
Edit, Q1 => Q1.NAOK, click save & close : same thing.

Click on "expression manager file " for question: "Cette question, en elle-même, ne contient pas d'erreur de syntaxe" (i french ? : admin user EN, installtion FR) (but mean no problem)
Update question view (F5) : no problem shown.

mdekker

mdekker

2012-10-26 11:52

reporter   ~21703

Last edited: 2012-10-26 12:29

@schnoulle: I can reproduce that, also have error in relevance with double quotes. when i set it to single quotes i get Fatal error: Maximum function nesting level of '100' reached, aborting! when i check survey logic file.

EDIT: Error is when i put Q1=='A1' into validation

DenisChenu

DenisChenu

2012-10-26 12:54

developer   ~21706

Thank Menno, I feel less lonely :)

DenisChenu

DenisChenu

2012-10-27 14:12

developer   ~21726

Very strange think:
Each time, just after reload:
/admin/survey/view/surveyid/271569/gid/99/qid/1413

With question text to {Q1=="A1"}

  • Force new class with "if (isset($_SESSION['LEMdirtyFlag']) || true) { "
    then i have empty question text
  • Force new class with "else if (!isset(self::$instance) ||true) {"
    then 1 (like
  • After i remove my test : but again error shown ....
DenisChenu

DenisChenu

2012-10-27 15:01

developer   ~21728

It's an admin langage issue \o/

With a user in french : create an english survey : error
With a user in english : create an french survey : error

BUT

With a user in french : create an english +french survey : NO error
With a user in english : create an french +english survey : NO error

DenisChenu

DenisChenu

2012-10-27 15:43

developer   ~21730

Some holiday until tuesday. Leave it , if someone can found when call
SetSurveyLanguage($iSurveyID, $language); and when.

I have same thing if i select a existing survey without admin lang.

Denis

DenisChenu

DenisChenu

2012-10-30 11:22

developer   ~21755

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10048

DenisChenu

DenisChenu

2012-10-30 11:27

developer   ~21756

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10049

DenisChenu

DenisChenu

2012-10-30 11:29

developer   ~21757

It's a view issue, then apply the patch in the surveyadmin/funtion view.

Maybe a lot of thing to ensure, but i don't found another way.

Think there are a lot of issue like that one:
For example :

  • Error in default lang, but not in the admin lang
  • No error in default lang, but error in adminlang
  • etc ...
c_schmitz

c_schmitz

2012-10-30 14:52

administrator   ~21774

New 2.00+ version released - please update.

Related Changesets

LimeSurvey: master 364dbf3e

2012-10-30 03:21:43

DenisChenu

Details Diff
Fixed issue 06744: Expressionmanager show false error if admin lang are not in default survey lang
Dev : in view, all survey are to be set in default lang, because survey is shown in default lang
Dev : GetLastPrettyPrintExpression seems to be updated without StartProcessingPage
Affected Issues
06744
mod - application/controllers/admin/surveyadmin.php Diff File

LimeSurvey: 2.1 5333e1ad

2012-10-30 03:21:43

DenisChenu

Details Diff
Fixed issue 06744: Expressionmanager show false error if admin lang are not in default survey lang
Dev : in view, all survey are to be set in default lang, because survey is shown in default lang
Dev : GetLastPrettyPrintExpression seems to be updated without StartProcessingPage
Affected Issues
06744
mod - application/controllers/admin/surveyadmin.php Diff File

Issue History

Date Modified Username Field Change
2012-10-21 17:55 DenisChenu New Issue
2012-10-22 15:36 c_schmitz Assigned To => c_schmitz
2012-10-22 15:36 c_schmitz Status new => assigned
2012-10-24 09:01 c_schmitz Note Added: 21578
2012-10-24 09:01 c_schmitz Assigned To c_schmitz => TMSWhite
2012-10-24 09:01 c_schmitz Status assigned => feedback
2012-10-25 06:19 TMSWhite Note Added: 21641
2012-10-25 06:24 TMSWhite Assigned To TMSWhite =>
2012-10-25 09:46 c_schmitz Assigned To => DenisChenu
2012-10-25 09:46 c_schmitz Status feedback => assigned
2012-10-25 09:46 c_schmitz Note Added: 21644
2012-10-25 10:00 DenisChenu Note Added: 21645
2012-10-26 11:52 mdekker Note Added: 21703
2012-10-26 12:29 mdekker Note Edited: 21703
2012-10-26 12:54 DenisChenu Note Added: 21706
2012-10-26 14:44 DenisChenu Relationship added parent of 06768
2012-10-27 14:12 DenisChenu Note Added: 21726
2012-10-27 15:01 DenisChenu Note Added: 21728
2012-10-27 15:02 DenisChenu Summary Expressionmanager show false error after adding/updating question => Expressionmanager show false error if admin lang are not in survey lang
2012-10-27 15:41 DenisChenu Assigned To DenisChenu =>
2012-10-27 15:43 DenisChenu Note Added: 21730
2012-10-27 15:43 DenisChenu Assigned To => DenisChenu
2012-10-27 15:43 DenisChenu Status assigned => new
2012-10-27 15:44 DenisChenu Assigned To DenisChenu =>
2012-10-30 09:14 c_schmitz Assigned To => DenisChenu
2012-10-30 09:14 c_schmitz Status new => assigned
2012-10-30 11:22 DenisChenu Changeset attached => LimeSurvey master 364dbf3e
2012-10-30 11:22 DenisChenu Note Added: 21755
2012-10-30 11:22 DenisChenu Resolution open => fixed
2012-10-30 11:27 DenisChenu Changeset attached => LimeSurvey 2.1 5333e1ad
2012-10-30 11:27 DenisChenu Note Added: 21756
2012-10-30 11:29 DenisChenu Note Added: 21757
2012-10-30 11:29 DenisChenu Status assigned => resolved
2012-10-30 11:29 DenisChenu Fixed in Version => 2.00+
2012-10-30 14:52 c_schmitz Note Added: 21774
2012-10-30 14:52 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing