View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 05514 | Bug reports | public | 2011-10-15 18:47 | 2015-08-21 15:51 | |
| Reporter | DenisChenu | Assigned To | DenisChenu | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 1.91+ | ||||
| Summary | 05514: Remove prepareCellAdapters and cellAdapter for jquery | ||||
| Description | In survey_runtime.js, we use cellAdaptater to check/uncheck checkbox and radio. Sometimes, it make difficult to adapt some script for jquery. Make this with jquery is more simple to adapt for another question type ( for example line in ul li). | ||||
| Steps To Reproduce | To test the result: | ||||
| Additional Information | remove 67 lines of javascript and replace with 5 lines $(".question td").click(function(event){ | ||||
| Tags | No tags attached. | ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 11173 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | Firefox,chrome for testing | ||||
| Database type & version | not relevant | ||||
| Server OS (if known) | not relevant | ||||
| Webserver software & version (if known) | not relevant | ||||
| PHP Version | not relevant | ||||
| Git branch / Pull Request URL | |||||
| related to | 04984 | closed | DenisChenu | Need more class for all question/answer part |
| related to | 07279 | closed | c_schmitz | Array exlude other function : user can change excluded option |
|
Tony, can you please check if this works fine and bugfree, especially with conditions (CI-version only). |
|
|
No, i made an error .... We have to put : $("table.question td").click(function(event){ But maybe we have to add a class to all td |
|
|
Actually i have: Add triggerHandler("click"); for em funtion and some personnal script, I work for a global script for citronade v192 |
|
|
Again another solution. For 1.92: function prepareCellAdapters(){ Here, i remove css padding before set width and height. But i think we have something best: the input color change when we are hover the td. I think this label are to be removed ( they meen nothing), but if we done it, we can add it in JS I test actually, have some test to do for IE and for 'touch' screen. |
|
|
All can be made very easyly with $.delegate . But some issue with jquery1.4 and not in jquery1.9. 1.4 need triggerHandler and not 1.9 ... |
|
|
use $.delegate function and stopPropagation |
|
|
LimeSurvey: 2.1 114baa15 2013-02-07 11:14 Details Diff |
Dev: 05514: Remove prepareCellAdapters and cellAdapter for jquery Dev: updated addClassEmpty too Dev: use $.delegate function and stopPropagation |
Affected Issues 05514 |
|
| mod - scripts/survey_runtime.js | Diff File | ||
|
LimeSurvey: 2.05 9d8e52b5 2013-03-26 12:02 Details Diff |
Dev: 05514: Remove prepareCellAdapters and cellAdapter for jquery Dev: Use same fix than 2.1 |
Affected Issues 05514 |
|
| mod - scripts/survey_runtime.js | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-10-15 18:47 | DenisChenu | New Issue | |
| 2011-10-15 18:48 | DenisChenu | Project | Bug reports => @10@ |
| 2011-10-18 17:34 | c_schmitz | Assigned To | => tpartner |
| 2011-10-18 17:34 | c_schmitz | Status | new => assigned |
| 2011-10-18 17:35 | c_schmitz | Note Added: 16444 | |
| 2011-10-18 19:00 | DenisChenu | Note Added: 16456 | |
| 2011-10-23 15:54 | DenisChenu | Relationship added | related to 04984 |
| 2012-01-11 18:38 | DenisChenu | Note Added: 16789 | |
| 2012-01-11 18:38 | DenisChenu | Note Edited: 16789 | |
| 2012-03-17 19:32 | DenisChenu | Note Added: 17981 | |
| 2012-08-14 23:13 | c_schmitz | Assigned To | tpartner => DenisChenu |
| 2013-02-01 17:00 | DenisChenu | Note Added: 23938 | |
| 2013-02-07 11:18 | DenisChenu | Note Added: 23973 | |
| 2013-02-07 11:18 | DenisChenu | Status | assigned => closed |
| 2013-02-07 11:18 | DenisChenu | Resolution | open => fixed |
| 2013-02-07 11:18 | DenisChenu | Fixed in Version | => 2.1 |
| 2013-02-07 11:19 | DenisChenu | Changeset attached | => LimeSurvey 2.1 114baa15 |
| 2013-02-07 17:43 | DenisChenu | Relationship added | related to 07279 |
| 2013-03-25 22:18 | DenisChenu | Status | closed => feedback |
| 2013-03-25 22:18 | DenisChenu | Resolution | fixed => reopened |
| 2013-03-25 22:18 | DenisChenu | Fixed in Version | 2.1 => |
| 2013-03-25 22:18 | DenisChenu | Status | feedback => assigned |
| 2013-03-26 12:03 | DenisChenu | Changeset attached | => LimeSurvey 2.05 9d8e52b5 |
| 2013-03-26 12:03 | DenisChenu | Status | assigned => resolved |
| 2013-03-26 12:03 | DenisChenu | Fixed in Version | => 2.05 |
| 2013-03-26 12:03 | DenisChenu | Resolution | reopened => fixed |
| 2015-08-21 15:51 | c_schmitz | Status | resolved => closed |
| 2026-11-20 10:33 | c_schmitz | Category | Survey taking => (No Category) |