View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17897 | Bug reports | Statistics | public | 2022-02-16 15:25 | 2022-12-05 10:35 |
Reporter | atisne | Assigned To | gabrieljenik | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.2.x | ||||
Summary | 17897: Build of statistics fails with DivisionByZero | ||||
Description | The build of the statistics of a survey with a conditional question that is not answered fails with a DivisionByZero error (please see error stack in attachment). | ||||
Steps To Reproduce | Steps to reproduce1- Create a new survey Expected resultSee the statistics Actual result500 : Erreur interne au serveur | ||||
Tags | No tags attached. | ||||
Bug heat | 14 | ||||
Complete LimeSurvey version number (& build) | 5.2.11+220124 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | pgsql 13.5 | ||||
Server OS (if known) | docker with image php:8.0-apache | ||||
Webserver software & version (if known) | apache 2.4.51 | ||||
PHP Version | 8.0.13 | ||||
User List | baptisted76 |
---|
DivisionByZeroError.html (20,300 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/> <title>DivisionByZeroError</title> <style type="text/css"> /*<![CDATA[*/ html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;} body{line-height:1;} ol,ul{list-style:none;} blockquote,q{quotes:none;} blockquote:before,blockquote:after,q:before,q:after{content:none;} :focus{outline:0;} ins{text-decoration:none;} del{text-decoration:line-through;} table{border-collapse:collapse;border-spacing:0;} body { font: normal 9pt "Verdana"; color: #000; background: #fff; } h1 { font: normal 18pt "Verdana"; color: #f00; margin-bottom: .5em; } h2 { font: normal 14pt "Verdana"; color: #800000; margin-bottom: .5em; } h3 { font: bold 11pt "Verdana"; } pre { font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace; } pre span.error { display: block; background: #fce3e3; } pre span.ln { color: #999; padding-right: 0.5em; border-right: 1px solid #ccc; } pre span.error-ln { font-weight: bold; } .container { margin: 1em 4em; } .version { color: gray; font-size: 8pt; border-top: 1px solid #aaa; padding-top: 1em; margin-bottom: 1em; } .message { color: #000; padding: 1em; font-size: 11pt; background: #f3f3f3; -webkit-border-radius: 10px; -moz-border-radius: 10px; border-radius: 10px; margin-bottom: 1em; line-height: 160%; } .source { margin-bottom: 1em; } .code pre { background-color: #ffe; margin: 0.5em 0; padding: 0.5em; line-height: 125%; border: 1px solid #eee; } .source .file { margin-bottom: 1em; font-weight: bold; } .traces { margin: 2em 0; } .trace { margin: 0.5em 0; padding: 0.5em; } .trace.app { border: 1px dashed #c00; } .trace .number { text-align: right; width: 2em; padding: 0.5em; } .trace .content { padding: 0.5em; } .trace .plus, .trace .minus { display:inline; vertical-align:middle; text-align:center; border:1px solid #000; color:#000; font-size:10px; line-height:10px; margin:0; padding:0 1px; width:10px; height:10px; } .trace.collapsed .minus, .trace.expanded .plus, .trace.collapsed pre { display: none; } .trace-file { cursor: pointer; padding: 0.2em; } .trace-file:hover { background: #f0ffff; } /*]]>*/ </style> </head> <body> <div class="container"> <h1>DivisionByZeroError</h1> <p class="message"> Division by zero </p> <div class="source"> <p class="file">/var/www/html/application/helpers/admin/statistics_helper.php(2610)</p> <div class="code"><pre><span class="ln">2598</span> if (isset($_POST['noncompleted']) and ($_POST['noncompleted'] == 1)) { <span class="ln">2599</span> //counter <span class="ln">2600</span> $i = 0; <span class="ln">2601</span> <span class="ln">2602</span> while (isset($gdata[$i])) { <span class="ln">2603</span> if (isset($showaggregated_indice_table[$i]) && $showaggregated_indice_table[$i] == "aggregated") { <span class="ln">2604</span> // do nothing, we don't rewrite aggregated results <span class="ln">2605</span> // or at least I don't know how !!! (lemeur) <span class="ln">2606</span> } else { <span class="ln">2607</span> //we want to have some "real" data here <span class="ln">2608</span> if ($gdata[$i] != "N/A") { <span class="ln">2609</span> //calculate percentage <span class="error"><span class="ln error-ln">2610</span> $gdata[$i] = ($grawdata[$i] / $TotalCompleted) * 100; </span><span class="ln">2611</span> } <span class="ln">2612</span> } <span class="ln">2613</span> <span class="ln">2614</span> //increase counter <span class="ln">2615</span> $i++; <span class="ln">2616</span> } //end while (data available) <span class="ln">2617</span> } //end if -> noncompleted checked <span class="ln">2618</span> <span class="ln">2619</span> //noncompleted is NOT checked <span class="ln">2620</span> else { <span class="ln">2621</span> //calculate total number of incompleted records <span class="ln">2622</span> $TotalIncomplete = max(($results - $TotalCompleted), 0); // don't show negative number </pre></div> </div> <div class="traces"> <h2>Stack Trace</h2> <table style="width:100%;"> <tr class="trace app expanded"> <td class="number"> #0 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/application/helpers/admin/statistics_helper.php(3713): <strong>statistics_helper</strong>-><strong>displayResults</strong>() </div> <div class="code"><pre><span class="ln">3708</span> $outputs = $this->buildOutputList($rt, $language, $surveyid, $outputType, $sql, $sLanguageCode); <span class="ln">3709</span> $sOutputHTML .= $outputs['statisticsoutput']; <span class="ln">3710</span> //2. Collect and Display results ####################################################################### <span class="ln">3711</span> if (isset($outputs['alist']) && $outputs['alist']) { <span class="ln">3712</span> //Make sure there really is an answerlist, and if so: <span class="error"><span class="ln error-ln">3713</span> $display = $this->displayResults($outputs, $results, $rt, $outputType, $surveyid, $sql, $usegraph, $browse, $sLanguageCode); </span><span class="ln">3714</span> $sOutputHTML .= $display['statisticsoutput']; <span class="ln">3715</span> $aStatisticsData = array_merge($aStatisticsData, $display['astatdata']); <span class="ln">3716</span> } //end if -> collect and display results <span class="ln">3717</span> <span class="ln">3718</span> </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #1 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/application/controllers/admin/statistics.php(469): <strong>statistics_helper</strong>-><strong>generate_html_chartjs_statistics</strong>() </div> <div class="code"><pre><span class="ln">464</span> //Show Summary results <span class="ln">465</span> if (isset($summary) && $summary) { <span class="ln">466</span> $outputType = Yii::app()->request->getPost('outputtype', 'html'); <span class="ln">467</span> switch ($outputType) { <span class="ln">468</span> case 'html': <span class="error"><span class="ln error-ln">469</span> $statisticsoutput .= $helper->generate_html_chartjs_statistics($surveyid, $summary, $summary, $usegraph, $outputType, 'DD', $statlang); </span><span class="ln">470</span> break; <span class="ln">471</span> case 'pdf': <span class="ln">472</span> $helper->generate_statistics($surveyid, $summary, $summary, $usegraph, $outputType, 'D', $statlang); <span class="ln">473</span> exit; <span class="ln">474</span> break; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #2 </td> <td class="content"> <div class="trace-file"> unknown(0): <strong>statistics</strong>-><strong>run</strong>() </div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #3 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/framework/web/actions/CAction.php(115): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>() </div> <div class="code"><pre><span class="ln">110</span> elseif($param->isDefaultValueAvailable()) <span class="ln">111</span> $ps[]=$param->getDefaultValue(); <span class="ln">112</span> else <span class="ln">113</span> return false; <span class="ln">114</span> } <span class="error"><span class="ln error-ln">115</span> $method->invokeArgs($object,$ps); </span><span class="ln">116</span> return true; <span class="ln">117</span> } <span class="ln">118</span> } </pre></div> </td> </tr> <tr class="trace app expanded"> <td class="number"> #4 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/application/core/Survey_Common_Action.php(86): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>() </div> <div class="code"><pre><span class="ln">81</span> $oMethod = new ReflectionMethod($this, $sDefault); <span class="ln">82</span> } <span class="ln">83</span> <span class="ln">84</span> // We're all good to go, let's execute it <span class="ln">85</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params <span class="error"><span class="ln error-ln">86</span> return parent::runWithParamsInternal($this, $oMethod, $params); </span><span class="ln">87</span> } <span class="ln">88</span> <span class="ln">89</span> /** <span class="ln">90</span> * Some functions have different parameters, which are just an alias of the <span class="ln">91</span> * usual parameters we're getting in the url. This function just populates </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #5 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/framework/web/CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>() </div> <div class="code"><pre><span class="ln">303</span> { <span class="ln">304</span> $priorAction=$this->_action; <span class="ln">305</span> $this->_action=$action; <span class="ln">306</span> if($this->beforeAction($action)) <span class="ln">307</span> { <span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false) </span><span class="ln">309</span> $this->invalidActionParams($action); <span class="ln">310</span> else <span class="ln">311</span> $this->afterAction($action); <span class="ln">312</span> } <span class="ln">313</span> $this->_action=$priorAction; </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #6 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>() </div> <div class="code"><pre><span class="ln">281</span> * @see runAction <span class="ln">282</span> */ <span class="ln">283</span> public function runActionWithFilters($action,$filters) <span class="ln">284</span> { <span class="ln">285</span> if(empty($filters)) <span class="error"><span class="ln error-ln">286</span> $this->runAction($action); </span><span class="ln">287</span> else <span class="ln">288</span> { <span class="ln">289</span> $priorAction=$this->_action; <span class="ln">290</span> $this->_action=$action; <span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run(); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #7 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>() </div> <div class="code"><pre><span class="ln">260</span> { <span class="ln">261</span> if(($parent=$this->getModule())===null) <span class="ln">262</span> $parent=Yii::app(); <span class="ln">263</span> if($parent->beforeControllerAction($this,$action)) <span class="ln">264</span> { <span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters()); </span><span class="ln">266</span> $parent->afterControllerAction($this,$action); <span class="ln">267</span> } <span class="ln">268</span> } <span class="ln">269</span> else <span class="ln">270</span> $this->missingAction($actionID); </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #8 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/application/controllers/AdminController.php(202): <strong>CController</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">197</span> } <span class="ln">198</span> <span class="ln">199</span> $this->runModuleController($action); <span class="ln">200</span> <span class="ln">201</span> <span class="error"><span class="ln error-ln">202</span> return parent::run($action); </span><span class="ln">203</span> } <span class="ln">204</span> <span class="ln">205</span> /** <span class="ln">206</span> * Starting with LS4, 3rd party developper can extends any of the LimeSurve controllers. <span class="ln">207</span> * </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #9 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/framework/web/CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">277</span> { <span class="ln">278</span> list($controller,$actionID)=$ca; <span class="ln">279</span> $oldController=$this->_controller; <span class="ln">280</span> $this->_controller=$controller; <span class="ln">281</span> $controller->init(); <span class="error"><span class="ln error-ln">282</span> $controller->run($actionID); </span><span class="ln">283</span> $this->_controller=$oldController; <span class="ln">284</span> } <span class="ln">285</span> else <span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".', <span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route))); </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #10 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>() </div> <div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value) <span class="ln">137</span> $_GET[$name]=$value; <span class="ln">138</span> } <span class="ln">139</span> else <span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest()); <span class="error"><span class="ln error-ln">141</span> $this->runController($route); </span><span class="ln">142</span> } <span class="ln">143</span> <span class="ln">144</span> /** <span class="ln">145</span> * Registers the core application components. <span class="ln">146</span> * This method overrides the parent implementation by registering additional core components. </pre></div> </td> </tr> <tr class="trace core collapsed"> <td class="number"> #11 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div> <div class="code"><pre><span class="ln">180</span> public function run() <span class="ln">181</span> { <span class="ln">182</span> if($this->hasEventHandler('onBeginRequest')) <span class="ln">183</span> $this->onBeginRequest(new CEvent($this)); <span class="ln">184</span> register_shutdown_function(array($this,'end'),0,false); <span class="error"><span class="ln error-ln">185</span> $this->processRequest(); </span><span class="ln">186</span> if($this->hasEventHandler('onEndRequest')) <span class="ln">187</span> $this->onEndRequest(new CEvent($this)); <span class="ln">188</span> } <span class="ln">189</span> <span class="ln">190</span> /** </pre></div> </td> </tr> <tr class="trace app collapsed"> <td class="number"> #12 </td> <td class="content"> <div class="trace-file"> <div class="plus">+</div> <div class="minus">–</div> /var/www/html/index.php(192): <strong>CApplication</strong>-><strong>run</strong>() </div> <div class="code"><pre><span class="ln">187</span> require_once APPPATH . 'core/LSYii_Application' . EXT; <span class="ln">188</span> <span class="ln">189</span> $config = require_once(APPPATH . 'config/internal' . EXT); <span class="ln">190</span> <span class="ln">191</span> Yii::$enableIncludePath = false; <span class="error"><span class="ln error-ln">192</span> Yii::createApplication('LSYii_Application', $config)->run(); </span><span class="ln">193</span> <span class="ln">194</span> /* End of file index.php */ <span class="ln">195</span> /* Location: ./index.php */ </pre></div> </td> </tr> </table> </div> <div class="version"> 2022-02-16 10:47:51 Apache/2.4.51 (Debian) <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.24-dev </div> </div> <script type="text/javascript"> /*<![CDATA[*/ var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)"); var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)"); var e = document.getElementsByTagName("div"); for(var j=0,len=e.length;j<len;j++){ if(traceReg.test(e[j].className)){ e[j].onclick = function(){ var trace = this.parentNode.parentNode; if(collapsedReg.test(trace.className)) trace.className = trace.className.replace("collapsed", "expanded"); else trace.className = trace.className.replace("expanded", "collapsed"); } } } /*]]>*/ </script> </body> </html> |
|
We are facing the same issue with the attached survey. Simply imoort the LSA file and run the simpel stats. |
|
@ollehar, @c_schmitz: This one is currently assigned to galads. But I think this user is not active anymore. Can you please assign it to @gabrieljenik or anyone else? |
|
Haven't seen this. I will grab it. |
|
@gabrieljenik: Only happens in very special cases as outlined above. There needs to be a question with conditions and that question may not have received answers yet. My attached survey should show it. |
|
Master PR: https://github.com/LimeSurvey/LimeSurvey/pull/2704 |
|
@Mazi when testing couldn't reproduce this exactly as you mentioned. |
|
@gabrieljenik, simply import the adjusted survey, go to the statistics feature, select to include all answers and then show statistics. You then get the error shown at the attached screenshot. |
|
I can confirm that the fix solves the problem. With it we can call the statistics just fine. Please include the fix at the next release. |
|
Can we add the fix to the next release? |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34063 |
|
Fixed in Release 5.4.14+221205 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2022-02-16 15:25 | atisne | New Issue | |
2022-02-16 15:25 | atisne | File Added: DivisionByZeroError.html | |
2022-02-16 15:25 | atisne | File Added: survey_archive_185759.lsa | |
2022-02-17 09:42 | galads | Assigned To | => galads |
2022-02-17 09:42 | galads | Status | new => acknowledged |
2022-06-23 09:11 | baptisted76 | Issue Monitored: baptisted76 | |
2022-06-23 09:11 | baptisted76 | Bug heat | 0 => 2 |
2022-10-28 16:42 | Mazi | Note Added: 72472 | |
2022-10-28 16:42 | Mazi | File Added: survey_archive_874591.lsa | |
2022-10-28 16:42 | Mazi | Bug heat | 2 => 4 |
2022-10-28 16:42 | Mazi | Bug heat | 4 => 10 |
2022-10-28 16:43 | Mazi | Note Added: 72473 | |
2022-10-31 13:43 | gabrieljenik | Status | acknowledged => confirmed |
2022-10-31 13:43 | gabrieljenik | Note Added: 72480 | |
2022-10-31 13:43 | gabrieljenik | Bug heat | 10 => 12 |
2022-10-31 13:43 | gabrieljenik | Assigned To | galads => gabrieljenik |
2022-10-31 15:20 | Mazi | Note Added: 72489 | |
2022-11-03 20:23 | gabrieljenik | Status | confirmed => assigned |
2022-11-07 14:45 | gabrieljenik | Status | assigned => ready for code review |
2022-11-07 14:45 | gabrieljenik | Note Added: 72615 | |
2022-11-07 14:45 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2022-11-07 15:39 | DenisChenu | Assigned To | DenisChenu => |
2022-11-07 15:39 | DenisChenu | Status | ready for code review => ready for testing |
2022-11-16 14:40 | gabrieljenik | Note Added: 72771 | |
2022-11-20 16:39 | Mazi | Note Added: 72825 | |
2022-11-20 16:39 | Mazi | File Added: image.png | |
2022-11-25 16:55 | Mazi | Note Added: 72902 | |
2022-11-25 17:06 | gabrieljenik | Assigned To | => ollehar |
2022-11-25 17:06 | gabrieljenik | Status | ready for testing => ready for merge |
2022-11-29 13:08 | Mazi | Note Added: 72929 | |
2022-12-01 10:01 | gabrieljenik | Changeset attached | => LimeSurvey master 899cc67a |
2022-12-01 10:01 | gabrieljenik | Note Added: 72954 | |
2022-12-01 10:01 | gabrieljenik | Assigned To | ollehar => gabrieljenik |
2022-12-01 10:01 | gabrieljenik | Resolution | open => fixed |
2022-12-05 10:35 | LimeBot | Note Added: 72996 | |
2022-12-05 10:35 | LimeBot | Status | ready for merge => closed |
2022-12-05 10:35 | LimeBot | Bug heat | 12 => 14 |