View Issue Details

IDProjectCategoryView StatusLast Update
17242Development Pluginspublic2021-04-22 16:59
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Summary17242: Remove unused invocations to getOwnQuestionAttributesViaPlugin() and some QuestionBaseDataSet methods
DescriptionQuestionAttribute::getOwnQuestionAttributesViaPlugin() is used on QuestionTheme::getQuestionThemeAttributeValues (see attachment)

That method is used on application\models\QuestionBaseDataSet.php
- getPreformattedBlockOfAdvancedSettings --> never called
- getAdvancedOptions --> said to be deprectaed


Shall we just
1) remove those unused and deprecated methods \QuestionBaseDataSet.php ?
2) remove the getOwnQuestionAttributesViaPlugin() call from QuestionTheme::getQuestionThemeAttributeValues ?
Additional InformationCame up while reviewing 16669
TagsNo tags attached.

Relationships

related to 16669 closedgabrieljenik Bug reports getQuestionAttributes function don't get the plugins attribute 
has duplicate 17240 closedgabrieljenik Development  Clean up functions related to question attributes 

Activities

gabrieljenik

gabrieljenik

2021-04-22 15:44

manager   ~64114

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1852

Remove getPreformattedBlockOfAdvancedSettings and getAdvancedOptions from QuestionBaseDataSet

Move getAttributesAsArrayFromDB to its own method
Move \QuestionTheme::getAdditionalAttrFromExtendedTheme to its own method
Move \QuestionAttribute::getQuestionAttributesSettings to its own method

Removed Hungarian notation

Issue History

Date Modified Username Field Change
2021-04-13 16:18 gabrieljenik New Issue
2021-04-13 16:18 gabrieljenik Issue generated from: 16669
2021-04-13 16:18 gabrieljenik Relationship added related to 16669
2021-04-13 16:18 gabrieljenik Project Bug reports => Development
2021-04-13 16:19 ollehar Assigned To => gabrieljenik
2021-04-13 16:19 ollehar Status new => assigned
2021-04-20 17:55 gabrieljenik Relationship added has duplicate 17240
2021-04-22 15:44 gabrieljenik Note Added: 64114
2021-04-22 16:15 gabrieljenik Status assigned => testing
2021-04-22 16:59 gabrieljenik Status testing => resolved
2021-04-22 16:59 gabrieljenik Resolution open => fixed