16899: Cannot attach PDF to email invitation (email template for surveys) - develop branch

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

16899	Bug reports	Other	public	2020-12-10 16:24	2021-01-28 16:27

Reporter	cdorin	Assigned To	gabrieljenik
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	4.x.0-dev

Summary	16899: Cannot attach PDF to email invitation (email template for surveys) - develop branch
Description	Copy of 16854: Cannot attach PDF to email invitation (email template for surveys) the fix for LS3 is here: https://github.com/LimeSurvey/LimeSurvey/pull/1679
Tags	No tags attached.

Bug heat	8
Complete LimeSurvey version number (& build)	irrelevant
I will donate to the project if issue is resolved	No
Browser
Database type & version	irrelevant
Server OS (if known)
Webserver software & version (if known)
PHP Version	irrelevant

User List	There are no users monitoring this issue.

gabrieljenik 2020-12-16 22:11 manager ~60994	@olleThe JS package related to the emailtemplate was removed on develop. https://github.com/LimeSurvey/LimeSurvey/commit/a790a16b8c2dc47531085f2a15a324f0ebe5390b Any specific reason?

cdorin 2020-12-28 18:08 reporter ~61244	Ping @ollehar

ollehar 2021-01-13 17:20 administrator ~61533	What's the error message?

ollehar 2021-01-13 17:21 administrator ~61534	The emailtemplates packages was a Vue component. Since emailtemplates was reverted to LS3, the package was no longer needed. But maybe something there needs to stay?

gabrieljenik 2021-01-14 17:30 manager ~61543	Good. Will pickup what we need from the package. Thanks!

gabrieljenik 2021-01-15 13:53 manager ~61562	PR: https://github.com/LimeSurvey/LimeSurvey/pull/1720

gabrieljenik 2021-01-21 13:36 manager ~61613	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30869

lime_release_bot 2021-01-28 16:27 administrator ~61751	Fixed in Release 4.4.0+210129

LimeSurvey: master b3f4113e 2021-01-19 12:52:20 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16899 & 16950: Attachments on Email Invitations (#1720) * Fixed issue 16899: Cannot attach PDF to email invitation (email template for surveys) - develop branch Reinstated js code removed when removing vue packages. * Fixed issue 16950: publicurl disable attchments	Affected Issues 16899, 16950
	mod - application/config/packages.php	Diff File
	mod - application/controllers/admin/emailtemplates.php	Diff File
	mod - application/models/SurveyLanguageSetting.php	Diff File
	add - assets/packages/emailtemplates/emailtemplates.js	Diff File
	add - assets/packages/emailtemplates/emailtemplates.min.js	Diff File
	add - assets/packages/emailtemplates/popup-dialog.css	Diff File

Date Modified	Username	Field	Change
2020-12-10 16:24	cdorin	New Issue
2020-12-10 16:24	cdorin	Assigned To	=> gabrieljenik
2020-12-10 16:24	cdorin	Priority	none => normal
2020-12-10 16:24	cdorin	Status	new => assigned
2020-12-10 16:24	cdorin	Sync to Zoho Project	Yes => \|Yes\|
2020-12-16 22:11	gabrieljenik	Note Added: 60994
2020-12-28 18:08	cdorin	Note Added: 61244
2021-01-13 17:20	ollehar	Note Added: 61533
2021-01-13 17:20	ollehar	Status	assigned => feedback
2021-01-13 17:21	ollehar	Note Added: 61534
2021-01-14 17:30	gabrieljenik	Note Added: 61543
2021-01-15 13:53	gabrieljenik	Note Added: 61562
2021-01-21 13:36	gabrieljenik	Changeset attached	=> LimeSurvey master b3f4113e
2021-01-21 13:36	gabrieljenik	Note Added: 61613
2021-01-21 13:36	gabrieljenik	Resolution	open => fixed
2021-01-28 16:27	lime_release_bot	Sync to Zoho Project	Yes => \|Yes\|
2021-01-28 16:27	lime_release_bot	Note Added: 61751
2021-01-28 16:27	lime_release_bot	Status	feedback => closed