Not only after question render! The survey I tested fired 3748 times! (767 questions)

Maybe we can move it to the satci part of find ?

twigreneder seems to happen a lot too.

It wil reduce processor cycles! It is massive! Who knows: renderspeed improvement?

With Sample survey https://github.com/LimeSurvey/LimeSurvey/blob/master/docs/demosurveys/ls3_sample_survey_multilingual_fr_de_en_it.lss
Set "All in one page"

afterFindSurvey happen

• in 3.X : 2 times
• in 4.3.16 : 430 times

There are clearly a new issue here.

Plugin used : https://gitlab.com/SondagesPro/TestDemoAndDevel/checkAfterFindSurvey/-/blob/master/checkAfterFindSurvey.php

But more :! my 3.X version for testing have already a lot of plugins …

Seems we don't use findByPk in 3.X on some function.

We must use findByPk … for Survey (and anywhere it's possible)

this issue should also be addressed to 3xLTS

No : 3LTS : event happen 2 times only, no real issue in LTS. Can be improved, but still no a real issue.

Did you test my plugin ?

Strange. I don't see why it is called so few times on LSv3 if the event happens afterFind.

As per the definition of the manual, I would just trigger the event manually from the survey taking side, instead of attaching it to the find method, which could be triggered from the admin side as well.

Am I right? Or am I missing something?

findByPk don't throw afterFind event.
Usage of static variable.

I would just trigger the event manually from the survey taking side, instead of attaching it to the find method,

Plugin can need to update attribute each time it was loaded. Even o admin part : it don't happen a lot, 3 times for Survey settings. Currently plugin event happen in admin , stay in admin please …

Dev can control where it's call with Yii::app()->getController()->getId()

See https://gitlab.com/SondagesPro/mailing/adminNotificationHtmlAnswerTable/-/blob/master/adminNotificationHtmlAnswerTable.php#L232

Capture d’écran du 2020-09-22 16-02-13.png (50,393 bytes)   

Capture d’écran du 2020-09-22 16-02-13.png (50,393 bytes)   

@p_teichmann : warning : if you update this : you broke API and potential plugin …

@gabrieljenik

As per the definition of the manual, I would just trigger the event manually from the survey taking side, instead of attaching it to the find method, which could be triggered from the admin side as well.

Right about manual : but need a model->afterFind event. Maybe

1. Create a new afterPublicFindSurvey
2. Update manual page

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31400

Fixed in Release 4.4.15+210329

Manual fixed : https://manual.limesurvey.org/index.php?title=AfterFindSurvey&type=revision&diff=161387&oldid=154072