View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
16561Bug reportsSurvey participants (Tokens)public2020-08-06 17:32
ReporterMazi Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version3.22.25 
Summary16561: Editing token screen has "completed", "invitation sent" and "reminder sent" pre-filled in a wrong way
Description

I was just about to edit a token and wondered about "completed", "invitation sent" and "reminder sent" being pre-filled with YES (ja), though I had previously re-set those fields to NO using the batch editing tool.
Check the attached screen shot. The token overview shows different details than the editing screen!

Steps To Reproduce

Batch edit tokens and set "completed", "invitation sent" and "reminder sent" all to NO.
Edit a single token and check the settings of these fields

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)3.22.25 (Limequery)
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionlimequery
Server OS (if known)limequery
Webserver software & version (if known)limequery
PHP Versionlimequery

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2020-08-03 13:00

updater   ~59265

@cdorin, this could be related to issue 16536.

cdorin

cdorin

2020-08-03 21:25

reporter   ~59280

Last edited: 2020-08-04 15:38

Indeed, 16536. Confirmed.

Not sure about this one, cannot reproduced - could you please attach screenshots, @Mazi ?

Mazi

Mazi

2020-08-03 22:24

updater   ~59281

Last edited: 2020-08-04 15:38

I added three test tokens, then batch edited two of them. This lead to wrong results and no emails could be sent, icon was removed.

result.png (17,237 bytes)   
result.png (17,237 bytes)   
batch_edit.png (12,089 bytes)   
batch_edit.png (12,089 bytes)   
default.png (17,623 bytes)   
default.png (17,623 bytes)   
Mazi

Mazi

2020-08-03 22:25

updater   ~59282

Last edited: 2020-08-04 15:38

Screenshots are in wrong order, should be: default - batch edit - result.

c_schmitz

c_schmitz

2020-08-05 13:23

administrator   ~59320

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30346

c_schmitz

c_schmitz

2020-08-05 13:27

administrator   ~59321

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30347

c_schmitz

c_schmitz

2020-08-06 11:00

administrator   ~59335

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30348

c_schmitz

c_schmitz

2020-08-06 12:26

administrator   ~59338

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30350

lime_release_bot

lime_release_bot

2020-08-06 17:32

administrator   ~59345

Fixed in Release 4.3.9+200806

Related Changesets

LimeSurvey: 3.x-LTS 62f988ea

2020-08-05 13:23:20

c_schmitz

Details Diff
Fixed issue 16561: Batch-editing tokens does not set fields properly if "completed", "invitation sent" or "reminder sent" is set to No.
Fixed issue: When editing a token the date/time format is not properly displayed and handled on "invitation sent" or "reminder sent" field and thus wrong values are saved
Affected Issues
16561
mod - application/controllers/admin/tokens.php Diff File
mod - application/views/admin/token/tokenform.php Diff File

LimeSurvey: master f2b420b6

2020-08-05 13:23:20

c_schmitz

Details Diff
Fixed issue 16561: Batch-editing tokens does not set fields properly if "completed", "invitation sent" or "reminder sent" is set to No.
Fixed issue: When editing a token the date/time format is not properly displayed and handled on "invitation sent" or "reminder sent" field and thus wrong values are saved
Affected Issues
16561
mod - application/controllers/admin/tokens.php Diff File
mod - application/views/admin/token/tokenform.php Diff File

LimeSurvey: 3.x-LTS ff3729ef

2020-08-06 11:00:19

c_schmitz

Details Diff
Fixed issue 16561: Batch-editing tokens does not set fields properly if "completed", "invitation sent" or "reminder sent" is set to No.
Fixed issue: When editing a token the date/time format is not properly displayed and handled on "invitation sent" or "reminder sent" field and thus wrong values are saved
Affected Issues
16561
mod - application/controllers/admin/tokens.php Diff File

LimeSurvey: master ee736100

2020-08-06 11:00:19

c_schmitz

Details Diff
Fixed issue 16561: Batch-editing tokens does not set fields properly if "completed", "invitation sent" or "reminder sent" is set to No. Affected Issues
16561
mod - application/controllers/admin/tokens.php Diff File

Issue History

Date Modified Username Field Change
2020-08-03 12:59 Mazi New Issue
2020-08-03 13:00 Mazi Note Added: 59265
2020-08-03 21:25 cdorin Note Added: 59280
2020-08-03 22:24 Mazi Note Added: 59281
2020-08-03 22:24 Mazi File Added: result.png
2020-08-03 22:24 Mazi File Added: batch_edit.png
2020-08-03 22:24 Mazi File Added: default.png
2020-08-03 22:25 Mazi Note Added: 59282
2020-08-04 15:38 cdorin Priority none => normal
2020-08-04 15:38 cdorin Status new => confirmed
2020-08-04 15:38 cdorin Zoho Sprints => |Yes|
2020-08-04 15:38 swendrich Zoho Sprints ID => 14469000000204037
2020-08-05 12:37 c_schmitz Assigned To => c_schmitz
2020-08-05 12:37 c_schmitz Status confirmed => assigned
2020-08-05 13:23 c_schmitz Changeset attached => LimeSurvey 3.x-LTS 62f988ea
2020-08-05 13:23 c_schmitz Note Added: 59320
2020-08-05 13:23 c_schmitz Resolution open => fixed
2020-08-05 13:24 c_schmitz Status assigned => resolved
2020-08-05 13:27 c_schmitz Changeset attached => LimeSurvey master f2b420b6
2020-08-05 13:27 c_schmitz Note Added: 59321
2020-08-06 11:00 c_schmitz Changeset attached => LimeSurvey 3.x-LTS ff3729ef
2020-08-06 11:00 c_schmitz Note Added: 59335
2020-08-06 12:26 c_schmitz Changeset attached => LimeSurvey master ee736100
2020-08-06 12:26 c_schmitz Note Added: 59338
2020-08-06 17:32 lime_release_bot Zoho Sprints Yes => |Yes|
2020-08-06 17:32 lime_release_bot Note Added: 59345
2020-08-06 17:32 lime_release_bot Status resolved => closed