View Issue Details

IDProjectCategoryView StatusLast Update
16553Bug reportsLabel setspublic2021-03-11 11:21
ReporterMazi Assigned Toollehar  
PrioritynormalSeveritypartial_block 
Status newResolutionopen 
Product Version3.22.28 
Summary16553: Relevance equation not copied when loading answer options from a label set
DescriptionWhen saving a label set e.g. the sub-questions of a multi choice question and there are relevance equations applied to certain items, those relevance equations disappear when loading the label set at a different question.
Steps To ReproduceCreate a label set with relevance equation for some items.
Re-use the label set at a follow up question.
-> Releveance equations have disappeared
TagsNo tags attached.
Complete LimeSurvey version number (& build)3.22.28
I will donate to the project if issue is resolvedNo
BrowserChrome
Database & DB-VersionMySQL 5
Server OS (if known)Ubuntu 18
Webserver software & version (if known)Apache
PHP Version7.3

Activities

ollehar

ollehar

2021-03-10 17:12

administrator   ~63057

You're using an outdated version of LimeSurvey. Please update to the latest version and check if the bug can still be reproduced. Thank you.
Mazi

Mazi

2021-03-10 17:39

partner   ~63098

The instructions to reproduce this is 3 steps. It will take you a minute to test this yourself.

Simply asking users to test again and again if this is still an issue will surely lead to users not reporting bugs anymore. I am not sure if this is intended.
ollehar

ollehar

2021-03-10 17:49

administrator   ~63118

You want me to test 800 bugs manually, instead of distribute it to all different users? Nope. Not gonna happen.
Mazi

Mazi

2021-03-10 18:02

partner   ~63123

So what's the alternative? I have reported about a hundred bugs the last months and I will not re-test all the not yet fixed ones because of such a default message. I simply do not have time for that.
Then, what's going to happen? According to your standard procedure:
No feedback -> ticket gets closed though the bug is probably still there.
Reporter wil be disappointed and will not report bugs anymore.
What's the benefit?
ollehar

ollehar

2021-03-10 20:45

administrator   ~63130

Just answer "Yes, bug still there"?
Mazi

Mazi

2021-03-10 21:33

partner   ~63154

Sorry, but as a Limesurvey partner I need to earn some money so I can pay my fees. I can't spend my time with bug testing.
ollehar

ollehar

2021-03-10 21:35

administrator   ~63156

You don't have to test it, just answer "Yes" if you think it's not fixed.
Mazi

Mazi

2021-03-10 21:37

partner   ~63157

Well, but what if my crystal ball won't tell me whether this is fixed?!?
ollehar

ollehar

2021-03-10 21:38

administrator   ~63158

I trust you. ^^
f_funke

f_funke

2021-03-11 10:33

developer   ~63287

Thanks for reporting, @Mazi!

@Olle: I can confirm that behavior with 3.25.16 and with 4.4.10.

However, I am not sure if copying relevance is a good idea for label sets. As the name suggests these sets are about labels and not about more advanced options. But perhaps I don't see the actual use case. And there is the risk that users involuntarily apply relevance equations. Perhaps we could look for arguments for and against including relevances in label sets? If you need the relevances, why don't you just copy the question?
f_funke

f_funke

2021-03-11 10:34

developer   ~63288

Overall, I am a bit undecided about asking users to re-confirm a bug. I think if users did not use the most recent LimeSurvey version when reporting the bug we should ask for testing with a current version. But if a recent version has been used and the problem is the long backlog, then I would refrain from asking reporters to re-test. We should be grateful for each bug report.

On the other hand, if an issue is really important for the reporter, it would really help if the person tested again - especially when the reporter knows how much open tickets there are at the moment. #strongertogether

Is that reply worthy of Solomon?
f_funke

f_funke

2021-03-11 10:38

developer   ~63289

Back to topic:
At the moment, I would say not copying relevance equations into label sets is desired behavior.
Mazi

Mazi

2021-03-11 10:48

partner   ~63291

@f_funke: Thanks for your feedback Salomon/Frederik. I have to admit that I have never thought about the desired behavior. You are rigth that there are reasons for not copying relevance equations like re-using them at other surveys. But in such cases I would simply not store it with the relevance and add the relevance afterwards.
When saving a label set with relevance, you probably want to apply the same conditions. E.g. at a market research survey about cars, you may want to ask details for certain car brands conditionally at several follow up questions. In this case copying the relevance along makes a lot of sense.

In a nutshell: When having relevance applied to items of my label set, I assume that will be copied along.
A perfect solution would be to dynamically show a checkbox "save relevance" when saving a label set that has relevance applied.
ollehar

ollehar

2021-03-11 11:21

administrator   ~63293

I opened an internal forum thread where we can discuss the process of cleaning up Mantis: https://forums.limesurvey.org/forum/team-only/123953-cleaning-up-in-mantis#213236

Issue History

Date Modified Username Field Change
2020-07-31 16:54 Mazi New Issue
2021-03-10 17:12 ollehar Assigned To => ollehar
2021-03-10 17:12 ollehar Status new => feedback
2021-03-10 17:12 ollehar Note Added: 63057
2021-03-10 17:39 Mazi Note Added: 63098
2021-03-10 17:39 Mazi Status feedback => assigned
2021-03-10 17:49 ollehar Note Added: 63118
2021-03-10 18:02 Mazi Note Added: 63123
2021-03-10 20:45 ollehar Note Added: 63130
2021-03-10 21:33 Mazi Note Added: 63154
2021-03-10 21:35 ollehar Note Added: 63156
2021-03-10 21:36 ollehar Status assigned => new
2021-03-10 21:37 ollehar Priority none => normal
2021-03-10 21:37 Mazi Note Added: 63157
2021-03-10 21:38 ollehar Note Added: 63158
2021-03-11 10:33 f_funke Note Added: 63287
2021-03-11 10:34 f_funke Note Added: 63288
2021-03-11 10:38 f_funke Note Added: 63289
2021-03-11 10:48 Mazi Note Added: 63291
2021-03-11 11:21 ollehar Note Added: 63293