16461: Twice near the same sentence when open survey with token 2nd time

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

16461	Bug reports	Survey participants (Tokens)	public	2020-07-06 16:56	2020-07-21 09:38

Reporter	DenisChenu	Assigned To	DenisChenu
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	3.22.25

Summary	16461: Twice near the same sentence when open survey with token 2nd time
Description	When enter in survey with an already used token : sentence about contact are show 2 times
Steps To Reproduce	Import included survey Send with `TEST` token See screenshot
Additional Information	Since we have 'contact' part : i think 2nd message line can be removed Maybe there are other error page with 2 times contact part If want to keep multilingual part : only way are hide .message-1 with css
Tags	No tags attached.
Attached Files	Capture d’écran du 2020-07-06 16-51-45.png (39,544 bytes) Capture d’écran du 2020-07-06 16-51-45.png (39,544 bytes) survey_archive_137112.lsa (6,872 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)	3.22.25
I will donate to the project if issue is resolved	No
Browser	not relevant
Database type & version	not relevant
Server OS (if known)	not relevant
Webserver software & version (if known)	not relevant
PHP Version	not relevant

User List	There are no users monitoring this issue.

DenisChenu 2020-07-06 17:06 developer ~58727	In theme : adminname is always empty, muts use admin. Fix at same time

~~user225042~~ 2020-07-15 11:50 ~58950	Tested the issue by pulling the PR. Working as expected. Please refer the attachment for more details 16461_Tokenused_Messagedisplayedtwice.png (32,713 bytes) 16461_Tokenused_Messagedisplayedtwice.png (32,713 bytes)

DenisChenu 2020-07-15 15:58 developer ~58960	Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30285

DenisChenu 2020-07-16 09:32 developer ~58966	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30286

lime_release_bot 2020-07-21 09:38 administrator ~59011	Fixed in Release 4.3.5+200721

LimeSurvey: 3.x-LTS a1f72c47 2020-07-15 15:58:17 DenisChenu Committer: GitHub Details Diff	Fixed issue 16461: Twice contact sentence for some error page (#1469) Dev: remove duplicates, leave contact for theme only.	Affected Issues 16461
	mod - application/controllers/survey/index.php	Diff File
	mod - themes/survey/vanilla/views/layout_errors.twig	Diff File
LimeSurvey: master e247d8d8 2020-07-16 09:32:20 DenisChenu Details Diff	Fixed issue 16461: Twice contact sentence for some error page Dev: remove duplicates, leave contact for theme only. # Conflicts: # application/controllers/survey/index.php	Affected Issues 16461
	mod - application/controllers/survey/index.php	Diff File
	mod - themes/survey/vanilla/views/layout_errors.twig	Diff File

Date Modified	Username	Field	Change
2020-07-06 16:56	DenisChenu	New Issue
2020-07-06 16:56	DenisChenu	File Added: Capture d’écran du 2020-07-06 16-51-45.png
2020-07-06 16:56	DenisChenu	File Added: survey_archive_137112.lsa
2020-07-06 17:06	DenisChenu	Note Added: 58727
2020-07-15 11:50	~~user225042~~	Note Added: 58950
2020-07-15 11:50	~~user225042~~	File Added: 16461_Tokenused_Messagedisplayedtwice.png
2020-07-15 11:52	~~user225042~~	Status	new => ready for testing
2020-07-15 15:58	DenisChenu	Changeset attached	=> LimeSurvey 3.x-LTS a1f72c47
2020-07-15 15:58	DenisChenu	Note Added: 58960
2020-07-15 15:58	DenisChenu	Assigned To	=> DenisChenu
2020-07-15 15:58	DenisChenu	Resolution	open => fixed
2020-07-16 09:32	DenisChenu	Changeset attached	=> LimeSurvey master e247d8d8
2020-07-16 09:32	DenisChenu	Note Added: 58966
2020-07-21 09:38	lime_release_bot	Note Added: 59011
2020-07-21 09:38	lime_release_bot	Status	ready for testing => closed