View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
14475Bug reportsComfortUpdatepublic2019-01-31 10:142020-03-14 17:41
Reporterjelo Assigned ToLouisGac 
PrioritynoneSeveritycrash 
Status closedResolutionreopened 
Summary14475: update.zip cannot be extracted by ComfortUpdate
Description

ComfortUpdate shows an error message, that it cannot extract the update archive.

The archive is available in the path under tmp.
update.zip 569 KB (583.079 bytes)
SHA256: 8CF75AF27EBF619572DA2A30603CA896E6A129909413D304A48B8C78F73157BB

So the extracting routine itself might struggle with the ZIP archive.

Can happen with different LS versions on different platforms (PHP 5.6, PHP 7.1).

Steps To Reproduce

Just run ComfortUpdate.

Additional Information

https://www.limesurvey.org/forum/comfortupdate/117551-comfort-update-unzip-error

TagsNo tags attached.
Attached Files
20190131.ComfortUpdateZipError.JPG (29,920 bytes)   
20190131.ComfortUpdateZipError.JPG (29,920 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)3.15.1 / 2.06 LTS
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)CentOS 7
Webserver software & version (if known)
PHP Version5.6.X

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2019-01-31 11:21

developer   ~50356

can't reproduce here.
please, what is the build number of your installation?
jelo

jelo

2019-01-31 11:35

partner   ~50357

The threadstarter has the issue with a newer system.

I have tried to reproduce it during my check of very old installations to see if the ComfortUpdater is working from older installations.

$config['versionnumber'] = "2.06lts";
$config['dbversionnumber'] = 184;
$config['buildnumber'] = 160524;
$config['updatable'] = true;

How is the update.zip build? It is compressed on the new updateserver? Perhaps the default settings of compressing have changed?
LouisGac

LouisGac

2019-01-31 11:38

developer   ~50358

thx I will try again now
jelo

jelo

2019-01-31 12:08

partner   ~50359

Issue is still there. The header of the ZIP archive contains data behind the payload, which seems to not usually there.
At least testing the archive with 7zip shows an error. Files itself are fine.
What extracting function is used? Is there perhaps a fallback which hits on certain OS with certain libs?
LouisGac

LouisGac

2019-01-31 13:39

developer   ~50362

ComfortUpdate on 2.6 works perfectly fine on php5.6
2.6 doesn't support php7, nor php5.2
ComfortUpdate doesn't work on L2.6 with php 5.2 or php 7
LouisGac

LouisGac

2019-01-31 16:06

developer   ~50373

So, I changed the way the download is generated from server.
it should work even with weird config now.
I reopen the ticket so you can give feedback

Issue History

Date Modified Username Field Change
2019-01-31 10:14 jelo New Issue
2019-01-31 10:14 jelo Status new => assigned
2019-01-31 10:14 jelo Assigned To => LouisGac
2019-01-31 10:14 jelo File Added: 20190131.ComfortUpdateZipError.JPG
2019-01-31 11:21 LouisGac Note Added: 50356
2019-01-31 11:35 jelo Note Added: 50357
2019-01-31 11:38 LouisGac Note Added: 50358
2019-01-31 12:08 jelo Note Added: 50359
2019-01-31 13:39 LouisGac Status assigned => closed
2019-01-31 13:39 LouisGac Resolution open => no change required
2019-01-31 13:39 LouisGac Note Added: 50362
2019-01-31 16:06 LouisGac Status closed => new
2019-01-31 16:06 LouisGac Resolution no change required => reopened
2019-01-31 16:06 LouisGac Note Added: 50373
2020-03-14 17:41 c_schmitz Status new => closed