View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
13190Bug reportsSurvey editingpublic2018-01-17 04:302018-01-30 14:57
Reporterkllam Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.0.x 
Fixed in Version3.0.x 
Summary13190: Multiple choice with comments function "Remove text or uncheck checkbox automatically" not work
Description

Use "Multiple choice with comments"

Logic
Remove text or uncheck checkbox automatically tuned on

In the old version (2.05), users have to tick a checkbox AND write comments for ticked checkbox before submitting
However, In this version (3.0.3) user can submit ticking a checkbox WITHOUT writing any comments.

Steps To Reproduce

Please ref attachment

TagsNo tags attached.
Attached Files
V2.05.PNG (20,092 bytes)   
V2.05.PNG (20,092 bytes)   
V3.0.3.PNG (29,677 bytes)   
V3.0.3.PNG (29,677 bytes)   
Bug heat10
Complete LimeSurvey version number (& build)Version 3.0.3+180112
I will donate to the project if issue is resolvedNo
BrowserIE 11, Chrome Version 63.0.3239.132
Database type & versionMysql Ver 14.14 Distrib 5.7.20
Server OS (if known)CentOS 7
Webserver software & version (if known)Apache/2.4.6 (CentOS)
PHP VersionPHP 7.2.1

Users monitoring this issue

There are no users monitoring this issue.

Activities

markusfluer

markusfluer

2018-01-17 14:48

administrator   ~45865

Can anyone confirm that this also worked in 2.7X.X?
DenisChenu

DenisChenu

2018-01-17 15:14

developer   ~45866

There are an option in advanced question settings.

It work in 3.0.0-alpha1 (before moving to twig).
In 2.71.1 the settings "Remove text or uncheck checkbox automatically:" seems broken. I' sure it's OK in 2.5X

Else : with the previous solution (2.6lts) : only javascript solution, now it's a PHP +JS solution (included in EM)

The js file remove the checkbox or the text is here : https://github.com/LimeSurvey/LimeSurvey/blob/master/assets/scripts/multiplechoice_withcomments.js

limesurvey_survey_47483.lss (22,119 bytes)
kllam

kllam

2018-01-19 04:02

reporter   ~45904

Great, i fixed it. Change the multiplechoice_withcomments.js line 3 like this

//var question=$("#question"+qID+" .questions-list");
var question=$("#question"+qID+" .answers-list");
DenisChenu

DenisChenu

2018-01-19 08:38

developer   ~45908

Your fix seems great :).

And it's right : https://manual.limesurvey.org/Theme_editor#Global_classes_for_question_part

user70560

2018-01-19 09:26

  ~45909

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=26131
DenisChenu

DenisChenu

2018-01-19 09:45

developer   ~45910

Thanks @kllam , great :)
c_schmitz

c_schmitz

2018-01-24 15:50

administrator   ~46015

Version 3.1.0 released
DenisChenu

DenisChenu

2018-01-30 14:57

developer   ~46157

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=26267

Related Changesets

LimeSurvey: master fd57054c

2018-01-19 09:26:28

kllam


Committer: user70560 Details Diff 		Fixed issue 13190 : Remove text or uncheck checkbox automatically not work Affected Issues
13190
mod - assets/scripts/multiplechoice_withcomments.js Diff File

LimeSurvey: master abef4c6f

2018-01-19 19:01:18

DenisChenu

Details Diff 		Merge branch 'master' of https://github.com/LimeSurvey/LimeSurvey.git into master_RC_AuthPlugin
Dev: fix conflict
* 'master' of https://github.com/LimeSurvey/LimeSurvey.git: (84 commits)
Dev: remove deprecated code _GetSessionUserRights Dev: USER_RIGHT_INITIALSUPERADMIN replaced by config Dev: and not used since 2.6lts or before
Fixed issue 13200: LDAP Auth plugin user autocreate broken Dev: just unsubscribe from beforeHasPermission when needed Dev: i hate to find a one line fix after testing, hacking for hours …
Dev: removed special characters from sidemenu
Dev: minimal changes and typo fixing
Dev: translate surveymenuentried
Fixed issue: language error
Fixed issue 13212: missing translation frontend survey
Fixed issue: Emailtemplate reset not working
Fixed issue 13215: Missing string
Fixed issue 13216: missing translation
Updated translation: Catalan by qualitatuvic Updated translation: German by c_schmitz Updated translation: Hungarian by kkd Updated translation: Norwegian (Bokmål) by pmonstad Updated translation: Polish by elissa Updated translation: German (Informal) by c_schmitz Updated translation: Polish (Informal) by elissa
Fixed issue 13193: Unable to update question type (simple selector)
Dev: added a demomode command to not only restore mint status but also install some demo surveys
Fixed issue: Demo rendered unusable with wipe command
New feature 12240: Validation settings for "array by column" question type
Fixed issue 13190 : Remove text or uncheck checkbox automatically not work
Updated translation: Danish by abc99 Updated translation: Georgian by zch5368
Updated translation: German by c_schmitz Updated translation: Hungarian by kkd Updated translation: Japanese by nomoto Updated translation: Norwegian (Bokmål) by pmonstad Updated translation: Romanian by cdorin
Fixed issue: Captcha not showing
Removed translation: Papiamento (Aruba)
...

# Conflicts:
# application/helpers/remotecontrol/remotecontrol_handle.php		 Affected Issues
13190, 13193, 13200, 13212, 13215, 13216
add - application/commands/DemomodeCommand.php Diff File
mod - application/commands/WipeCommand.php Diff File
mod - application/commands/console.php Diff File
add - application/config/fonts.php Diff File
mod - application/config/internal.php Diff File
mod - application/config/packages.php Diff File
add - application/config/questiontypes.php Diff File
mod - application/config/third_party.php Diff File
mod - application/config/updater_version.php Diff File
mod - application/config/version.php Diff File
mod - application/controllers/AdminController.php Diff File
mod - application/controllers/SurveyController.php Diff File
mod - application/controllers/admin/PluginHelper.php Diff File
mod - application/controllers/admin/authentication.php Diff File
mod - application/controllers/admin/index.php Diff File
mod - application/controllers/admin/questions.php Diff File
mod - application/controllers/admin/tokens.php Diff File
mod - application/controllers/admin/usergroups.php Diff File
add - application/core/ConsoleHttpSession.php Diff File
add - application/core/LSCaptcha.php Diff File
mod - application/core/LS_Twig_Extension.php Diff File
mod - application/core/LsDefaultDataSets.php Diff File
mod - application/core/plugins/AuthLDAP/AuthLDAP.php Diff File
mod - application/extensions/admin/grid/MassiveActionsWidget/assets/listActions.js Diff File
mod - application/extensions/admin/survey/ListSurveysWidget/assets/reload.js Diff File
mod - application/extensions/captchaExtended/CaptchaExtendedAction.php Diff File
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/helpers/frontend_helper.php Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - application/helpers/questionHelper.php Diff File
mod - application/helpers/remotecontrol/remotecontrol_handle.php Diff File
mod - application/helpers/surveytranslator_helper.php Diff File
mod - application/helpers/update/updatedb_helper.php Diff File
mod - application/models/QuestionAttribute.php Diff File
mod - application/models/Survey.php Diff File
mod - application/models/SurveyLanguageSetting.php Diff File
mod - application/models/Surveymenu.php Diff File
mod - application/models/SurveymenuEntries.php Diff File
mod - application/models/Template.php Diff File
mod - application/models/TemplateConfiguration.php Diff File
mod - application/models/TokenDynamic.php Diff File
mod - application/views/admin/emailtemplates/email_language_template_tab.php Diff File
mod - application/views/admin/global_settings/_email.php Diff File
mod - application/views/admin/super/layout_insurvey.php Diff File
mod - application/views/admin/survey/Question/editQuestion_view.php Diff File
mod - application/views/admin/survey/Question/question_subviews/_ajax_variables.php Diff File
mod - application/views/admin/survey/_activation_error.php Diff File
mod - application/views/admin/themeoptions/update.php Diff File
mod - application/views/admin/token/browse.php Diff File
mod - application/views/admin/token/emailpost.php Diff File
mod - application/views/admin/token/emailwarning.php Diff File
rm - application/views/survey/questions/answer/5pointchoice/answer.php Diff File
add - application/views/survey/questions/answer/5pointchoice/answer.twig Diff File
rm - application/views/survey/questions/answer/5pointchoice/rows/item_row.php Diff File
add - application/views/survey/questions/answer/5pointchoice/rows/item_row.twig Diff File
mod - application/views/survey/questions/answer/list_dropdown/rows/othertext.php Diff File
mod - application/views/survey/questions/answer/listradio/rows/answer_row_other.php Diff File
mod - application/views/survey/questions/answer/multiplenumeric/rows/dynamic.twig Diff File
mod - application/views/survey/questions/answer/multiplenumeric/rows/dynamic_slider.twig Diff File
mod - application/views/survey/questions/answer/multiplenumeric/rows/sliders/answer_row.twig Diff File
mod - assets/packages/limesurvey/survey.js Diff File
add - assets/packages/questions/5pointchoice/css/emoji.css Diff File
add - assets/packages/questions/5pointchoice/css/ss-emoji.css Diff File
add - assets/packages/questions/5pointchoice/fonts/noto_emoji_color.ttf Diff File
add - assets/packages/questions/5pointchoice/fonts/noto_emoji_regular.ttf Diff File
add - assets/packages/questions/5pointchoice/fonts/ss-emoji-adobe-mozilla.ttf Diff File
mod - assets/scripts/admin/questions.js Diff File
mod - assets/scripts/admin/tokens.js Diff File
mod - assets/scripts/multiplechoice_withcomments.js Diff File
mod - assets/scripts/survey_runtime.js Diff File
mod - docs/release_notes.txt Diff File
mod - framework/cli/views/webapp/protected/controllers/SiteController.php Diff File
mod - index.php Diff File
mod - locale/_template/limesurvey.pot Diff File
mod - locale/ca/ca.mo Diff File
mod - locale/da/da.mo Diff File
mod - locale/de-informal/de-informal.mo Diff File
mod - locale/de/de.mo Diff File
mod - locale/es/es.mo Diff File
mod - locale/hu/hu.mo Diff File
mod - locale/it-informal/it-informal.mo Diff File
mod - locale/it/it.mo Diff File
mod - locale/ja/ja.mo Diff File
mod - locale/ka/ka.mo Diff File
mod - locale/nb/nb.mo Diff File
mod - locale/nl-informal/nl-informal.mo Diff File
mod - locale/nl/nl.mo Diff File
mod - locale/nn/nn.mo Diff File
rm - locale/pap-AW/index.html Diff File
rm - locale/pap-AW/pap-AW.mo Diff File
mod - locale/pl/pl.mo Diff File
mod - locale/ro/ro.mo Diff File
add - tests/LimeSurveyWebDriver.php Diff File
mod - tests/TestBaseClass.php Diff File
mod - tests/TestBaseClassWeb.php Diff File
mod - tests/TestHelper.php Diff File
mod - tests/bootstrap.php Diff File
add - tests/data/surveys/limesurvey_survey_143933.lss Diff File
add - tests/surveys/LanguageChangerTest.php Diff File
mod - themes/question/ranking_advanced/survey/questions/answer/ranking/answer.twig Diff File
mod - themes/survey/bootswatch/options/options.twig Diff File
mod - themes/survey/bootswatch/scripts/theme.js Diff File
mod - themes/survey/fruity/options/options.twig Diff File
mod - themes/survey/vanilla/options/options.twig Diff File
mod - themes/survey/vanilla/scripts/theme.js Diff File
mod - themes/survey/vanilla/views/layout_user_forms.twig Diff File
mod - themes/survey/vanilla/views/subviews/content/load.twig Diff File
mod - themes/survey/vanilla/views/subviews/content/save.twig Diff File
add - themes/survey/vanilla/views/subviews/content/userforms.twig Diff File
add - themes/survey/vanilla/views/subviews/logincomponents/captcha.twig Diff File
add - themes/survey/vanilla/views/subviews/logincomponents/token.twig Diff File
mod - themes/survey/vanilla/views/subviews/navigation/language_changer_top_menu.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/printanswers_head.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/printanswers_question.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/printanswers_table.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/question_types/template_array-increase-same-decrease.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/question_types/template_array-yes-uncertain-no.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/question_types/template_boilerplate.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/question_types/template_gender.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/question_types/template_upload-files.twig Diff File
mod - themes/survey/vanilla/views/subviews/printanswers/question_types/template_yes-no.twig Diff File
mod - themes/survey/vanilla/views/subviews/registration/register_form.twig Diff File
mod - themes/survey/vanilla/views/subviews/registration/register_message.twig Diff File
mod - themes/survey/vanilla/views/subviews/registration/register_success.twig Diff File
mod - themes/survey/vanilla/views/subviews/registration/required.twig Diff File
mod - themes/survey/vanilla/views/subviews/survey/group_subviews/group_desc.twig Diff File
mod - themes/survey/vanilla/views/subviews/survey/group_subviews/group_name.twig Diff File
rm - upload/surveys/index.html Diff File
rm - upload/surveys/readme.txt Diff File
rm - upload/templates/index.html Diff File
rm - upload/templates/readme.txt Diff File
rm - upload/themes/question/index.html Diff File
rm - upload/themes/survey/index.html Diff File

Issue History

Date Modified Username Field Change
2018-01-17 04:30 kllam New Issue
2018-01-17 04:30 kllam File Added: V2.05.PNG
2018-01-17 04:30 kllam File Added: V3.0.3.PNG
2018-01-17 14:48 markusfluer Note Added: 45865
2018-01-17 15:14 DenisChenu File Added: limesurvey_survey_47483.lss
2018-01-17 15:14 DenisChenu Note Added: 45866
2018-01-19 04:02 kllam Note Added: 45904
2018-01-19 08:38 DenisChenu Note Added: 45908
2018-01-19 08:38 DenisChenu Assigned To => DenisChenu
2018-01-19 08:38 DenisChenu Status new => assigned
2018-01-19 09:26 user70560 Changeset attached => LimeSurvey master fd57054c
2018-01-19 09:26 user70560 Note Added: 45909
2018-01-19 09:26 user70560 Assigned To DenisChenu => user70560
2018-01-19 09:26 user70560 Resolution open => fixed
2018-01-19 09:45 DenisChenu Assigned To user70560 => DenisChenu
2018-01-19 09:45 DenisChenu Status assigned => resolved
2018-01-19 09:45 DenisChenu Fixed in Version => 3.0.x
2018-01-19 09:45 DenisChenu Note Added: 45910
2018-01-24 15:50 c_schmitz Note Added: 46015
2018-01-24 15:50 c_schmitz Status resolved => closed
2018-01-30 14:57 DenisChenu Changeset attached => LimeSurvey master abef4c6f
2018-01-30 14:57 DenisChenu Note Added: 46157
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing