| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 12482 | Bug reports | Survey editing | public | 2017-06-21 11:47 | 2017-07-21 17:08 |
| Reporter | tammo | Assigned To | DenisChenu | ||
| Priority | none | Severity | partial_block | ||
| Status | closed | Resolution | fixed | ||
| Summary | 12482: HTML of MC with or without comments differs | ||||
| Description | Please see attached image: results in different styling of labels. But I think HTML must be similar. | ||||
| Tags | No tags attached. | ||||
| Bug heat | 6 | ||||
| Complete LimeSurvey version number (& build) | 3.0 git recent | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | Chrome | ||||
| Database type & version | MySQL | ||||
| Server OS (if known) | W10 | ||||
| Webserver software & version (if known) | XAMPP | ||||
| PHP Version | 5.5.50 | ||||
 |
Denis, is this something you can decide on? The current HTML for these similar question differs too much, I think. |
 |
I take a look :). In 2.5 : moved to table :/ |
|
|
Is table the best solution? Or div or li? What about consistency? I believe you had the strongest opinions on that. Pour moi, c'est egale... |
|
|
Oh no ! Not a table. But ul > li > input + label for multiple
We need the div inside the li for multiple choice qith comment. And we can compare too with multiple text. Here there are a lack of ls-answers class for the label. |
|
|
May I ask you to look into this? I compared the answer_row.php and answer_row.twig of MC with comments (.php) and MC (without comments) (.twig), but I am unsure what to change. It seems that there are missing even two divs in the .twig file and classes are not similar... |
|
|
I think the .twig template for answers_row of MC without comment is a first try of LouisGac? Maybe you could improve it as a new standard for the newer templates? Please? |
|
|
Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=23213 |
|
|
Class CAN NOT be similar : we have checkbox+text : it
|
|
|
I guess you are right: the questions are similar (= very much like each other), but not identical (= exactly the same). |
|
|
Did you test the last one ? I'm unsure about the align right for multiple-text. Maybe we can remove the form-horizontal : we don't use it in another question type. form-horizontal are used for multiple-text and multiple-numeric. template.css can easily be used to move it at left. But : currently : i try to make new template and … see a lot of issue :/ |
|
|
You are right: "mc with comments" is more like "multiple short texts (MT)" than like "mc without comments" I think it must be a template developers decision to right-align or left align. In MT there is the possibility to define Text input box width and Label column width wich are missing in MC with comments. So this may become a feature request to define MC with comments such that it has the options of MC without comments and the options of Multiple short texts. in_mt_but_not_in_mc_with_comments.png (5,310 bytes) |
|
|
About text input box + Label column : The are only 1 column in Multiple choice. Then we can not add Box width. And there are column number : for multiple choice and radio list only. Default is always 4/8 for columns , if you set one, the other default is 12-(X) : https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/helpers/qanda_helper.php#L6413 about rigt-align : you think we must remove form-horizontal class ? Maybe add .form-horizontal label{text-align:left} is better. It's an horizontal form finally ;) PS : you can test column-width to 0 (hidden) ;) |
|
|
As Denis said: "MC with comment" is really "Multiple texts with checkbox"... Couldn't we use the code base of multiple text for this question type? And add an extra option: add checkbox as an option? |
 |
Version 3.0.0-beta.1 released |
