https://github.com/LimeSurvey/LimeSurvey/pull/639

1. Sincerely : since more than 5 years of user helper on forum : i never see one user asking something like that.
2. printablesurvey are not standardized
3. if need a print whole to be seen/study : pdf is better

I would say HTML is better to use if you need to to co-work with doc formats where the actual pre-programming editing goes (eg breaking lines etc).

1. Indeed, here, we have a lot of people asking for an easy review system. We're thinking about building a new tool to do that (adding comments on a survey, etc), but this feature already gives a way to do it.
2. I agree
3. Converting from HTML to PDF is easy, or from HTML to anything. At the contrary, converting a PDF to anything else can make a lot of problems

Also, he's just adding a button in the export action, I see no problem with that.

@1: We have coded a review system for a client. It adds a single text question for each survey page that allows entering comments. In addition to that we also load (using Ajax) previously entered text comments at these question so other can read what colleagues have commented.

@t6nnp6nn : You should add a check if required image files exist at /application/controllers/admin/printablesurvey.php(1714):
1714 $image_dimensions = getimagesize(PRINT_TEMPLATE_DIR.'files/printimg'.$type.'.png');

I get a PHP warning there: getimagesize(/var/www/vhosts/mysurveyhosting.com/limesurvey/upload/templates/templatename/files/print_img_radio.png): failed to open stream: No such file or directory

One general question: What's the benefit of getting all the HTML of the survey if we can't display it properly after download because no embedded CSS files are loaded? Can we improve that so we can make it a package that can be forwarded to others that includes the survey structure (HTML) + design details (image, CSS)?

The benefit? See the original post. I am using for archiving - collaboration.

All material under the template folder is packed with the zip and the CSS of the template itself is loaded. I have not tested it with too many templates though. Works for me at least.

All assets related to Yii are not included, yes.

@Mazi regarding the error you are getting. Are you able to view the printable version through LS?

@t6nnp6nn: The error also shows up with the printable version because the path to the "printimg..." files is hard coded but at some templates these reside at a different location (e.g. with older templates these were not located within the /files folder but at the template root).
Anyway, that is no serious issue.

RE "All material under the template folder is packed with the zip and the CSS of the template itself is loaded.": At my tests the ZIP files created even when using the default template only contained one single .html file. No images, no CSS, so the file when being viewed at the browser looks pretty ugly.
Is that a bug or a missing feature?

Must be an issue if you only get html files.
the whole template folder gets included here:
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/admin/export.php#L1388

regarding the missing image. It is not related with this feature. I would think the image should be in CSS instead of hard-coded. But again - it's a separate issue - not related to this change at all.

Yes, the missing file is more template related, no bug related to this feature.

But the missing CSS and other files I would consider a bug. Do you need any more details to debug this? LS version tested is 2.64.7+170404.

I currently tested on 2.64.7 which is the latest release in github. I will see if I get my hands around 2.64.7+170404 to test.
can you test with some default templates to see if they pack the assets?

I tested the default template and only the single html file was created.

I tested on here:
https://demo.limesurvey.org
just to test an alternative version. And it works as expected.

tested on v2.65.0 (current master) - also works as expected.

I am unable to reproduce. Also unable to get my hands on v2.64.7 for now.

Maybe you can test with 'debug'=>2, and see if you get any error output ?

I also only get the HTML file, no template assets exported.

Environment:

• Windows 10
• XAMPP
• PHP Version 5.5.19
• Apache/2.4.10
• mysqlnd 5.0.11
• LimeSurvey version 2.65.0 (pulled today)
• Default template

@tpartner
Maybe you can test with 'debug'=>2, and see if you get any error output ?
or look for errors / warnings in apache logs?

I have tested on various installations on different set-ups and I am unable to reproduce.

@t6nnp6nn, did that - no errors in either case.

I also tried from https://demo.limesurvey.org with the same result. (export attached)

@tpartner I am a bit confused. What do you mean by same result ?

The zip you provided has the whole template folder included as meant to.

@t6nnp6nn, that's not what I see (capture-2.png).

And, opening questionnaire_214844_en.html gives an un-styled page (capture-3.png).

capture-3.png (15,622 bytes)   

capture-3.png (15,622 bytes)   

capture-2.png (24,748 bytes)   

capture-2.png (24,748 bytes)   

pretty weird stuff :)
See my image from your zip

Screenshot from 2017-05-18 15:11:38.png (39,455 bytes)   

Screenshot from 2017-05-18 15:11:38.png (39,455 bytes)   

@t6nnp6nn, it may be a Windows issue. What are you testing on?

Yes, Im running ubuntu 14.
Asked my colleague to open an by default his winzip PRO showed correct content.
But opening by windows file explorer shows what you see. Win 10 that is.

I wonder if there might be something wrong with the ZIP format generated?
Try to use a different extractor

Just to confirm: I am also using a Windows (10) PC and never got more than a single html file within the export.

Okay, so I can extract the template files with 7-Zip so there is obviously a problem when using the native Windows extraction tool.

Unfortunately, that is what a large percentage of users will try to use.

I can confirm that using 7zip extracts the "template" folder as well.

But at console, there are still ~32 files not being loaded (file not found error). Some from the "assets" folder, some from /styles or /scripts. The HTML layout therefore still looks very "basic" (no colors, logos , ...).

OK. tried to open with 7Zip on Win10 and this kind of shows an no-named empty folder in the root.
Maybe there is a problem with an extra directory separator in the beginning.
I will look into that a bit.
Thanks.

No problem. Ping me when ready to re-test.

l'Il lmake a separate issue regarding the zip