View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
12006 | Bug reports | Theme editor | public | 2016-12-13 13:24 | 2017-07-21 17:07 |
Reporter | ervit | Assigned To | ollehar | ||
Priority | none | Severity | tweak | ||
Status | closed | Resolution | won't fix | ||
Product Version | 2.55.x | ||||
Fixed in Version | 3.0.x | ||||
Summary | 12006: Hiding empty help div in Default Theme template.js function | ||||
Description | The help text div is not always hidden in the Default Theme. The div <div class="row question-wrapper question-help-container"> is only fully hidden in short text questions. The error is in a JS function inside template.js functino "// Hide question help container if empty" This code is wrong because it calls the wrong class (should be ('.question-help-container') ) and also checks its own inner HTML instead of the help-text div's inner HTML (should trim children's html). This doesn't work: | ||||
Steps To Reproduce | The easiest way to see this is to edit the order of {QUESTIONHELP} in the template question.pstpl: place it between the question text {QUESTION_TEXT} and question valid text {QUESTION_VALID_MESSAGE}, and then run a survey. In questions with no help text, which are also not short-text, there will be a blank line corresponding to the empty question-help-container div. The correct code is below | ||||
Additional Information | This is the correct code: // Hide question help container if empty | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 2.57.1+161205 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | FF 50 | ||||
Database type & version | MySQL from GoDaddy | ||||
Server OS (if known) | Linux | ||||
Webserver software & version (if known) | GoDaddy shared hosting | ||||
PHP Version | 5.3 | ||||
Completely rewritten on 3.0 version. |
|
And there are an issue in this sytem : exemple Think it must be a no fix for 2.5X |
|
Will fix in 3.0.0 instead. |
|
Also, I would prefer if things were hidden in PHP on server side, not on client. It looks better. |
|
hidden by css , and here : it's for pstpl file <div class="help">{QUESTIONHELP}</div> We can do Css Remind : we can have expression in help, if you hide in PHP : you need a css way too. |
|
CSS sounds find. I guess Twig might be able to branch on empty, too. |
|
Yes : we can remove it, ot really an issue. But even if remove it : we need another solution : then : css only seems the best no ? |
|
Agree. |
|
Version 3.0.0-beta.1 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-12-13 13:24 | ervit | New Issue | |
2016-12-15 09:47 | DenisChenu | Note Added: 42547 | |
2016-12-15 11:05 | DenisChenu | Note Added: 42548 | |
2016-12-20 17:50 | ollehar | Assigned To | => ollehar |
2016-12-20 17:50 | ollehar | Status | new => resolved |
2016-12-20 17:50 | ollehar | Resolution | open => won't fix |
2016-12-20 17:50 | ollehar | Fixed in Version | => 3.0.x |
2016-12-20 17:50 | ollehar | Note Added: 42577 | |
2016-12-20 17:51 | ollehar | Note Added: 42579 | |
2016-12-20 19:05 | DenisChenu | Note Added: 42581 | |
2016-12-21 11:00 | ollehar | Note Added: 42583 | |
2016-12-21 11:05 | DenisChenu | Note Added: 42584 | |
2016-12-21 11:16 | ollehar | Note Added: 42586 | |
2017-07-21 17:07 | c_schmitz | Note Added: 44126 | |
2017-07-21 17:07 | c_schmitz | Status | resolved => closed |