View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
11980Bug reportsExpression Managerpublic2017-01-06 20:43
Reporternetdeals Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Fixed in Version2.56.x 
Summary11980: equation type question is displayed although it should have been hidden
Description

It appears a bug was introduced recently and the equation type question no longer stays hidden as anticipated. The attached LSS works fine in version 2.51 build 160901, but fails in version 2.56 build 161118. In the latest build, the hidden question group Q0 shows up in the main page as well as in the “Question index” area, even though it should have been hidden in both places. The attached screenshot shows how it should be (as in version 2.51 build 160901). I am not sure if this is the unintended side effect from the resolution for bug 11874.

Steps To Reproduce

Load the attached LSS and compare to the attached screenshot to see difference

TagsNo tags attached.
Attached Files
limesurvey.expected.display.png (18,842 bytes)   
limesurvey.expected.display.png (18,842 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)version 2.56 build 161218
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)Windows Server 2008 R2
Webserver software & version (if known)IIS 7.5
PHP Version5.6.24

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-12-06 08:34

developer   ~42384

"the hidden question group Q0 shows up .... in the “Question index” area, even though it should have been hidden in both places. " It never work in index for a good reason : if we test whole system : there a lot of chance we have memory issue. Are you sure it work on previous system ?

It work only after the group

DenisChenu

DenisChenu

2016-12-06 08:43

developer   ~42387

OK : first group : all question hidden : then group is hidden.

But : the issue is : the question don't have 'hidden' attribute, and this attribute are not saved

DenisChenu

DenisChenu

2016-12-06 08:47

developer   ~42388

Really strange :

  • Set 'hidden' to true only : was not saved
  • Set ' Insert page break in printable view: ' to true : savec
  • Set 'hidden' to true : saved

??? WTF

When the 2 question are set to hidden : it's OK. It's a admin GUI issue

DenisChenu

DenisChenu

2016-12-06 09:33

developer   ~42389

OK, attribute is not found because language is set .... grrrr

DenisChenu

DenisChenu

2016-12-06 09:58

developer   ~42390

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21699

DenisChenu

DenisChenu

2016-12-06 10:13

developer   ~42391

Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21701

DenisChenu

DenisChenu

2016-12-06 11:32

developer   ~42399

fixed in 2.57.X

c_schmitz

c_schmitz

2017-01-06 12:15

administrator   ~42657

New version released.

netdeals

netdeals

2017-01-06 20:43

reporter   ~42669

This issue is confirmed on January 6, 2017, to have been fixed in the release limesurvey2.58.0+170104. Thanks so much.

Related Changesets

LimeSurvey: master 54a2cce7

2016-12-06 09:55:56

DenisChenu

Details Diff
Fixed issue 11980: attribute of question are not found on some surveys
Dev: no language attribute with language
Dev: don't remind when we save the language for no language attribute (here hidden)
Dev: fix it when save, and found it when load
Affected Issues
11980
mod - application/controllers/admin/database.php Diff File
mod - application/models/QuestionAttribute.php Diff File

LimeSurvey: develop 2de852b1

2016-12-06 10:13:05

DenisChenu

Details Diff
Fixed issue 11980: attribute of question are not found on some surveys
Dev: same fix
Dev: remove the test for multiflexible_step : it's an integer type, then a type='number'
Dev: if need a test : use attribute['type']
Affected Issues
11980
mod - application/controllers/admin/database.php Diff File

Issue History

Date Modified Username Field Change
2016-12-05 23:19 netdeals New Issue
2016-12-05 23:19 netdeals File Added: limesurvey_survey_424748.lss
2016-12-05 23:20 netdeals File Added: limesurvey.expected.display.png
2016-12-06 08:34 DenisChenu Note Added: 42384
2016-12-06 08:43 DenisChenu Note Added: 42387
2016-12-06 08:43 DenisChenu Assigned To => DenisChenu
2016-12-06 08:43 DenisChenu Status new => assigned
2016-12-06 08:47 DenisChenu Note Added: 42388
2016-12-06 08:47 DenisChenu Assigned To DenisChenu =>
2016-12-06 08:47 DenisChenu Status assigned => new
2016-12-06 09:33 DenisChenu Note Added: 42389
2016-12-06 09:33 DenisChenu Assigned To => DenisChenu
2016-12-06 09:33 DenisChenu Status new => assigned
2016-12-06 09:58 DenisChenu Changeset attached => LimeSurvey master 54a2cce7
2016-12-06 09:58 DenisChenu Note Added: 42390
2016-12-06 09:58 DenisChenu Resolution open => fixed
2016-12-06 10:13 DenisChenu Changeset attached => LimeSurvey develop 2de852b1
2016-12-06 10:13 DenisChenu Note Added: 42391
2016-12-06 11:31 DenisChenu Status assigned => resolved
2016-12-06 11:31 DenisChenu Fixed in Version => 2.56.x
2016-12-06 11:32 DenisChenu Note Added: 42399
2017-01-06 12:15 c_schmitz Note Added: 42657
2017-01-06 12:15 c_schmitz Status resolved => closed
2017-01-06 20:43 netdeals Note Added: 42669