Alternative : fix it only when edit BUT : protect file access

Idea :

1. create a views/survey/pstpl/ directory with this 2 news pstpl file.
2. add a function to pstplContents(file.pstpl) : git it from template, and if not found : in the view directory

After we can fix/update this funtion, move to a lib or an helper more easily (for parent-template system).

Just a feedback on the last idea, because it's a lot related to the next evolution (parent template / child template) where we need a function to call the final pstpl file

Quick summary:

1. Fix when update or import : seems OK, update the DB number, get it from default (or a cleanest one with less part)
2. Add a 'API version" number to the template configuration : Add a function to get the good file when use file_get_content
3. Test (each time we call the new function) if pstpl file exist, use a default one if not found

1: fixed for update / import
2: Fixed for update / import AND FTP
3: Fixed for update / import AND FTP

But 2 and 3 are really linked with future feature, and take a littlme PHP script time (better with 2, 2rd take a lot more time (test file exist)
Another idea ?

This is only for retro-compatibility with 2.5 right?
I'm not sure it's necessary: if you upload a 2.5 template, the HTML being different, they will be probably broken for many reasons, not only the missing pstpl files.

Yes : but seeing a 'broken css' is different to seeing a white page.

Maybe : when load template configuration : if the template is not valid : return it to default ?

I do something in 2.06 to move to default if template don't exist (when you rename a template via FTP) : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Template.php#L67

Think we can use same system and fix it here ?

Just here in fact : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Template.php#L77

And : we can log it as error for admin user.

"but seeing a 'broken css' is different to seeing a white page."
Yep: that's true.

I'd say that the template configuration model is the right place to do it. Example for the XML file:
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/TemplateConfiguration.php#L98-L114

Yes : add a condition here : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/TemplateConfiguration.php#L85

In fact : replace condition

https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/TemplateConfiguration.php#L95-L96

It would be easy to do:

$this->hasNewPstpl = (string) is_file($this->path.DIRECTORY_SEPARATOR.'form.pstpl');

if (!$this->hasNewPstpl){....}

Yes , but here : you want fix template when loading config

Then maybe : a function

if (!$this->hasPstpl(filename)){
// Add default filename.pstpl
}

Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21329

Done and tested with old 2.50 default template

Must be tested now, and surely refix it (or not).

Won't fix …