View Issue Details

IDProjectCategoryView StatusLast Update
11801Development [All Projects] Theme editorpublic2018-02-16 15:54
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.x 
Target Version3.xFixed in Version3.x 
Summary11801: Move views/survey/system/display.php to layout
Description

I quicly add application/views/survey/system/display.php to diplay some page. But : all this part have a lot of PHP + it's more a layout than a view.

Then => move it to layout/survey.php

Additional Information

layout/survey.php is totally broken : not used.
We use layout/bare.php

Looking at code
https://github.com/LimeSurvey/LimeSurvey/blob/answers_html/application/views/survey/system/display.php
this the best can be (and it's more easy after to move all other view)

Add some var to SurveyController : https://github.com/LimeSurvey/LimeSurvey/blob/answers_html/application/controllers/SurveyController.php#L16

$layout : bar by default actually
$sTemplate
$aData : the data for the view
$aReplacementData : the data for replacement helper
$startsurvey : add (or not ) survey.pstl

Tagsanswers_html

Activities

There are no notes attached to this issue.

Related Changesets

LimeSurvey: answers_html 1ea9bac8

2016-10-15 14:22:40

DenisChenu

Details Diff
Dev: 11801: Move views/survey/system/display.php to layout
Dev: remove usage of common_helper
Dev: remove Basic CMS Integration support (depecated : see https://manual.limesurvey.org/The_template_editor#Basic_CMS_Integration_support)
Affected Issues
11801
mod - application/controllers/SurveyController.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/questionHelper.php Diff File
mod - application/helpers/replacements_helper.php Diff File
mod - application/libraries/Load_answers.php Diff File
mod - application/libraries/Save.php Diff File
mod - application/views/layouts/survey.php Diff File
mod - application/views/survey/system/display.php Diff File
mod - scripts/expressions/em_javascript.js Diff File
mod - templates/basic/config.xml Diff File
mod - templates/test/config.xml Diff File

Issue History

Date Modified Username Field Change
2016-10-15 11:22 DenisChenu New Issue
2016-10-15 11:22 DenisChenu Status new => assigned
2016-10-15 11:22 DenisChenu Assigned To => DenisChenu
2016-10-15 11:25 DenisChenu Tag Attached: answers_html
2016-10-15 14:27 DenisChenu Changeset attached => LimeSurvey answers_html 1ea9bac8
2016-10-15 14:28 DenisChenu Status assigned => resolved
2016-10-15 14:28 DenisChenu Resolution open => fixed
2016-10-15 14:28 DenisChenu Fixed in Version => 3.x
2018-02-16 15:54 c_schmitz Status resolved => closed