View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
11794Bug reportsConditionspublic2016-10-24 13:27
Reportermarcgold Assigned Toollehar  
PrioritynoneSeveritytweak 
Status closedResolutionfixed 
Product Version2.53 
Fixed in Version2.55.x 
Summary11794: Adding multiple conditions / scenarios forgets where it is
Description

Firstly I like to say that I really like the cosmetic changes rolled out in the last release to the conditions.

However these have also given us a small usability issue. To explain, the way we roll surveys is we have a final question always which is a "sorry you do not meet the criteria we need..." Question. The way this works is that it is only shown when it meets certain scenarios. It always has 4+ scenarios and sometimes upto 20 depending on length of survey.

In all previous releases, once you save a condition within the scenario the question you had highlighted remains so which is useful so you know where your at. As did the scenario number you were on.

In latest release these are not being remembered therefore really slowing down the process and increasing the chances of errors.

Steps To Reproduce

Add multiple questions within scenarios, and then multiple scenarios.

Do the same in 2.06 LTS and it is evident whats missing.

TagsNo tags attached.
Attached Files
Selection_101.png (61,356 bytes)   
Selection_101.png (61,356 bytes)   
Selection_103.png (136,151 bytes)
Selection_104.png (117,932 bytes)
Bug heat6
Complete LimeSurvey version number (& build)2.54.2 161012
I will donate to the project if issue is resolvedNo
BrowserChome Mac
Database type & versionMySQL 5.5
Server OS (if known)Centos 6.8
Webserver software & version (if known)Apache 2.2
PHP Version5.6

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2016-10-14 10:03

administrator   ~41327

Could you please attach your survey.

ollehar

ollehar

2016-10-14 12:23

administrator   ~41347

Or a screenshot of how it looks in 2.06lts, I'm not sure what you mean, sorry.

ollehar

ollehar

2016-10-18 16:51

administrator   ~41436

OK, I get it, thanks for the video.

ollehar

ollehar

2016-10-18 16:54

administrator   ~41437

You know you can mark multiple answer options at once, right?

ollehar

ollehar

2016-10-18 16:56

administrator   ~41438

Will mark multiple answer options at once solve your workflow problem?

marcgold

marcgold

2016-10-18 17:02

reporter   ~41441

Yes I know you can mark up multiple answers, I did it like that to highlight the issue as I often have Multiple choice where I am applying an AND condition with Selected or Not Selected. Just didnt have one on this build.

marcgold

marcgold

2016-10-18 17:48

reporter   ~41446

Ok will try
FYI - Running OSX 10.12 Chrome Version 53.0.2785.143 (64-bit)

But I have just run a test survey which I have attached.
Tested In Safari Version 10.0 (12602.1.50.0.10) and In MS Windows 10 Edge (all updates applied) and exactly the same issue occurs. Sorry.

So, in the attached survey. Do the following
At Q: Gender add a Regex ^([2-3][0-9])$ And copy down to all questions except Sorry.
Move to Q:TestQuestion2: Add Scenario (2) and Add Condition TestQuestion1(Option1) = Checked and Add Condition.

Now if I want to Add another condition here on TestQuestion1(Option2) = Checked. The Following has happened.

  1. The Scenario Number has Reset to 1.
  2. None of the Questions are highlighted.

In previous versions. The Scenario Number was persistent and the last question actioned remained highlighted.

ollehar

ollehar

2016-10-19 11:15

administrator   ~41477

I understand your problem, but I'm not sure I agree with the solution (to preserve the old behaviour, memorizing chosen question/scenario). Maybe we can add another popup to add multiple questions in one go?

ollehar

ollehar

2016-10-19 11:16

administrator   ~41478

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=21101

ollehar

ollehar

2016-10-19 11:16

administrator   ~41479

Something similar to the subquestion "Quick add" dialog.

ollehar

ollehar

2016-10-19 12:21

administrator   ~41483

Just to ask, is the loading time of the page a problem?

ollehar

ollehar

2016-10-19 12:25

administrator   ~41484

One solution would be to add a popup which can add multiple conditions without any page reloads.

marcgold

marcgold

2016-10-19 12:31

reporter   ~41485

Page load time is very fast for us so not an issue, but we are running on high end servers. The length of the page is more of an issue (for us).

I Like the idea of a popup to add multiple questions to a scenario. Also I have had a couple of idea's on this too.

  1. Move the list of conditions added to the bottom of the page. So you are right where you need to be on page load with no scroll.

  2. On each Scenario a button to "Add additional conditions to this scenario"

ollehar

ollehar

2016-10-19 12:37

administrator   ~41486

  1. You mean to keep the form on top?

  2. Good idea, will add.

Can you pull updates without waiting for a release? That way you can give feedback, without us having to release a version we will eventually change anyway.

ollehar

ollehar

2016-10-20 14:48

administrator   ~41499

Added two pictures of a new popup. In the popup, you can save a condition without reloading the page, which will work good for your workflow.

Also added button to add condition to a specific scenario.

I will mark this as resolved, but feel free to give more feedback later.

marcgold

marcgold

2016-10-20 15:07

reporter   ~41502

When you say update without waiting for a release, do you mean updating the individual files you have added or by using Github. Only problem is the system we are using is now production - which I prefer as we find the issues quicker (good for you too).

But I would rather not put these files in a production system. Happy however to setup a mirror attached to github that way you only need to tell me which branch. How does that sound

ollehar

ollehar

2016-10-20 15:13

administrator   ~41505

Hi,

I meant github, but we're releasing this fix now anyway, so you can try it out at next release (later today, probably). Of course, if you want to setup a mirror that would be nice, too. Then you can give feedback on stuff before we release them.

Olle

c_schmitz

c_schmitz

2016-10-21 10:41

administrator   ~41514

Version 2.55 released

marcgold

marcgold

2016-10-21 13:32

reporter   ~41520

Hi Olle

Just tried this. Genius!! Does exactly what is needed.

Had one tiny issue, In our sorry question did a Quick Add on a Array Question
The Condition was in one scenario.
SQ1 option 3 or 4 AND
SQ2 option 3 or 4 AND
SQ3 option 3 or 4 AND
SQ4 option 3 or 4

On Save and Close - Green Pop up that said something like Your condition couldn't be added. But it displayed only for a second until the page load, but the question were added to the correct scenario.

Otherwise - BRILLIANT :)

Marc

ollehar

ollehar

2016-10-22 09:13

administrator   ~41525

For the popup, I would guess that you already saved the condition, and then clicked save-and-close, leading the system to try to save the same condition twice. Therefore the error message.

c_schmitz

c_schmitz

2016-10-24 13:27

administrator   ~41533

New version released

Related Changesets

LimeSurvey: master eab5b996

2016-10-19 10:56:11

ollehar

Details Diff
Fixed issue 11794: Show scenario number when edit condition Affected Issues
11794
mod - application/controllers/admin/conditionsaction.php Diff File
mod - application/views/admin/conditions/includes/form_editconditions_header.php Diff File

Issue History

Date Modified Username Field Change
2016-10-13 16:35 marcgold New Issue
2016-10-14 10:03 ollehar Note Added: 41327
2016-10-14 12:07 ollehar Assigned To => ollehar
2016-10-14 12:07 ollehar Status new => assigned
2016-10-14 12:23 ollehar Note Added: 41347
2016-10-14 12:30 ollehar Status assigned => feedback
2016-10-18 16:47 marcgold Status feedback => assigned
2016-10-18 16:51 ollehar Note Added: 41436
2016-10-18 16:52 ollehar Status assigned => confirmed
2016-10-18 16:54 ollehar Note Added: 41437
2016-10-18 16:54 ollehar File Added: Selection_101.png
2016-10-18 16:56 ollehar Status confirmed => feedback
2016-10-18 16:56 ollehar Note Added: 41438
2016-10-18 17:02 marcgold Note Added: 41441
2016-10-18 17:02 marcgold Status feedback => assigned
2016-10-18 17:48 marcgold File Added: limesurvey_survey_743288.lss
2016-10-18 17:48 marcgold Note Added: 41446
2016-10-19 11:15 ollehar Note Added: 41477
2016-10-19 11:16 ollehar Changeset attached => LimeSurvey master eab5b996
2016-10-19 11:16 ollehar Note Added: 41478
2016-10-19 11:16 ollehar Resolution open => fixed
2016-10-19 11:16 ollehar Note Added: 41479
2016-10-19 12:21 ollehar Note Added: 41483
2016-10-19 12:25 ollehar Note Added: 41484
2016-10-19 12:31 marcgold Note Added: 41485
2016-10-19 12:37 ollehar Note Added: 41486
2016-10-20 14:46 ollehar File Added: Selection_103.png
2016-10-20 14:47 ollehar File Added: Selection_104.png
2016-10-20 14:48 ollehar Note Added: 41499
2016-10-20 14:49 ollehar Status assigned => resolved
2016-10-20 14:49 ollehar Fixed in Version => 2.54
2016-10-20 15:07 marcgold Note Added: 41502
2016-10-20 15:13 ollehar Note Added: 41505
2016-10-21 10:41 c_schmitz Note Added: 41514
2016-10-21 10:41 c_schmitz Status resolved => closed
2016-10-21 13:32 marcgold File Added: array_question_1611.lsq
2016-10-21 13:32 marcgold Note Added: 41520
2016-10-21 13:33 marcgold Status closed => feedback
2016-10-21 13:33 marcgold Resolution fixed => reopened
2016-10-22 09:13 ollehar Note Added: 41525
2016-10-22 09:15 ollehar Status feedback => resolved
2016-10-22 09:15 ollehar Resolution reopened => fixed
2016-10-22 09:15 ollehar Fixed in Version 2.54 => 2.55.x
2016-10-24 13:27 c_schmitz Note Added: 41533
2016-10-24 13:27 c_schmitz Status resolved => closed