View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
11781Bug reportsSurvey editingpublic2016-10-11 19:412017-07-21 17:07
Reportertammo Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.53 
Fixed in Version3.0.x 
Summary11781: 2.54 default template save.pstpl
Description

template file has <br /> and align="center" in it. Should that not be addressed in .css via classes?

Proposal:

<div class="clearall-result">
<div class="warning-text">{ANSWERSCLEARED}</div>
<div class="restart">{RESTART}</div>
</div>

Steps To Reproduce

Current version in default

<br />
<table class="clearall-result">
<tr>
<td align="center">
<span class="warning-text">{ANSWERSCLEARED}</span>
<br /><br />
{RESTART}
</td>
</tr>
</table>
<br />

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)2.54 GIT
I will donate to the project if issue is resolvedNo
Browser
Database type & versionnn
Server OS (if known)nn
Webserver software & version (if known)nn
PHP Versionnn

Users monitoring this issue

There are no users monitoring this issue.

Activities

tammo

tammo

2016-10-11 19:42

developer   ~41238

Sorry, not save.pstpl, but clearall.pstpl
DenisChenu

DenisChenu

2016-10-12 12:15

developer   ~41257

Maybe some 'btn' for restart : else : YES : remove thi td :) . Maybe some clearfix too.
tammo

tammo

2016-10-12 12:19

developer   ~41258

Be my guest, as long as it is as independent of css framework as possible (but I realise this is not always possible)
DenisChenu

DenisChenu

2016-10-12 12:45

developer   ~41265

template is not independant of css framework.

Actual core HTML can not really be css independant framework : we can only prepare the ground but not be really independant :).
DenisChenu

DenisChenu

2016-10-13 09:46

developer   ~41280

@tammo : save + load screen redone in views : you can update default template.

I do it for base_awesome : maybe copy/paste
DenisChenu

DenisChenu

2016-10-14 11:05

developer   ~41342

Fix committed to answers_html branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=21012
c_schmitz

c_schmitz

2017-07-21 17:07

administrator   ~44131

Version 3.0.0-beta.1 released

Related Changesets

LimeSurvey: answers_html 97703ea4

2016-10-13 09:40:02

DenisChenu

Details Diff 		Dev: #11771: Review HTML produced for save/reload : do views
Dev: Add a display.php view for all of this message (this fix a js out of body in save/load)
Dev: Move some core replacement to "where used" replacement		 Affected Issues
11771, 11781, 11790
mod - application/controllers/SurveyController.php Diff File
mod - application/controllers/survey/index.php Diff File
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/frontend_helper.php Diff File
mod - application/helpers/replacements_helper.php Diff File
mod - application/libraries/Load_answers.php Diff File
mod - application/libraries/Save.php Diff File
mod - application/views/layouts/survey.php Diff File
add - application/views/survey/system/display.php Diff File
add - application/views/survey/system/loadForm/error.php Diff File
add - application/views/survey/system/loadForm/form.php Diff File
add - application/views/survey/system/loadForm/heading.php Diff File
add - application/views/survey/system/loadForm/message.php Diff File
add - application/views/survey/system/saveForm/anonymized.php Diff File
add - application/views/survey/system/saveForm/error.php Diff File
add - application/views/survey/system/saveForm/form.php Diff File
add - application/views/survey/system/saveForm/heading.php Diff File
add - application/views/survey/system/saveForm/message.php Diff File
mod - templates/base/pstpl/load.pstpl Diff File
mod - templates/base/pstpl/save.pstpl Diff File
mod - templates/base_awesome/pstpl/load.pstpl Diff File
mod - templates/base_awesome/pstpl/save.pstpl Diff File

LimeSurvey: answers_html 4fb88ed6

2016-10-14 10:33:50

DenisChenu

Details Diff 		Fixed issue 11781 : default template save.pstpl load.pstpl completed.pstpl
Dev: Fixed some row issue (col-sm-X > ls-input-group seems to be the good way)
Dev: preparing basic (base_awesome)		 Affected Issues
11781
mod - application/core/packages/limesurvey/survey.css Diff File
mod - application/core/packages/limesurvey/survey.js Diff File
mod - application/views/survey/questions/arrays/dualscale/answer_dropdown.php Diff File
mod - application/views/survey/questions/date/dropdown/answer.php Diff File
mod - application/views/survey/questions/multiplechoice_with_comments/rows/answer_row_other.php Diff File
mod - application/views/survey/questions/multiplenumeric/rows/sliders/answer_row.php Diff File
add - application/views/survey/system/actionButton/clearAll.php Diff File
add - application/views/survey/system/actionLink/clearAll.php Diff File
mod - application/views/survey/system/saveForm/anonymized.php Diff File
mod - templates/base_awesome/css/template-core.css Diff File
mod - templates/base_awesome/css/template.css Diff File
mod - templates/base_awesome/pstpl/completed.pstpl Diff File
mod - templates/base_awesome/pstpl/endpage.pstpl Diff File
mod - templates/base_awesome/pstpl/navigator.pstpl Diff File
mod - templates/base_awesome/pstpl/question.pstpl Diff File
mod - templates/base_awesome/pstpl/save.pstpl Diff File
mod - templates/default/views/completed.pstpl Diff File
mod - templates/default/views/load.pstpl Diff File
mod - templates/default/views/register.pstpl Diff File
mod - templates/default/views/save.pstpl Diff File

Issue History

Date Modified Username Field Change
2016-10-11 19:41 tammo New Issue
2016-10-11 19:42 tammo Note Added: 41238
2016-10-12 12:05 ollehar Assigned To => DenisChenu
2016-10-12 12:05 ollehar Status new => assigned
2016-10-12 12:15 DenisChenu Note Added: 41257
2016-10-12 12:19 tammo Note Added: 41258
2016-10-12 12:45 DenisChenu Note Added: 41265
2016-10-13 09:46 DenisChenu Note Added: 41280
2016-10-13 10:05 DenisChenu Changeset attached => LimeSurvey answers_html 97703ea4
2016-10-13 17:59 DenisChenu Assigned To DenisChenu =>
2016-10-14 10:36 DenisChenu Assigned To => DenisChenu
2016-10-14 10:36 DenisChenu Status assigned => resolved
2016-10-14 10:36 DenisChenu Resolution open => fixed
2016-10-14 10:36 DenisChenu Fixed in Version => 3.0.x
2016-10-14 11:05 DenisChenu Changeset attached => LimeSurvey answers_html 4fb88ed6
2016-10-14 11:05 DenisChenu Note Added: 41342
2017-07-21 17:07 c_schmitz Note Added: 44131
2017-07-21 17:07 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing