View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
11218Bug reportsStatisticspublic2016-05-19 18:312016-06-03 14:46
Reporterjmlorenzo Assigned ToLouisGac 
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary11218: Statistics general filters does not remember base language of the survey
Description

Statistics general filters does not remember base language of the survey
I think that statistics should recover the base language of the survey and have it selected as the default value in statistics generation.
I have 12 languages and it always selected German (not by default) when the base language is English.

Steps To Reproduce

Select a survey with more than one language.
Go to Responses & statistics
Go to statistics
The base language is English but it is not selected as default (other one appears because there is no one selected by default).
This behaviour forces to change the language for statistics presentation everytime.

Additional Information

returnGlobal('statlang'); returns blank string in
limesurvey\application\controllers\admin\statistics.php
so in
limesurvey\application\views\admin\export\statistics_subviews_dataselection.php
it is imposible to match the available languages with the base one.

In statistics.php
I changed line 501:
$aData['sStatisticsLanguage']=$statlang;
to:
$aData['sStatisticsLanguage']=$language;
And it worked!!

TagsNo tags attached.
Attached Files
limesurvey_survey_265291.lss (1,583,570 bytes)
Limesurvey_bug_11218_20160525_1031.png (102,568 bytes)
Limesurvey_bug_11218_20160530_1557.png (99,911 bytes)   
Limesurvey_bug_11218_20160530_1557.png (99,911 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)build 2.50 160517
I will donate to the project if issue is resolvedNo
BrowserGoogle Chrome
Database type & versionMYSQL 5.7
Server OS (if known)Windows 10 Professional
Webserver software & version (if known)Apache 2.4.18
PHP Version5.5

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2016-05-24 17:48

developer   ~38808

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19153 [^]
LouisGac

LouisGac

2016-05-24 17:49

developer   ~38809

Thank you, your changes in statisctics.php helped me to find where to start to fix this one ;-)
c_schmitz

c_schmitz

2016-05-25 09:04

administrator   ~38825

Version 2.50+ Build 160525 & Version 2.06LTS Build 160524 released
jmlorenzo

jmlorenzo

2016-05-25 10:35

reporter   ~38838

Not solved. I have installed the new version and does not work.
LouisGac

LouisGac

2016-05-25 10:54

developer   ~38841

What doesn't work ?

What has been changed :
when generating statistics, the GUI language is no more changed, and the questions are shown in the selected languages.

Can you confirm this behavior?

LouisGac

LouisGac

2016-05-26 10:07

developer   ~38919

Sorry, statistics helper is full of code duplication...
should be totally fixed now
LouisGac

LouisGac

2016-05-26 10:08

developer   ~38920

Last edited: 2016-05-26 10:08

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19186
c_schmitz

c_schmitz

2016-05-30 14:18

administrator   ~39017

Version 2.50+ Build 160529 released
jmlorenzo

jmlorenzo

2016-05-30 15:56

reporter   ~39024

Again not solved.
LouisGac

LouisGac

2016-05-30 16:31

developer   ~39025

Just to be sure, when you say :
"I think that statistics should recover the base language of the survey and have it selected as the default value in statistics generation. "

You're speaking about the select box to select the language?
pmonstad

pmonstad

2016-05-30 17:15

updater   ~39027

Hm I guess this is a duplicate of #11254
LouisGac

LouisGac

2016-05-30 17:26

developer   ~39029

yep, and I fix another bug...
sorry, I'll fix this one as soon as I'm finished with the token table
LouisGac

LouisGac

2016-06-03 12:15

developer   ~39144

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19315
c_schmitz

c_schmitz

2016-06-03 14:46

administrator   ~39177

Version 2.50 Build 160603 released

Related Changesets

LimeSurvey: master b2717d59

2016-06-03 10:15:35

LouisGac

Details Diff 		Fixed issue #11254: wrong default language in statistics expert mode
Fixed issue 11218: Statistics general filters does not remember base language of the survey		 Affected Issues
11218, 11254
mod - application/views/admin/export/statistics_subviews/_dataselection.php Diff File
mod - application/views/admin/export/statistics_view.php Diff File
mod - scripts/admin/surveysettings.js Diff File
mod - styles/Sea_Green/css/lime-admin-common.css Diff File

Issue History

Date Modified Username Field Change
2016-05-19 18:31 jmlorenzo New Issue
2016-05-19 18:31 jmlorenzo File Added: limesurvey_survey_265291.lss
2016-05-24 16:44 LouisGac Sticky Issue No => Yes
2016-05-24 17:48 LouisGac Note Added: 38808
2016-05-24 17:49 LouisGac Note Added: 38809
2016-05-24 17:49 LouisGac Status new => resolved
2016-05-24 17:49 LouisGac Resolution open => fixed
2016-05-24 17:49 LouisGac Assigned To => LouisGac
2016-05-24 17:49 LouisGac Sticky Issue Yes => No
2016-05-25 09:04 c_schmitz Note Added: 38825
2016-05-25 09:04 c_schmitz Status resolved => closed
2016-05-25 10:35 jmlorenzo Note Added: 38838
2016-05-25 10:35 jmlorenzo Status closed => feedback
2016-05-25 10:35 jmlorenzo Resolution fixed => reopened
2016-05-25 10:36 jmlorenzo File Added: Limesurvey_bug_11218_20160525_1031.png
2016-05-25 10:54 LouisGac Note Added: 38841
2016-05-25 10:54 LouisGac Status feedback => acknowledged
2016-05-26 10:07 LouisGac Note Added: 38919
2016-05-26 10:08 LouisGac Note Added: 38920
2016-05-26 10:08 LouisGac Note Edited: 38920
2016-05-26 10:08 LouisGac Status acknowledged => resolved
2016-05-26 10:08 LouisGac Resolution reopened => fixed
2016-05-26 10:08 c_schmitz Fixed in Version => 2.5
2016-05-30 14:18 c_schmitz Note Added: 39017
2016-05-30 14:18 c_schmitz Status resolved => closed
2016-05-30 15:56 jmlorenzo Note Added: 39024
2016-05-30 15:56 jmlorenzo Status closed => feedback
2016-05-30 15:56 jmlorenzo Resolution fixed => reopened
2016-05-30 15:57 jmlorenzo File Added: Limesurvey_bug_11218_20160530_1557.png
2016-05-30 16:31 LouisGac Note Added: 39025
2016-05-30 17:15 pmonstad Note Added: 39027
2016-05-30 17:26 LouisGac Note Added: 39029
2016-06-03 11:36 LouisGac Sticky Issue No => Yes
2016-06-03 12:15 LouisGac Changeset attached => LimeSurvey master b2717d59
2016-06-03 12:15 LouisGac Note Added: 39144
2016-06-03 12:16 LouisGac Status feedback => resolved
2016-06-03 12:16 LouisGac Resolution reopened => fixed
2016-06-03 13:15 c_schmitz Sticky Issue Yes => No
2016-06-03 14:46 c_schmitz Note Added: 39177
2016-06-03 14:46 c_schmitz Status resolved => closed