it is lime 2.5 160202!

https://github.com/LimeSurvey/LimeSurvey/pull/427

@Louis : except for "commit" message : fix seems OK. (i can take the pull and ask to BertHankes to fix commit mesages)

@asshank : you use some static system for template file ? For survey speed ?

Just want to know if

• Easy way to update usertemplaterootdir: you have to hack config-defaulmt or it can be done in config.php
• Why you do it.

Denis

@DenisChenu

A lot is going on with 2.50+ :-)
I have installed 160212 and no change on models/Template.php so far on this issue.

Can you give me an update? Is it going to happen? Is my PR not in order?

Hi asshank : Louis is the 250 manager and take this bug :)

@Louis : take a look at this... It seems a bit strange: an upload/ dir outside of lime framework.
But a 'hardcoded bit' remaines in template.php and should be changed into 'softcoded'.

Carsten is the manager, I'm just the main coder ^^

asshank, would be nice if you provide me a step by step guide to reproduce the bug. Like :

1. Install limesurvey here
2. Create a virtualhost, or an alias pointing here
3. Move this directory here
   etc.

Hard to do. Another way of pointing to the problem:

There is a $config['usertemplaterooturl'] setting

This is not used in
application/model/Template.php
function getTemplateListWithPreviews()
line 330 is using Yii::app()->request->baseUrl

By making use of the $config['usertemplaterooturl'] setting the code is more softcoded and will work for upload/ dirs outside of limeroot

see https://github.com/LimeSurvey/LimeSurvey/pull/427

And I pointed the situation out to DenisChenu https://bugs.limesurvey.org/view.php?id=10299#c34591

@DenisChenu
Can you look into this issue again.
It is IMHO still not right that
$config['standardtemplaterooturl']
and
$config['usertemplaterooturl']
are not used.
The $config has to have a purpose :-)

See my coment on pull request : commit is great . But not the commit message

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19252

Thank you!

Version 2.50 Build 150602 released