View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 254
IDProjectCategoryView StatusDate SubmittedLast Update
10062Bug reportsSecuritypublic2015-11-27 23:452015-12-15 15:05
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Fixed in Version2.06+ 
Summary10062: SuperAdmin can't add users to not-owned UserGroups
Description

SuperAdmin can't add users to created by someone else.

Additional Information

The error is in /application/controllers/admin/usergroups.php
Possible solution, not tested yet:

After >>
$query2 = "SELECT ugid FROM {{user_groups}} WHERE ugid = " . $ugid;

Add >>
if (!Permission::model()->hasGlobalPermission('superadmin','read')) $query2 .= " AND owner_id = " . Yii::app()->session['loginID'];

TagsNo tags attached.
Bug heat254
Complete LimeSurvey version number (& build)14052014
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5
Server OS (if known)Ubuntu
Webserver software & version (if known)Apache
PHP VersionPHP Version 5.4.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2015-11-27 23:57

manager   ~33631

PR >>
https://github.com/LimeSurvey/LimeSurvey/pull/390

Commit >>
https://github.com/LimeSurvey/LimeSurvey/commit/f5bee51cbfdad3f31f5ef9d06459619667f17f0c
c_schmitz

c_schmitz

2015-12-09 10:40

administrator   ~33783

See PR
c_schmitz

c_schmitz

2015-12-09 13:17

administrator   ~33807

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16435

Related Changesets

LimeSurvey: master f5bee51c

2015-11-27 22:56:43

gabrieljenik

Details Diff 		Fixed Issue 10062: SuperAdmin can't add users to not-owned UserGroups Affected Issues
10062
mod - application/controllers/admin/usergroups.php Diff File

LimeSurvey: master 1d4307b8

2015-12-09 11:55:48

gabrieljenik

Details Diff 		Fixed Issue 10062: SuperAdmin can't add users to not-owned UserGroups

If statement uses its own {} block		 Affected Issues
10062
mod - application/controllers/admin/usergroups.php Diff File

LimeSurvey: master 897c77f4

2015-12-09 12:01:47

c_schmitz

Details Diff 		Merge pull request #390 from gabrieljenik/patch-23

Fixed Issue 10062: SuperAdmin can't add users to not-owned UserGroups		 Affected Issues
10062
mod - application/controllers/admin/usergroups.php Diff File

Issue History

Date Modified Username Field Change
2015-11-27 23:45 gabrieljenik New Issue
2015-11-27 23:45 gabrieljenik Assigned To => gabrieljenik
2015-11-27 23:45 gabrieljenik Status new => assigned
2015-11-27 23:57 gabrieljenik Note Added: 33631
2015-11-27 23:57 gabrieljenik Assigned To gabrieljenik => c_schmitz
2015-12-09 10:40 c_schmitz Note Added: 33783
2015-12-09 10:40 c_schmitz Status assigned => feedback
2015-12-09 13:02 c_schmitz Assigned To c_schmitz => gabrieljenik
2015-12-09 13:02 c_schmitz Status feedback => assigned
2015-12-09 13:02 c_schmitz Status assigned => resolved
2015-12-09 13:02 c_schmitz Fixed in Version => 2.06+
2015-12-09 13:02 c_schmitz Resolution open => fixed
2015-12-09 13:17 gabrieljenik Changeset attached => LimeSurvey master f5bee51c
2015-12-09 13:17 gabrieljenik Changeset attached => LimeSurvey master 1d4307b8
2015-12-09 13:17 c_schmitz Changeset attached => LimeSurvey master 897c77f4
2015-12-09 13:17 c_schmitz Note Added: 33807
2015-12-15 15:05 c_schmitz Status resolved => closed