View Revisions: Issue #13881

Summary 13881: EM : Not number question replace . by , (javascript)
Revision 2018-07-18 10:24 by DenisChenu
Additional Information

The biggest issue i think : the value shown is different in js and php. This must be same value shown in php and js.

The best solution can be :

  • NEVER update Text.NAOK and Text.shown
  • don't update Numeric.shown
  • update Numeric.shown according to numberformat

2.6lts + 2.73 have same issue

To know if value is a number : we have it in

  1. LEMvarNameAttr (onlynum) (js)
  2. ExpressionManager->RDP_TokenType : https://github.com/LimeSurvey/LimeSurvey/blob/bf35ce1bb2d5ac3b6a1bb0513f6033c4f7987de5/application/helpers/expressions/em_core_helper.php#L138 used here https://github.com/LimeSurvey/LimeSurvey/blob/bf35ce1bb2d5ac3b6a1bb0513f6033c4f7987de5/application/helpers/expressions/em_core_helper.php#L285 for example.
Revision 2018-07-18 10:11 by DenisChenu
Additional Information

The biggest issue i think : the value shown is different in js and php. This must be same value shown in php and js.

The best solution can be :

  • NEVER update Text.NAOK and Text.shown
  • don't update Numeric.shown
  • update Numeric.shown according to numberformat

2.7 + 2.73 have same issue

To know if value is a number : we have it in

  1. LEMvarNameAttr (onlynum) (js)
  2. ExpressionManager->RDP_TokenType : https://github.com/LimeSurvey/LimeSurvey/blob/bf35ce1bb2d5ac3b6a1bb0513f6033c4f7987de5/application/helpers/expressions/em_core_helper.php#L138 used here https://github.com/LimeSurvey/LimeSurvey/blob/bf35ce1bb2d5ac3b6a1bb0513f6033c4f7987de5/application/helpers/expressions/em_core_helper.php#L285 for example.