Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
17700Bug reportsTheme editorpublic2022-06-23 11:11
Reporterbaltzis Assigned Togabrieljenik  
PriorityhighSeverityfeature 
Status ready for testingResolutionfixed 
Product Version5.x 
Summary17700: Custom logo disappears in extended_ themes
Description

When trying to customize themes (e.g. Bootswatch), I get the following error message:
Error: Malformed JSON - field files_js must be either a JSON array or the string "inherit". Found "null".

For the bootswatch extended theme, the message appears six times, i.e., it appears for each and every customizable field. This must be some bug. Anyway, this makes difficult to customize the theme. Besides, I found that the "aSurveyInfo.options.brandlogofile" specification in the nav_bar.twig does not point to the correct location of the custom logo. I had to enter the relative URL, to make the custom logo reappear, so I had to following:
{{ image('./files/logo.png', aSurveyInfo.name, {"class": "logo img-responsive"}) }}

Instead of:
{{ image(aSurveyInfo.options.brandlogofile, aSurveyInfo.name, {"class": "logo img-responsive"}) }} (which should be the standard)

Steps To Reproduce

Steps to reproduce

  1. Go to the Theme Editor
  2. Extend the LimeSurvey Bootwatch Theme
  3. Open the editor to the extended theme and look for the logo in any view (mobile, etc.)
  4. Designate the extended theme to any survey, and try to customize the Theme Options on the Setting page.

Expected result

The logo (standard or custom) should appear in the header of the survey pages and in the theme preview in the editor. Depending on the CSS a responsive logo should appear on any view, on the header of the survey pages as well as in the theme preview.

Actual result

The logo disappears. If a responsive logo is designated in the custom.css file, it appears on any view, only in the theme preview, but not on the survey pages viewed by participants (e.g. on a mobile).

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)Version 5.1.18, build 211101
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionDatabase driver mysql, Database driver version mysqlnd 5.0.12-dev - 20150407 - $Id: 38fea24f2847fa7519001be390c98ae0acafe387 $
Server OS (if known)Operating system Windows NT WIN-A34LDHDT6H4 6.3 build 9600 (Windows Server 2012 R2 Standard Edition) AMD64
Webserver software & version (if known)Web server software Microsoft-IIS/8.5
PHP VersionPHP version 7.2.7

Relationships

related to 18205 ready for mergegabrieljenik Unable to update anything in extended bootswatch opttion 

Activities

baltzis

baltzis

2021-11-08 09:51

reporter   ~67167

In the expected results there should be no error message. Also, the same problems appear when editing ("extending") any variation of the theme (bootswatch).

annaf

annaf

2021-12-07 15:00

reporter   ~67731

Today, 7/12/2021, after version updating (the current version is 5.2.5+211207) in the all themes a logo disappears in the header of the survey pages and in the theme preview in the editor. When I try to select
a logo file in the editor of the theme or in the survey, after saving a value of file is empty.

brandlogo_disappears.png (93,589 bytes)   
brandlogo_disappears.png (93,589 bytes)   
gabrieljenik

gabrieljenik

2022-06-01 01:27

manager   ~70147

Hello baltzis,
This ticket has been open for quite some time.
Do you have any new info / feedback?
Can you please check if this issue still exists in the latest version of LimeSurvey and let us know?
Thank you!

annaf

annaf

2022-06-01 08:40

reporter   ~70156

Hello,
I checked this issue in the latest version (Version 5.3.18+220530), the problem is still there.
I would appreciate your review.
Thank you.
Anna

c_schmitz

c_schmitz

2022-06-01 10:09

administrator   ~70161

I can can confirm this on windows.
New setting does not stick and also thew preview button does not work. See attached file.

gabrieljenik

gabrieljenik

2022-06-06 16:43

manager   ~70251

Last edited: 2022-06-06 16:44

As to summarize:

@baltzis you are reporting 2 problems.

1) Error message when extending

When trying to customize themes (e.g. Bootswatch), I get the following error message:
Error: Malformed JSON - field files_js must be either a JSON array or the string "inherit". Found "null".

Is this what you recently reproduced?
We couldn't reproduce it on a brand new installation.
Does this happen only to Bootswatch?

2) Brandlogo broken link requires fix in Nav_bar.twig

had to enter the relative URL, to make the custom logo reappear

Is this what you recently reproduced?
This is working fine for current installations.

@carsten You found that

3) The global options on survey theme are not sticking.

This we could reproduce.

gabrieljenik

gabrieljenik

2022-06-06 16:52

manager   ~70252

@baltzis Can I please ask you to reset the Bootswatch theme? (on a test env please)

baltzis

baltzis

2022-06-06 18:57

reporter   ~70254

@gabrieljenik. OK. How can I reset a theme?

baltzis

baltzis

2022-06-06 19:07

reporter   ~70255

@gabrieljenik. Ok, I figured it out and I did a theme reset. The problems remain. I am reluctant to reset the bootswatch_extend because it does not keep the custom setting in theme options, and I have this theme assigned to some surveys. When I am trying to preview an image in theme options, the frontend of the installation appears instead. No way to preview any image under the field "logo file".

baltzis

baltzis

2022-06-06 19:14

reporter   ~70256

@gabrieljenik. Please note that this behavior is observed with a Windows server installation. The Linux installation seems to work fine.

gabrieljenik

gabrieljenik

2022-06-07 13:54

manager   ~70275

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2459

Fixing:

  • Settings at global level are not sticking (not saving).
  • Need to enter multiple times to theme options or to a survey (participant mode) to have settings being picked up correctly.
gabrieljenik

gabrieljenik

2022-06-07 13:56

manager   ~70276

Last edited: 2022-06-07 13:56

Still couldn't reproduce issue #1 and #2 on Windows XAMPP.
@c_schmitz could you?

gabrieljenik

gabrieljenik

2022-06-23 11:11

manager   ~70501

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33590

Related Changesets

LimeSurvey: master 888b46f3

2022-06-23 11:11:00

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 17700: Custom logo disappears in extended themes (#2459) Affected Issues
17700
mod - application/models/TemplateConfiguration.php Diff File
mod - assets/packages/themeoptions-core/themeoptions-core.js Diff File

Issue History

Date Modified Username Field Change
2021-11-08 09:47 baltzis New Issue
2021-11-08 09:51 baltzis Note Added: 67167
2021-11-08 09:51 baltzis Bug heat 0 => 2
2021-12-07 15:00 annaf Note Added: 67731
2021-12-07 15:00 annaf File Added: brandlogo_disappears.png
2021-12-07 15:00 annaf Bug heat 2 => 4
2022-06-01 01:27 gabrieljenik Assigned To => gabrieljenik
2022-06-01 01:27 gabrieljenik Status new => feedback
2022-06-01 01:27 gabrieljenik Note Added: 70147
2022-06-01 01:27 gabrieljenik Bug heat 4 => 6
2022-06-01 08:40 annaf Note Added: 70156
2022-06-01 10:09 c_schmitz Note Added: 70161
2022-06-01 10:09 c_schmitz File Added: logo_and_preview_theme_bug.gif
2022-06-01 10:09 c_schmitz Bug heat 6 => 8
2022-06-01 10:10 c_schmitz Status feedback => confirmed
2022-06-01 10:10 c_schmitz Priority none => high
2022-06-06 16:43 gabrieljenik Note Added: 70251
2022-06-06 16:44 gabrieljenik Note Edited: 70251
2022-06-06 16:52 gabrieljenik Note Added: 70252
2022-06-06 18:57 baltzis Note Added: 70254
2022-06-06 19:07 baltzis Note Added: 70255
2022-06-06 19:14 baltzis Note Added: 70256
2022-06-07 13:54 gabrieljenik Status confirmed => assigned
2022-06-07 13:54 gabrieljenik Note Added: 70275
2022-06-07 13:56 gabrieljenik Note Added: 70276
2022-06-07 13:56 gabrieljenik Note Edited: 70276
2022-06-21 17:06 DenisChenu Relationship added related to 18205
2022-06-21 20:32 gabrieljenik Assigned To gabrieljenik =>
2022-06-21 20:32 gabrieljenik Status assigned => ready for testing
2022-06-23 11:11 gabrieljenik Changeset attached => LimeSurvey master 888b46f3
2022-06-23 11:11 gabrieljenik Note Added: 70501
2022-06-23 11:11 gabrieljenik Assigned To => gabrieljenik
2022-06-23 11:11 gabrieljenik Resolution open => fixed