17368: Failed Login Attempt locks out all users when behind nginx proxy - doesn't use sIPAddress

This bug affects 1 person(s).

258

ID	Project	Category	View Status	Date Submitted	Last Update
17368	Bug reports	Security	public	2021-06-15 09:43	2021-07-12 11:53

Reporter	aba-rechsteiner	Assigned To	ollehar
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	4.5.x

Summary	17368: Failed Login Attempt locks out all users when behind nginx proxy - doesn't use sIPAddress
Description	Brings back an old problem https://github.com/LimeSurvey/LimeSurvey/commit/55612ff40cac2a2b5da5cb0be67d829b34b750fa https://bugs.limesurvey.org/view.php?id=8813
Tags	No tags attached.

Bug heat	258
Complete LimeSurvey version number (& build)	4.6.1
I will donate to the project if issue is resolved	No
Browser
Database type & version	Postgresql 11.12
Server OS (if known)	Debian GNU/Linux 10 (buster)
Webserver software & version (if known)
PHP Version	7.4.19

DenisChenu 2021-06-15 09:45 developer ~64912 Last edited: 2021-06-15 09:47	Same for 3.X https://github.com/LimeSurvey/LimeSurvey/commit/ecddb3cb255a8b2774d301271631ae60a7e4d827 https://bugs.limesurvey.org/view.php?id=17369

ollehar 2021-06-15 12:11 administrator ~64915	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32084

DenisChenu 2021-06-15 12:17 developer ~64917	Maybe check with Carsten the reason of the fix ? If needed in some condition : need a config ? No ?

ollehar 2021-06-15 13:16 administrator ~64918	Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32085

c_schmitz 2021-07-12 11:53 administrator ~65277	Release done.

LimeSurvey: master 32ef0480 2021-06-15 12:10:59 ollehar Details Diff	Fixed issue 17368: Failed Login Attempt locks out all users when behind nginx proxy Discussion: https://github.com/LimeSurvey/LimeSurvey/commit/55612ff40cac2a2b5da5cb0be67d829b34b750fa	Affected Issues 17368
	mod - application/models/FailedLoginAttempt.php	Diff File
LimeSurvey: 3.x-LTS 7fd684f0 2021-06-15 12:10:59 ollehar Details Diff	Fixed issue 17368: Failed Login Attempt locks out all users when behind nginx proxy Discussion: https://github.com/LimeSurvey/LimeSurvey/commit/55612ff40cac2a2b5da5cb0be67d829b34b750fa	Affected Issues 17368
	mod - application/models/FailedLoginAttempt.php	Diff File

Date Modified	Username	Field	Change
2021-06-15 09:43	aba-rechsteiner	New Issue
2021-06-15 09:43	DenisChenu	Issue Monitored: DenisChenu
2021-06-15 09:45	DenisChenu	Note Added: 64912
2021-06-15 09:46	DenisChenu	Issue cloned: 17369
2021-06-15 09:47	DenisChenu	Relationship added	related to 17369
2021-06-15 09:47	DenisChenu	Note Edited: 64912
2021-06-15 12:11	ollehar	Changeset attached	=> LimeSurvey master 32ef0480
2021-06-15 12:11	ollehar	Note Added: 64915
2021-06-15 12:11	ollehar	Assigned To	=> ollehar
2021-06-15 12:11	ollehar	Resolution	open => fixed
2021-06-15 12:12	ollehar	Status	new => ready for code review
2021-06-15 12:17	DenisChenu	Note Added: 64917
2021-06-15 13:16	ollehar	Changeset attached	=> LimeSurvey 3.x-LTS 7fd684f0
2021-06-15 13:16	ollehar	Note Added: 64918
2021-06-21 13:50	ollehar	Status	ready for code review => resolved
2021-07-12 11:53	c_schmitz	Note Added: 65277
2021-07-12 11:53	c_schmitz	Status	resolved => closed
2021-08-02 21:34	guest	Bug heat	256 => 258