Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17363Bug reportsSurvey takingpublic2021-07-22 19:21
Reporterf_funke Assigned ToDenisChenu  
PriorityhighSeveritypartial_block 
Status reviewResolutionfixed 
Product Version5.x 
Summary17363: Survey data policy error message not displayed
DescriptionThe feature of displaying a data policy on the welcome page is broken:
If a user leaves the checkbox unchecked, nothing happens - no error message is displayed at all. Also if JavaScript is disabled a generic error message pops up, not the message defined in LimeSurvey.

Perhaps the issue is related to the use of the "no-drop" or "not-allowed" cursor that appears on hovering the next button.

Anyway, it would be great if the custom error message would be displayed :-)
Steps To Reproduce1) Open survey (see attached LSS).
2) Don't accept the privacy statement.
3) Click on "next".
4) See: nothing happening.
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)LimeSurvey 5.0.2
I will donate to the project if issue is resolvedNo
Browser
Database & DB-VersionN/A
Server OS (if known)
Webserver software & version (if known)
PHP VersionN/A

Relationships

related to 17405 confirmed Survey data policiy : no server control 
related to 17367 reviewollehar Survey policy error not show in vanilla 

Activities

f_funke

f_funke

2021-06-10 13:40

developer  

limesurvey_survey_658785.lss (15,333 bytes)   
<?xml version="1.0" encoding="UTF-8"?>
<document>
 <LimeSurveyDocType>Survey</LimeSurveyDocType>
 <DBVersion>449</DBVersion>
 <languages>
  <language>en</language>
 </languages>
 <groups>
  <fields>
   <fieldname>gid</fieldname>
   <fieldname>sid</fieldname>
   <fieldname>group_order</fieldname>
   <fieldname>randomization_group</fieldname>
   <fieldname>grelevance</fieldname>
  </fields>
  <rows>
   <row>
    <gid><![CDATA[35]]></gid>
    <sid><![CDATA[658785]]></sid>
    <group_order><![CDATA[1]]></group_order>
    <randomization_group/>
    <grelevance><![CDATA[1]]></grelevance>
   </row>
  </rows>
 </groups>
 <group_l10ns>
  <fields>
   <fieldname>id</fieldname>
   <fieldname>gid</fieldname>
   <fieldname>group_name</fieldname>
   <fieldname>description</fieldname>
   <fieldname>language</fieldname>
   <fieldname>sid</fieldname>
   <fieldname>group_order</fieldname>
   <fieldname>randomization_group</fieldname>
   <fieldname>grelevance</fieldname>
  </fields>
  <rows>
   <row>
    <id><![CDATA[35]]></id>
    <gid><![CDATA[35]]></gid>
    <group_name><![CDATA[My first question group]]></group_name>
    <language><![CDATA[en]]></language>
    <sid><![CDATA[658785]]></sid>
    <group_order><![CDATA[1]]></group_order>
    <randomization_group/>
    <grelevance><![CDATA[1]]></grelevance>
   </row>
  </rows>
 </group_l10ns>
 <questions>
  <fields>
   <fieldname>qid</fieldname>
   <fieldname>parent_qid</fieldname>
   <fieldname>sid</fieldname>
   <fieldname>gid</fieldname>
   <fieldname>type</fieldname>
   <fieldname>title</fieldname>
   <fieldname>preg</fieldname>
   <fieldname>other</fieldname>
   <fieldname>mandatory</fieldname>
   <fieldname>encrypted</fieldname>
   <fieldname>question_order</fieldname>
   <fieldname>scale_id</fieldname>
   <fieldname>same_default</fieldname>
   <fieldname>relevance</fieldname>
   <fieldname>modulename</fieldname>
  </fields>
  <rows>
   <row>
    <qid><![CDATA[214]]></qid>
    <parent_qid><![CDATA[0]]></parent_qid>
    <sid><![CDATA[658785]]></sid>
    <gid><![CDATA[35]]></gid>
    <type><![CDATA[T]]></type>
    <title><![CDATA[Q00]]></title>
    <other><![CDATA[N]]></other>
    <mandatory><![CDATA[N]]></mandatory>
    <encrypted><![CDATA[N]]></encrypted>
    <question_order><![CDATA[1]]></question_order>
    <scale_id><![CDATA[0]]></scale_id>
    <same_default><![CDATA[0]]></same_default>
    <relevance><![CDATA[1]]></relevance>
   </row>
  </rows>
 </questions>
 <question_l10ns>
  <fields>
   <fieldname>id</fieldname>
   <fieldname>qid</fieldname>
   <fieldname>question</fieldname>
   <fieldname>help</fieldname>
   <fieldname>script</fieldname>
   <fieldname>language</fieldname>
  </fields>
  <rows>
   <row>
    <id><![CDATA[214]]></id>
    <qid><![CDATA[214]]></qid>
    <question><![CDATA[A first example question. Please answer this question:]]></question>
    <help><![CDATA[This is a question help text.]]></help>
    <language><![CDATA[en]]></language>
   </row>
  </rows>
 </question_l10ns>
 <surveys>
  <fields>
   <fieldname>sid</fieldname>
   <fieldname>gsid</fieldname>
   <fieldname>admin</fieldname>
   <fieldname>expires</fieldname>
   <fieldname>startdate</fieldname>
   <fieldname>adminemail</fieldname>
   <fieldname>anonymized</fieldname>
   <fieldname>faxto</fieldname>
   <fieldname>format</fieldname>
   <fieldname>savetimings</fieldname>
   <fieldname>template</fieldname>
   <fieldname>language</fieldname>
   <fieldname>additional_languages</fieldname>
   <fieldname>datestamp</fieldname>
   <fieldname>usecookie</fieldname>
   <fieldname>allowregister</fieldname>
   <fieldname>allowsave</fieldname>
   <fieldname>autonumber_start</fieldname>
   <fieldname>autoredirect</fieldname>
   <fieldname>allowprev</fieldname>
   <fieldname>printanswers</fieldname>
   <fieldname>ipaddr</fieldname>
   <fieldname>refurl</fieldname>
   <fieldname>showsurveypolicynotice</fieldname>
   <fieldname>publicstatistics</fieldname>
   <fieldname>publicgraphs</fieldname>
   <fieldname>listpublic</fieldname>
   <fieldname>htmlemail</fieldname>
   <fieldname>sendconfirmation</fieldname>
   <fieldname>tokenanswerspersistence</fieldname>
   <fieldname>assessments</fieldname>
   <fieldname>usecaptcha</fieldname>
   <fieldname>usetokens</fieldname>
   <fieldname>bounce_email</fieldname>
   <fieldname>attributedescriptions</fieldname>
   <fieldname>emailresponseto</fieldname>
   <fieldname>emailnotificationto</fieldname>
   <fieldname>tokenlength</fieldname>
   <fieldname>showxquestions</fieldname>
   <fieldname>showgroupinfo</fieldname>
   <fieldname>shownoanswer</fieldname>
   <fieldname>showqnumcode</fieldname>
   <fieldname>bouncetime</fieldname>
   <fieldname>bounceprocessing</fieldname>
   <fieldname>bounceaccounttype</fieldname>
   <fieldname>bounceaccounthost</fieldname>
   <fieldname>bounceaccountpass</fieldname>
   <fieldname>bounceaccountencryption</fieldname>
   <fieldname>bounceaccountuser</fieldname>
   <fieldname>showwelcome</fieldname>
   <fieldname>showprogress</fieldname>
   <fieldname>questionindex</fieldname>
   <fieldname>navigationdelay</fieldname>
   <fieldname>nokeyboard</fieldname>
   <fieldname>alloweditaftercompletion</fieldname>
   <fieldname>googleanalyticsstyle</fieldname>
   <fieldname>googleanalyticsapikey</fieldname>
   <fieldname>tokenencryptionoptions</fieldname>
   <fieldname>ipanonymize</fieldname>
  </fields>
  <rows>
   <row>
    <sid><![CDATA[658785]]></sid>
    <gsid><![CDATA[1]]></gsid>
    <admin><![CDATA[MY survey admin]]></admin>
    <adminemail/>
    <anonymized><![CDATA[N]]></anonymized>
    <format><![CDATA[I]]></format>
    <savetimings><![CDATA[I]]></savetimings>
    <template><![CDATA[inherit]]></template>
    <language><![CDATA[en]]></language>
    <additional_languages/>
    <datestamp><![CDATA[I]]></datestamp>
    <usecookie><![CDATA[I]]></usecookie>
    <allowregister><![CDATA[I]]></allowregister>
    <allowsave><![CDATA[I]]></allowsave>
    <autonumber_start><![CDATA[0]]></autonumber_start>
    <autoredirect><![CDATA[I]]></autoredirect>
    <allowprev><![CDATA[I]]></allowprev>
    <printanswers><![CDATA[I]]></printanswers>
    <ipaddr><![CDATA[I]]></ipaddr>
    <refurl><![CDATA[I]]></refurl>
    <showsurveypolicynotice><![CDATA[1]]></showsurveypolicynotice>
    <publicstatistics><![CDATA[I]]></publicstatistics>
    <publicgraphs><![CDATA[I]]></publicgraphs>
    <listpublic><![CDATA[I]]></listpublic>
    <htmlemail><![CDATA[I]]></htmlemail>
    <sendconfirmation><![CDATA[I]]></sendconfirmation>
    <tokenanswerspersistence><![CDATA[I]]></tokenanswerspersistence>
    <assessments><![CDATA[I]]></assessments>
    <usecaptcha><![CDATA[E]]></usecaptcha>
    <usetokens><![CDATA[N]]></usetokens>
    <bounce_email><![CDATA[inherit]]></bounce_email>
    <emailresponseto><![CDATA[inherit]]></emailresponseto>
    <emailnotificationto><![CDATA[inherit]]></emailnotificationto>
    <tokenlength><![CDATA[-1]]></tokenlength>
    <showxquestions><![CDATA[I]]></showxquestions>
    <showgroupinfo><![CDATA[I]]></showgroupinfo>
    <shownoanswer><![CDATA[I]]></shownoanswer>
    <showqnumcode><![CDATA[I]]></showqnumcode>
    <bounceprocessing><![CDATA[N]]></bounceprocessing>
    <showwelcome><![CDATA[I]]></showwelcome>
    <showprogress><![CDATA[I]]></showprogress>
    <questionindex><![CDATA[-1]]></questionindex>
    <navigationdelay><![CDATA[-1]]></navigationdelay>
    <nokeyboard><![CDATA[I]]></nokeyboard>
    <alloweditaftercompletion><![CDATA[I]]></alloweditaftercompletion>
    <googleanalyticsstyle/>
    <googleanalyticsapikey/>
    <tokenencryptionoptions/>
    <ipanonymize><![CDATA[I]]></ipanonymize>
   </row>
  </rows>
 </surveys>
 <surveys_languagesettings>
  <fields>
   <fieldname>surveyls_survey_id</fieldname>
   <fieldname>surveyls_language</fieldname>
   <fieldname>surveyls_title</fieldname>
   <fieldname>surveyls_description</fieldname>
   <fieldname>surveyls_welcometext</fieldname>
   <fieldname>surveyls_endtext</fieldname>
   <fieldname>surveyls_policy_notice</fieldname>
   <fieldname>surveyls_policy_error</fieldname>
   <fieldname>surveyls_policy_notice_label</fieldname>
   <fieldname>surveyls_url</fieldname>
   <fieldname>surveyls_urldescription</fieldname>
   <fieldname>surveyls_email_invite_subj</fieldname>
   <fieldname>surveyls_email_invite</fieldname>
   <fieldname>surveyls_email_remind_subj</fieldname>
   <fieldname>surveyls_email_remind</fieldname>
   <fieldname>surveyls_email_register_subj</fieldname>
   <fieldname>surveyls_email_register</fieldname>
   <fieldname>surveyls_email_confirm_subj</fieldname>
   <fieldname>surveyls_email_confirm</fieldname>
   <fieldname>surveyls_dateformat</fieldname>
   <fieldname>surveyls_attributecaptions</fieldname>
   <fieldname>email_admin_notification_subj</fieldname>
   <fieldname>email_admin_notification</fieldname>
   <fieldname>email_admin_responses_subj</fieldname>
   <fieldname>email_admin_responses</fieldname>
   <fieldname>surveyls_numberformat</fieldname>
   <fieldname>attachments</fieldname>
  </fields>
  <rows>
   <row>
    <surveyls_survey_id><![CDATA[658785]]></surveyls_survey_id>
    <surveyls_language><![CDATA[en]]></surveyls_language>
    <surveyls_title><![CDATA[test 210610 - survey data policy error message]]></surveyls_title>
    <surveyls_description/>
    <surveyls_welcometext/>
    <surveyls_endtext/>
    <surveyls_policy_notice><![CDATA[MY data policy message]]></surveyls_policy_notice>
    <surveyls_policy_error><![CDATA[MY error message]]></surveyls_policy_error>
    <surveyls_policy_notice_label><![CDATA[MY data policy label]]></surveyls_policy_notice_label>
    <surveyls_url/>
    <surveyls_urldescription/>
    <surveyls_email_invite_subj><![CDATA[Invitation to participate in a survey]]></surveyls_email_invite_subj>
    <surveyls_email_invite><![CDATA[Dear {FIRSTNAME},

you have been invited to participate in a survey.

The survey is titled:
"{SURVEYNAME}"

"{SURVEYDESCRIPTION}"

To participate, please click on the link below.

Sincerely,

{ADMINNAME} ({ADMINEMAIL})

----------------------------------------------
Click here to do the survey:
{SURVEYURL}

If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:
{OPTOUTURL}

If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link:
{OPTINURL}]]></surveyls_email_invite>
    <surveyls_email_remind_subj><![CDATA[Reminder to participate in a survey]]></surveyls_email_remind_subj>
    <surveyls_email_remind><![CDATA[Dear {FIRSTNAME},

Recently we invited you to participate in a survey.

We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.

The survey is titled:
"{SURVEYNAME}"

"{SURVEYDESCRIPTION}"

To participate, please click on the link below.

Sincerely,

{ADMINNAME} ({ADMINEMAIL})

----------------------------------------------
Click here to do the survey:
{SURVEYURL}

If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:
{OPTOUTURL}]]></surveyls_email_remind>
    <surveyls_email_register_subj><![CDATA[Survey registration confirmation]]></surveyls_email_register_subj>
    <surveyls_email_register><![CDATA[Dear {FIRSTNAME},

You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.

To complete this survey, click on the following URL:

{SURVEYURL}

If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.]]></surveyls_email_register>
    <surveyls_email_confirm_subj><![CDATA[Confirmation of your participation in our survey]]></surveyls_email_confirm_subj>
    <surveyls_email_confirm><![CDATA[Dear {FIRSTNAME},

this email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.

If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}.

Sincerely,

{ADMINNAME}]]></surveyls_email_confirm>
    <surveyls_dateformat><![CDATA[9]]></surveyls_dateformat>
    <email_admin_notification_subj><![CDATA[Response submission for survey {SURVEYNAME}]]></email_admin_notification_subj>
    <email_admin_notification><![CDATA[Hello,

A new response was submitted for your survey '{SURVEYNAME}'.

Click the following link to see the individual response:
{VIEWRESPONSEURL}

Click the following link to edit the individual response:
{EDITRESPONSEURL}

View statistics by clicking here:
{STATISTICSURL}]]></email_admin_notification>
    <email_admin_responses_subj><![CDATA[Response submission for survey {SURVEYNAME} with results]]></email_admin_responses_subj>
    <email_admin_responses><![CDATA[Hello,

A new response was submitted for your survey '{SURVEYNAME}'.

Click the following link to see the individual response:
{VIEWRESPONSEURL}

Click the following link to edit the individual response:
{EDITRESPONSEURL}

View statistics by clicking here:
{STATISTICSURL}


The following answers were given by the participant:
{ANSWERTABLE}]]></email_admin_responses>
    <surveyls_numberformat><![CDATA[0]]></surveyls_numberformat>
   </row>
  </rows>
 </surveys_languagesettings>
 <themes>
  <theme>
   <sid>658785</sid>
   <template_name>fruity</template_name>
   <config>
    <options>inherit</options>
   </config>
  </theme>
 </themes>
 <themes_inherited>
  <theme>
   <sid>658785</sid>
   <template_name>fruity</template_name>
   <config>
    <options>
     <ajaxmode>off</ajaxmode>
     <brandlogo>on</brandlogo>
     <brandlogofile>themes/survey/fruity/files/logo.png</brandlogofile>
     <container>on</container>
     <backgroundimage>off</backgroundimage>
     <animatebody>off</animatebody>
     <bodyanimation>fadeInRight</bodyanimation>
     <bodyanimationduration>500</bodyanimationduration>
     <animatequestion>off</animatequestion>
     <questionanimation>flipInX</questionanimation>
     <questionanimationduration>500</questionanimationduration>
     <animatealert>off</animatealert>
     <alertanimation>shake</alertanimation>
     <alertanimationduration>500</alertanimationduration>
     <font>noto</font>
     <bodybackgroundcolor>#ffffff</bodybackgroundcolor>
     <fontcolor>#444444</fontcolor>
     <questionbackgroundcolor>#ffffff</questionbackgroundcolor>
     <questionborder>on</questionborder>
     <questioncontainershadow>on</questioncontainershadow>
     <checkicon>f00c</checkicon>
     <animatecheckbox>on</animatecheckbox>
     <checkboxanimation>rubberBand</checkboxanimation>
     <checkboxanimationduration>500</checkboxanimationduration>
     <animateradio>on</animateradio>
     <radioanimation>zoomIn</radioanimation>
     <radioanimationduration>500</radioanimationduration>
     <zebrastriping>off</zebrastriping>
     <stickymatrixheaders>off</stickymatrixheaders>
     <greyoutselected>off</greyoutselected>
     <hideprivacyinfo>off</hideprivacyinfo>
     <crosshover>off</crosshover>
     <showpopups>1</showpopups>
     <showclearall>off</showclearall>
     <questionhelptextposition>top</questionhelptextposition>
     <notables>1</notables>
    </options>
   </config>
  </theme>
 </themes_inherited>
</document>
limesurvey_survey_658785.lss (15,333 bytes)   
DenisChenu

DenisChenu

2021-06-11 12:40

developer   ~64869

Without JS :

1. showsurveypolicynotice to 1 :
    - See the datasec
    - No way to have error without hacking HTMLL (required on checkbox)
    - remove reuqired : see the datasecerror
2. showsurveypolicynotice to 2 :
    - don't the datasec (Fruity theme)
    - submit : see the datasecerror


With JS :

1. showsurveypolicynotice to 1 :
    - See the datasec
    - No way to have error without hacking HTML/JS
2. showsurveypolicynotice to 2 :
    - See the datasec on click
    - No way to have error without hacking HTML/JS

Maybe just allow move next in any condition and fix the no-js / showsurveypolicynotice to 2 ( fix .collapse + .fade in bootsrap (i must check on skelvanilla)
gabrieljenik

gabrieljenik

2021-06-11 18:38

manager   ~64887

That field "policy data error" wasn't shown on Vue implementation.
When we port screen from V3 it appeared again and we forgot to remove it.
We thought of removing it as it has no implementation associated, but I think we missed it.

My thought:
- Remove it
- Add new ticket for adding the feature back (properly prioritized).

@ollehar @c_schmitz, what do you think?
DenisChenu

DenisChenu

2021-06-11 18:45

developer   ~64888

But : iit's great to have something to show !
It's really more unbderstandable and clear for user.

See Frederic issue : «If a user leaves the checkbox unchecked, nothing happens - no error message is displayed at all.»

My opinion : we need to show the error
DenisChenu

DenisChenu

2021-06-11 18:46

developer   ~64889

PS : i surely fix in my way for 3.X in SkelVanilla.
gabrieljenik

gabrieljenik

2021-06-11 19:04

manager   ~64890

Agree, an error should be shown. I think we have fixed that in the past. Let us review
gabrieljenik

gabrieljenik

2021-06-14 16:40

manager   ~64894

This issue can't be reproduced, as is it is described:

When JS enabled:
- Next button is disabled until you accept the policies.

When JS is disbaled:
- Checkbox is marked as required, so a message is shown on the checkbox when Next button is clicked,

I see no issue here. Disabled buttons are widely used.

I would definitely remove the custom error field, which is something we left pending (by mistake) from the Vue revertion process.
Look forward for confirmation
gabrieljenik

gabrieljenik

2021-06-14 16:41

manager   ~64895

On the custom message, you could add something like "Please, accept the policies to continue". But that is per each administrator.
DenisChenu

DenisChenu

2021-06-14 18:30

developer   ~64904

> I would definitely remove the custom error field, which is something we left pending (by mistake) from the Vue revertion process.

No! no ! no !!

without JS : showsurveypolicynotice to 2 :
    - don't the datasec (Fruity theme)
    - submit : **see the datasecerror**

Again and aghain :
> See Frederic issue : «If a user leaves the checkbox unchecked, nothing happens - no error message is displayed at all.»

It's not because core theme is broken you must remove a great feature.
DenisChenu

DenisChenu

2021-06-14 18:31

developer   ~64905

Last edited: 2021-06-14 18:31

View 2 revisions

There must have a solution with and without js to have

- Show Survey policicy
- Try to do action
=> Show Survey policicy Error
ollehar

ollehar

2021-06-14 18:36

administrator   ~64906

> It's not because core theme is broken you must remove a great feature.

But this feature was never released?
DenisChenu

DenisChenu

2021-06-14 18:37

developer   ~64907

Check here for example : https://demo.sondages.pro/362576?newtest=Y&lang=fr

JS , move next : show error. Clean way
DenisChenu

DenisChenu

2021-06-14 18:42

developer   ~64908

> But this feature was never released?

I can check on the 1st 3.X but i think 1st version disn't have all this javascript and error is shown.

And see https://demo.sondages.pro/362576?newtest=Y&lang=fr , try to move next without submit.

It's a theme issue
DenisChenu

DenisChenu

2021-06-14 18:44

developer   ~64909

https://demo.sondages.pro/362576?newtest=Y&lang=fr
No-js : see message
Move next : see error
DenisChenu

DenisChenu

2021-06-15 09:41

developer   ~64911

reported for 3.X https://bugs.limesurvey.org/view.php?id=17367
With the fix ...
ollehar

ollehar

2021-06-16 18:08

administrator   ~64928

But we require JS for all survey taking...?
DenisChenu

DenisChenu

2021-06-16 18:30

developer   ~64929

No
We don't require JS always.

LimeSurvey public part work good without JS some exception, but work good.
DenisChenu

DenisChenu

2021-06-16 18:31

developer   ~64930

And the original issue was 2 seperate issue

1. If a user leaves the checkbox unchecked, nothing happens - no error message is displayed at all.
2. Also if JavaScript is disabled a generic error message pops up, not the message defined in LimeSurvey.
gabrieljenik

gabrieljenik

2021-06-16 20:30

manager   ~64931

Agree with the issues separation.

About this
> without JS : showsurveypolicynotice to 2 :
> - don't the datasec (Fruity theme)
> - submit : **see the datasecerror**

You managed it solve in your env? How?
I want to avoid touching the runtime.

My suggestion so far:
a - enable the next button even if JS is enabled
b - add custom validation as to show the custom error message (if JS is enabled)
c - If JS is disabled, no custom error message (sorry, minor of the cases)

What do you think?
ollehar

ollehar

2021-06-16 20:53

administrator   ~64932

> We don't require JS always.

We have a decision for this?
DenisChenu

DenisChenu

2021-06-17 07:44

developer   ~64933

I don't understand the question …

Currently : all question can be answered without javascript activated. If you disable this : it's a misfeature.

Here : the solution is really easy (it take me less than one hour to fix bnoth issue in theme).
DenisChenu

DenisChenu

2021-06-17 07:47

developer   ~64934

> You managed it solve in your env? How?

 policy_vanilla.zip (117,243 bytes) is really light : only an update to theme.js and too the 2 files for policy.

I make the commit in 5 minutes for skel (but no theme.js in skelvanilla : need to remove the disable button action)
gabrieljenik

gabrieljenik

2021-06-17 14:35

manager   ~64942

> only an update to theme.js and too the 2 files for policy

How do you solve it for the NoJS situation?
DenisChenu

DenisChenu

2021-06-17 15:20

developer   ~64944

Vanilla :
<div class="collapse fade in" id="data-security-modal-{{aSurveyInfo.sid}}">
… … …
</div>
<script>$("#data-security-modal-{{aSurveyInfo.sid}}").removeClass("in");</script>

But it's an BS3 issue (5 have same) : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/blob/master/css/skelvanilla.css#L380-382
/* Fix no-js on bootsrap */
.no-js .collapse{display: block;}
.no-js .fade{opacity: 1;}
gabrieljenik

gabrieljenik

2021-06-17 16:26

manager   ~64947

But you are not validating anything there, are you?

If I understand correctly, the issue is how to validate checkbox is checked with NoJS and don't updating the backend.
right?
DenisChenu

DenisChenu

2021-06-17 16:49

developer   ~64948

? The backend already check : it's already the case, you need it to be done in backend (else it's an issue).
DenisChenu

DenisChenu

2021-06-18 08:03

developer   ~64949

https://bugs.limesurvey.org/view.php?id=17367#c64936

@gabrieljenik : i make the pull request for 5.X the same time than 3.X
gabrieljenik

gabrieljenik

2021-06-18 14:59

manager   ~64953

OK, I will leave this ticket to you then.
DenisChenu

DenisChenu

2021-06-20 19:21

developer   ~64958

@gabrieljenik are right : no real control is done via server …

It's really done only via HTML : a client validation is NOT a validation !
DenisChenu

DenisChenu

2021-06-26 19:28

developer   ~65105

https://github.com/LimeSurvey/LimeSurvey/pull/1938

with
    inline : https://master.sondages.pro/256771?newtest=Y&lang=en
    collapsible : https://master.sondages.pro/389748?newtest=Y&lang=en
ollehar

ollehar

2021-07-21 17:28

administrator   ~65554

Still testing?
DenisChenu

DenisChenu

2021-07-21 17:31

developer   ~65558

reviewed yesterday : https://github.com/LimeSurvey/LimeSurvey/pull/1937
ollehar

ollehar

2021-07-21 17:32

administrator   ~65559

So needs testing?
DenisChenu

DenisChenu

2021-07-21 17:40

developer   ~65562

I don't know
DenisChenu

DenisChenu

2021-07-22 19:21

developer   ~65583

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32362

Related Changesets

LimeSurvey: master 8414afd6

2021-07-22 19:19:03

DenisChenu


Committer: GitHub Details Diff
Fixed issue 17363: Survey data policy error message not displayed (#1938) Affected Issues
17363
mod - themes/survey/vanilla/config.xml Diff File
mod - themes/survey/vanilla/scripts/theme.js Diff File
mod - themes/survey/vanilla/views/subviews/content/firstpage.twig Diff File
mod - themes/survey/vanilla/views/subviews/messages/warnings.twig Diff File
mod - themes/survey/vanilla/views/subviews/privacy/allinone_mode_welcome_privacy.twig Diff File
mod - themes/survey/vanilla/views/subviews/privacy/privacy.twig Diff File
mod - themes/survey/vanilla/views/subviews/privacy/privacy_modal.twig Diff File
mod - themes/survey/vanilla/views/subviews/privacy/privacy_text.twig Diff File

Issue History

Date Modified Username Field Change
2021-06-10 13:40 f_funke New Issue
2021-06-10 13:40 f_funke File Added: bug_LimeSurvey_5_0_2_error_message_privacy.png
2021-06-10 13:40 f_funke File Added: bug_LimeSurvey_5_0_2_error_message_privacy_noJS.png
2021-06-10 13:40 f_funke File Added: limesurvey_survey_658785.lss
2021-06-10 14:21 c_schmitz Assigned To => gabrieljenik
2021-06-10 14:21 c_schmitz Priority none => high
2021-06-10 14:21 c_schmitz Status new => assigned
2021-06-11 12:40 DenisChenu Note Added: 64869
2021-06-11 18:38 gabrieljenik Note Added: 64887
2021-06-11 18:45 DenisChenu Note Added: 64888
2021-06-11 18:46 DenisChenu Note Added: 64889
2021-06-11 19:04 gabrieljenik Note Added: 64890
2021-06-14 16:40 gabrieljenik Note Added: 64894
2021-06-14 16:41 gabrieljenik Note Added: 64895
2021-06-14 18:30 DenisChenu Note Added: 64904
2021-06-14 18:31 DenisChenu Note Added: 64905
2021-06-14 18:31 DenisChenu Note Edited: 64905 View Revisions
2021-06-14 18:36 ollehar Note Added: 64906
2021-06-14 18:37 DenisChenu Note Added: 64907
2021-06-14 18:42 DenisChenu Note Added: 64908
2021-06-14 18:44 DenisChenu Note Added: 64909
2021-06-15 09:40 DenisChenu Relationship added related to 17367
2021-06-15 09:41 DenisChenu Note Added: 64911
2021-06-16 18:08 ollehar Note Added: 64928
2021-06-16 18:30 DenisChenu Note Added: 64929
2021-06-16 18:31 DenisChenu Note Added: 64930
2021-06-16 20:30 gabrieljenik Note Added: 64931
2021-06-16 20:53 ollehar Note Added: 64932
2021-06-17 07:44 DenisChenu Note Added: 64933
2021-06-17 07:47 DenisChenu Note Added: 64934
2021-06-17 14:35 gabrieljenik Note Added: 64942
2021-06-17 15:20 DenisChenu Note Added: 64944
2021-06-17 16:26 gabrieljenik Note Added: 64947
2021-06-17 16:49 DenisChenu Note Added: 64948
2021-06-18 08:02 DenisChenu Assigned To gabrieljenik => DenisChenu
2021-06-18 08:03 DenisChenu Note Added: 64949
2021-06-18 14:59 gabrieljenik Note Added: 64953
2021-06-20 19:21 DenisChenu Note Added: 64958
2021-06-26 19:27 DenisChenu Assigned To DenisChenu => f_funke
2021-06-26 19:28 DenisChenu Note Added: 65105
2021-06-26 19:28 DenisChenu Status assigned => testing
2021-06-26 19:29 DenisChenu Relationship added related to 17405
2021-07-21 17:28 ollehar Status testing => feedback
2021-07-21 17:28 ollehar Note Added: 65554
2021-07-21 17:31 DenisChenu Note Added: 65558
2021-07-21 17:32 ollehar Status feedback => new
2021-07-21 17:32 ollehar Note Added: 65559
2021-07-21 17:40 DenisChenu Note Added: 65562
2021-07-22 12:43 galads Assigned To f_funke => ollehar
2021-07-22 12:43 galads Status new => review
2021-07-22 19:21 DenisChenu Changeset attached => LimeSurvey master 8414afd6
2021-07-22 19:21 DenisChenu Note Added: 65583
2021-07-22 19:21 DenisChenu Assigned To ollehar => DenisChenu
2021-07-22 19:21 DenisChenu Resolution open => fixed