Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
17355Development Otherpublic2021-06-07 20:20
Reportergabrieljenik Assigned To 
PrioritynoneSeverityfeature 
Status assignedResolutionopen 
Target Version4.x.0-dev 
Summary17355: Code cleanup after attributeFetcher service
DescriptionWe believe the following can be cleaned up after attributeFetcher() implementation.

Question model:
- getAdvancedSettingsWithValues() should not be part of the Question AR

QuestionAttribute model
- getQuestionAttributes() should not be part of the QuestionAttribute AR
- addAdditionalAttributesFromExtendedTheme() is not in use anymore. Should be removed? Add a deprecation notice?
- getQuestionAttributesSettings() is only used in TSVImportSurvey().
- getAdvancedAttributesFromXml() is only used in QuestionAttribute::getQuestionAttributesSettings()
- getGeneralAttibutesFromXml() is only used in QuestionAttribute::getQuestionAttributesSettings()

QuestionTheme model
- getQuestionThemeAttributeValues() is not in use anymore. Should be removed? Add a deprecation notice?
- getAdditionalAttrFromExtendedTheme() used in QuestionAttribute::addAdditionalAttributesFromExtendedTheme() and QuestionTheme::getQuestionThemeAttributeValues()

QuestionAttributeHelper should be used by:
- TSVImportSurvey() (import_helper). Since it's a helper, injection is difficult.
TagsNo tags attached.

Relationships

related to 17261 reviewgabrieljenik Create new code artifacts to handle QuestionAttributes fetching (& saving) 

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2021-06-07 20:20 gabrieljenik New Issue
2021-06-07 20:20 gabrieljenik Status new => assigned
2021-06-07 20:20 gabrieljenik Assigned To => gabrieljenik
2021-06-07 20:20 gabrieljenik Issue generated from: 17261
2021-06-07 20:20 gabrieljenik Relationship added related to 17261
2021-06-07 20:20 gabrieljenik Assigned To gabrieljenik =>