Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
17270Bug reportsStatisticspublic2021-07-12 11:53
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version3.25.20 
Fixed in Version3.25.20 
Summary17270: Print statistics are totally broken (lot of page)
DescriptionWhen try to use Browser print systeml to print statistics : ita make a totally unusuable file : a lot of white page.

It work a lotb better in 2.73 or deactivate CSS
Steps To ReproduceImport included survey : 1 single choice question, no open questuion
Go to response / Response & statitics
Click on Statitics button
Choose :
- All responses
- View summary of all available fields: On
- Show graphs: ON
Click on View statitics
Click on your browser : file print
Additional InformationTested with Chrome and Firefox

With Firefox :
- Install : https://chrispederick.com/work/web-developer/
- Same than before
- Check : disable all style
- Print : really better

Leave 273 archive (and print)
TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)3.26.0
I will donate to the project if issue is resolvedNo
Browserchrome/firefox
Database & DB-Versionnot relevant?
Server OS (if known)not relevant ?
Webserver software & version (if known)not relevant ?
PHP Versionnot relevant ?

Relationships

related to 17271 feedbackgabrieljenik Print statistics are totally broken (near empty) 

Activities

DenisChenu

DenisChenu

2021-04-24 10:36

developer  

LimeSurvey-defaultCSS.pdf (1,280,568 bytes)
LimeSurvey-disableCSS.pdf (330,100 bytes)
ollehar

ollehar

2021-04-26 09:48

administrator   ~64148

Can you enable debug = 2 in application/config/config.php and try again, please? Paste the complete error message here.
DenisChenu

DenisChenu

2021-04-26 11:26

developer   ~64151

There are no error message (with or without debug)

CSS is messy …
 - Show graphs: ON : more than 800 page with Chrome and firefox
 - Show graphs: OFF : 1 page with Chrome and firefox
DenisChenu

DenisChenu

2021-05-01 10:55

developer   ~64207

@ollehar Firefoix print css work good here (see screenshot).

I try to work on adminbasics package (on Fedora)

Receive : [!] (css plugin) Error: Node Sass does not yet support your current environment: Linux 64-bit with Unsupported runtime (83)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.12.0

This need to be reported too ?
DenisChenu

DenisChenu

2021-05-01 10:55

developer   ~64208

ollehar

ollehar

2021-05-04 17:56

administrator   ~64233

Last edited: 2021-05-04 17:57

View 2 revisions

> Click on your browser : file print

Why not export to PDF instead...? Not sure browser print file is a needed use-case to support. Or?
DenisChenu

DenisChenu

2021-05-04 18:30

developer   ~64239

PDF didn't export graph on the same way (unusure it use attribute)

And here are BAD css added to «improve» print statistics : https://github.com/LimeSurvey/LimeSurvey/blob/b43418320d384cd1b37799ac051994a4c2e99eff/assets/packages/adminbasics/scss/000-lime-admin-common.scss#L2961

All this part didn't exist in 2.73

Just removing this part make a better (not perfect) PDF.

Did you compare print from 2.73 and print from 3.X ?

PS : removing this part don't make like 2.73 … seems 2.73 have another (and better improvment).
DenisChenu

DenisChenu

2021-05-04 18:32

developer   ~64240

Last edited: 2021-05-04 18:34

View 2 revisions

> Not sure browser print file is a needed use-case to support. Or?

With such answer : i really stop to report issue …

If i report it's because someone inform me there are an issue here …
On forum or by email etc …

If it's the same in 2.73 : maybe i didn't report (or as a new feature)
ollehar

ollehar

2021-05-04 18:37

administrator   ~64241

Last edited: 2021-05-04 18:38

View 2 revisions

With limited resources, sometimes the bug is the user. ;) Especially if we already _do_ support PDF export, but in another way.
DenisChenu

DenisChenu

2021-05-04 18:40

developer   ~64242

I don't find with blame when this : https://github.com/LimeSurvey/LimeSurvey/blob/b43418320d384cd1b37799ac051994a4c2e99eff/assets/packages/adminbasics/scss/000-lime-admin-common.scss#L2961

Was updated.
ollehar

ollehar

2021-05-06 11:31

administrator   ~64261

> Just removing this part make a better (not perfect) PDF.

PR to remove? Have to rebuild all admin css, or?
DenisChenu

DenisChenu

2021-05-06 11:35

developer   ~64262

I don't find the PR :

i try removing all this part for starting : 2.73 still better (not perfect).

Yes : need rebuild : see https://bugs.limesurvey.org/view.php?id=17270#c64207

> I try to work on adminbasics package (on Fedora)
>
> Receive : [!] (css plugin) Error: Node Sass does not yet support your current environment: Linux 64-bit with Unsupported runtime (83)
> For more information on which environments are supported please see:
> https://github.com/sass/node-sass/releases/tag/v4.12.0
>
> This need to be reported too ?
ollehar

ollehar

2021-05-06 11:39

administrator   ~64265

Urgh. Build through docker...?
DenisChenu

DenisChenu

2021-05-06 11:55

developer   ~64266

No, just on my local , i don't use docker for quick development :)
ollehar

ollehar

2021-05-06 11:56

administrator   ~64267

https://github.com/catchdigital/docker-node-sass
DenisChenu

DenisChenu

2021-05-06 14:34

developer   ~64271

Last edited: 2021-05-06 14:34

View 2 revisions

It's not yarn now ?
https://github.com/LimeSurvey/LimeSurvey/commit/544f745277ceac63df40f111589830482f040e8b
ollehar

ollehar

2021-05-06 15:34

administrator   ~64273

Yarn installs node-sass? No idea. ><
DenisChenu

DenisChenu

2021-05-06 15:45

developer   ~64275

I have a debian 10 somewhere …
DenisChenu

DenisChenu

2021-05-14 13:47

developer   ~64415

https://github.com/LimeSurvey/LimeSurvey/pull/1880
DenisChenu

DenisChenu

2021-05-21 08:24

developer   ~64493

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31806
c_schmitz

c_schmitz

2021-07-12 11:53

administrator   ~65345

Release done.

Related Changesets

LimeSurvey: 3.x-LTS 7220965b

2021-05-21 08:24:06

DenisChenu


Committer: GitHub Details Diff
Fixed issue 17270: Print statistics take a lot of page (#1880)

Dev: Still has issues but really cleaner
Affected Issues
17270
mod - application/helpers/admin/statistics_helper.php Diff File
mod - application/views/admin/export/generatestats/_header.php Diff File
mod - application/views/admin/export/generatestats/_statisticsoutput_footer.php Diff File
mod - application/views/admin/export/generatestats/_statisticsoutput_graphs.php Diff File
mod - application/views/admin/export/generatestats/_statisticsoutput_header.php Diff File
mod - application/views/admin/export/statistics_browse_view.php Diff File
mod - application/views/admin/export/statistics_subviews/_statistics_header.php Diff File
mod - application/views/admin/export/statistics_view.php Diff File
mod - assets/packages/adminbasics/build/adminbasics.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.js Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.js Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.min.css Diff File
mod - assets/packages/adminbasics/css/lime-admin-common.css Diff File
mod - assets/packages/adminbasics/rollup.config.js Diff File
mod - assets/packages/adminbasics/scss/000-lime-admin-common.scss Diff File
mod - assets/packages/adminbasics/scss/ltr/000-lime-admin-common.scss Diff File
mod - assets/packages/adminbasics/scss/rtl/000-lime-admin-common-rtl.scss Diff File
mod - assets/packages/adminbasics/yarn.lock Diff File

Issue History

Date Modified Username Field Change
2021-04-24 10:36 DenisChenu New Issue
2021-04-24 10:36 DenisChenu File Added: LimeSurvey-defaultCSS.pdf
2021-04-24 10:36 DenisChenu File Added: LimeSurvey-disableCSS.pdf
2021-04-24 10:36 DenisChenu File Added: survey_archive_287435.lsa
2021-04-24 10:36 DenisChenu File Added: survey_archive_273-287435.lsa
2021-04-24 10:36 DenisChenu File Added: LimeSurvey273-defaultCSS.pdf
2021-04-24 19:43 DenisChenu Summary Ptint statistics are totally broken => Print statistics are totally broken (lot of page)
2021-04-24 19:47 DenisChenu Relationship added related to 17271
2021-04-26 09:48 ollehar Assigned To => ollehar
2021-04-26 09:48 ollehar Status new => feedback
2021-04-26 09:48 ollehar Note Added: 64148
2021-04-26 11:26 DenisChenu Note Added: 64151
2021-04-26 11:26 DenisChenu File Added: Capture d’écran_2021-04-26_11-24-33.png
2021-04-26 11:26 DenisChenu File Added: Capture d’écran_2021-04-26_11-26-17.png
2021-04-26 11:26 DenisChenu Status feedback => assigned
2021-04-26 11:26 DenisChenu Steps to Reproduce Updated View Revisions
2021-05-01 10:55 DenisChenu Note Added: 64207
2021-05-01 10:55 DenisChenu Note Added: 64208
2021-05-01 10:55 DenisChenu File Added: Capture d’écran_2021-05-01_10-53-38.png
2021-05-04 17:56 ollehar Note Added: 64233
2021-05-04 17:57 ollehar Note Edited: 64233 View Revisions
2021-05-04 18:30 DenisChenu Note Added: 64239
2021-05-04 18:32 DenisChenu Note Added: 64240
2021-05-04 18:34 DenisChenu Note Edited: 64240 View Revisions
2021-05-04 18:37 ollehar Note Added: 64241
2021-05-04 18:38 ollehar Note Edited: 64241 View Revisions
2021-05-04 18:40 DenisChenu Note Added: 64242
2021-05-06 11:31 ollehar Note Added: 64261
2021-05-06 11:35 DenisChenu Note Added: 64262
2021-05-06 11:39 ollehar Note Added: 64265
2021-05-06 11:55 DenisChenu Note Added: 64266
2021-05-06 11:56 ollehar Note Added: 64267
2021-05-06 14:34 DenisChenu Note Added: 64271
2021-05-06 14:34 DenisChenu Note Edited: 64271 View Revisions
2021-05-06 15:34 ollehar Note Added: 64273
2021-05-06 15:45 DenisChenu Note Added: 64275
2021-05-14 13:47 DenisChenu Note Added: 64415
2021-05-21 08:24 DenisChenu Changeset attached => LimeSurvey 3.x-LTS 7220965b
2021-05-21 08:24 DenisChenu Note Added: 64493
2021-05-21 08:24 DenisChenu Assigned To ollehar => DenisChenu
2021-05-21 08:24 DenisChenu Resolution open => fixed
2021-05-24 20:13 DenisChenu Status assigned => resolved
2021-05-24 20:13 DenisChenu Fixed in Version => 4.5.x
2021-05-24 20:13 DenisChenu Fixed in Version 4.5.x => 3.25.20
2021-07-12 11:53 c_schmitz Note Added: 65345
2021-07-12 11:53 c_schmitz Bug heat 4 => 6
2021-07-12 11:53 c_schmitz Status resolved => closed