Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
17036Bug reportsOtherpublic2021-02-22 16:20
Reportercdorin Assigned Toollehar  
PriorityhighSeveritypartial_block 
Status resolvedResolutionfixed 
Product Version4.4.0 
Summary17036: Question attribute: Time limit disable next
Description

Question attribute: Time limit disable next (to be checked all question types)

If enabled, the "next" button is not disabled.

TagsNo tags attached.
Complete LimeSurvey version number (& build)4.4.0
I will donate to the project if issue is resolvedNo
Sync to Zoho ProjectYes
Browser
Database & DB-Versionirrelevant
Server OS (if known)
Webserver software & version (if known)
PHP Versionirrelevant

Relationships

related to 17037 resolvedJHoeck Question attribute: Time limit disable prev 
related to 17086 assignedpstelling Imported survey : hide tip broken 
related to 17087 closedollehar Checkbox layout lost after update (or when import survey) 

Activities

DenisChenu

DenisChenu

2021-01-30 09:44

developer   ~61815

If enabled, the "next" button is not disabled.

It was never the case !

Time limit mean "You have 10 minutes" to fill this answer , but you can do in 3 if needed.

Setting the time_limit attribute on a question will cause a countdown timer to begin counting down as soon as that question/page is loaded. At the expiry of the countdown timer the question will either automatically move on to the next page or become read-only.

https://manual.limesurvey.org/Question_type_-_Short_free_text#Time_limit_.28time_limit.29

This is not a bug ! It's the attented behaviour !

cdorin

cdorin

2021-01-30 17:44

manager   ~61823

Hey Denis,

I tested in LS3:

  • if "time limit disable next" is enabled, then the next button is not clickable during survey taking.

The behaviour is different in LS4, the next button not being disabled.

cdorin

cdorin

2021-01-30 17:45

manager   ~61824

If:
-time limit disable next is On

  • time limit disable prev is ON.
  • Time limit is set to X seconds,

Then, for X seconds, Prev and Next button should be unclickable during survey taking (that's the behaviour I have in LS3)

DenisChenu

DenisChenu

2021-01-31 10:56

developer   ~61827

Oh : https://manual.limesurvey.org/Question_type_-_Short_free_text#Time_limit_disable_next_.28time_limit_disable_next.29

Really this time limit must move to a Plugin … lot of settings used by only some user …

gabrieljenik

gabrieljenik

2021-02-02 17:29

developer   ~61867

I think the problem is related to the new switch.php view.
Previously we used switch from bootstrap wich uses value 1 and 0,
Now we use AdvancedSettingWidget and switch.php, which uses Y/N.

So, we can adjust this for the time limit, but I think this will happen in many other situations.
Should we just update the switch.php view?

Strategy: Have switch.php to take options and values from the settings passed ?

DenisChenu

DenisChenu

2021-02-02 17:30

developer   ~61868

switch.php, which uses Y/N.

… noooooooo

Can we move again to 0/1 by default ?

cdorin

cdorin

2021-02-02 17:31

manager   ~61869

@ollehar , have time to take a look?

DenisChenu

DenisChenu

2021-02-02 17:34

developer   ~61870

Last edited: 2021-02-02 17:35

View 2 revisions

Remind : this broke ALL QuestionTheme and (in some week) plugin using switch.

And clearly : activated == true == 1
Not activated == false == 0

is better …

gabrieljenik

gabrieljenik

2021-02-17 18:03

developer   ~62321

This should be working after this commit:
https://github.com/LimeSurvey/LimeSurvey/commit/1d7b620f7dca5b79171c9c5d844cffe2254ed9dd

ollehar

ollehar

2021-02-22 15:21

administrator   ~62435

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31151

ollehar

ollehar

2021-02-22 15:22

administrator   ~62437

One issue still left, variable $disabled, no idea what it means. See todo in commit.

gabrieljenik

gabrieljenik

2021-02-22 16:03

developer   ~62451

One issue still left, variable $disabled, no idea what it means. See todo in commit.

Where?

ollehar

ollehar

2021-02-22 16:20

administrator   ~62454

Here: https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/QuestionBaseRenderer.php#L215

Related Changesets

LimeSurvey: master a79c8d28

2021-02-22 15:21:24

ollehar

Details Diff
Fixed issue 17036: Question attribute: Time limit disable next Affected Issues
17036
mod - application/models/QuestionBaseRenderer.php Diff File

Issue History

Date Modified Username Field Change
2021-01-29 17:51 cdorin New Issue
2021-01-29 17:51 cdorin Priority none => high
2021-01-29 17:51 cdorin Status new => confirmed
2021-01-29 17:51 cdorin Sync to Zoho Project Yes => Yes
2021-01-30 09:42 DenisChenu Relationship added related to 17037
2021-01-30 09:44 DenisChenu Note Added: 61815
2021-01-30 09:45 DenisChenu Assigned To => cdorin
2021-01-30 09:45 DenisChenu Status confirmed => feedback
2021-01-30 09:45 DenisChenu Complete LimeSurvey version number (& build) irrelevant => 4.4.0
2021-01-30 17:44 cdorin Note Added: 61823
2021-01-30 17:45 cdorin Note Added: 61824
2021-01-31 10:56 DenisChenu Note Added: 61827
2021-01-31 10:57 DenisChenu Status feedback => confirmed
2021-02-02 17:29 gabrieljenik Note Added: 61867
2021-02-02 17:30 DenisChenu Note Added: 61868
2021-02-02 17:31 cdorin Note Added: 61869
2021-02-02 17:34 DenisChenu Note Added: 61870
2021-02-02 17:35 DenisChenu Note Edited: 61870 View Revisions
2021-02-04 10:15 cdorin Status confirmed => new
2021-02-04 11:49 cdorin Assigned To cdorin =>
2021-02-04 11:49 cdorin Status new => confirmed
2021-02-04 11:49 cdorin Sync to Zoho Project Yes => Yes
2021-02-12 09:07 DenisChenu Relationship added related to 17086
2021-02-12 09:22 DenisChenu Relationship added related to 17087
2021-02-17 18:03 gabrieljenik Note Added: 62321
2021-02-22 15:21 ollehar Changeset attached => LimeSurvey master a79c8d28
2021-02-22 15:21 ollehar Note Added: 62435
2021-02-22 15:21 ollehar Assigned To => ollehar
2021-02-22 15:21 ollehar Resolution open => fixed
2021-02-22 15:21 ollehar Status confirmed => resolved
2021-02-22 15:22 ollehar Note Added: 62437
2021-02-22 16:03 gabrieljenik Note Added: 62451
2021-02-22 16:20 ollehar Note Added: 62454