Dependency Graph

Dependency Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
16659Bug reportsSurvey takingpublic2020-10-26 08:20
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.23.3 
Fixed in Version3.24.2 
Summary16659: PHP7.1 + debug set : PHP Warning A non-numeric value encountered
Description

When import included lss and launch : public part can receive PHP Warning

Steps To Reproduce

Import included survey
Set debug = 2
Test

Additional Information

PHP7.1 introduce integre checking/number checking.
Before 7.1 convert to 0.

LimeSurvey 2.73 show a text input,
LimeSurvey 3.X : a integer input from 0 to 100

The fix : check if it's integer (between 0 and 100) seems the best

TagsNo tags attached.
Attached Files
PHP warning.html (19,924 bytes)   
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>PHP warning</title>

<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}

body {
	font: normal 9pt "Verdana";
	color: #000;
	background: #fff;
}

h1 {
	font: normal 18pt "Verdana";
	color: #f00;
	margin-bottom: .5em;
}

h2 {
	font: normal 14pt "Verdana";
	color: #800000;
	margin-bottom: .5em;
}

h3 {
	font: bold 11pt "Verdana";
}

pre {
	font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}

pre span.error {
	display: block;
	background: #fce3e3;
}

pre span.ln {
	color: #999;
	padding-right: 0.5em;
	border-right: 1px solid #ccc;
}

pre span.error-ln {
	font-weight: bold;
}

.container {
	margin: 1em 4em;
}

.version {
	color: gray;
	font-size: 8pt;
	border-top: 1px solid #aaa;
	padding-top: 1em;
	margin-bottom: 1em;
}

.message {
	color: #000;
	padding: 1em;
	font-size: 11pt;
	background: #f3f3f3;
	-webkit-border-radius: 10px;
	-moz-border-radius: 10px;
	border-radius: 10px;
	margin-bottom: 1em;
	line-height: 160%;
}

.source {
	margin-bottom: 1em;
}

.code pre {
	background-color: #ffe;
	margin: 0.5em 0;
	padding: 0.5em;
	line-height: 125%;
	border: 1px solid #eee;
}

.source .file {
	margin-bottom: 1em;
	font-weight: bold;
}

.traces {
	margin: 2em 0;
}

.trace {
	margin: 0.5em 0;
	padding: 0.5em;
}

.trace.app {
	border: 1px dashed #c00;
}

.trace .number {
	text-align: right;
	width: 2em;
	padding: 0.5em;
}

.trace .content {
	padding: 0.5em;
}

.trace .plus,
.trace .minus {
	display:inline;
	vertical-align:middle;
	text-align:center;
	border:1px solid #000;
	color:#000;
	font-size:10px;
	line-height:10px;
	margin:0;
	padding:0 1px;
	width:10px;
	height:10px;
}

.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
	display: none;
}

.trace-file {
	cursor: pointer;
	padding: 0.2em;
}

.trace-file:hover {
	background: #f0ffff;
}
/*]]>*/
</style>
</head>

<body>
<div class="container">
	<h1>PHP warning</h1>

	<p class="message">
		A non-numeric value encountered	</p>

	<div class="source">
		<p class="file">/mnt/data/shnoulle/nginx/www/3LTS/application/helpers/qanda_helper.php(4074)</p>
		<div class="code"><pre><span class="ln">4062</span>         $labelcode[] = $lrow-&gt;code;
<span class="ln">4063</span>     }
<span class="ln">4064</span> 
<span class="ln">4065</span>     // No-dropdown layout
<span class="ln">4066</span>     if ($useDropdownLayout === false &amp;&amp; count($lresult) &gt; 0) {
<span class="ln">4067</span>         if (trim($aQuestionAttributes['answer_width']) != '') {
<span class="ln">4068</span>             $answerwidth = trim($aQuestionAttributes['answer_width']);
<span class="ln">4069</span>             $defaultWidth = false;
<span class="ln">4070</span>         } else {
<span class="ln">4071</span>             $answerwidth = 33;
<span class="ln">4072</span>             $defaultWidth = true;
<span class="ln">4073</span>         }
<span class="error"><span class="ln error-ln">4074</span>         $columnswidth = 100 - $answerwidth;
</span><span class="ln">4075</span>         $iCount = intval(Question::model()-&gt;count("parent_qid=:qid and question like :separator", array(':qid'=&gt;$ia[0], ":separator"=&gt;'%|%')));
<span class="ln">4076</span>         if ($iCount &gt; 0) {
<span class="ln">4077</span>             $right_exists = true;
<span class="ln">4078</span>             /* put the right answer to same width : take place in answer width only if it's not default */
<span class="ln">4079</span>             if ($defaultWidth) {
<span class="ln">4080</span>                 $columnswidth -= $answerwidth;
<span class="ln">4081</span>             } else {
<span class="ln">4082</span>                 $answerwidth = $answerwidth / 2;
<span class="ln">4083</span>             }
<span class="ln">4084</span>         } else {
<span class="ln">4085</span>             $right_exists = false;
<span class="ln">4086</span>         }
</pre></div>	</div>

	<div class="traces">
		<h2>Stack Trace</h2>
				<table style="width:100%;">
						<tbody><tr class="trace app expanded">
			<td class="number">
				#0			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/application/helpers/qanda_helper.php(239): <strong>do_array</strong>(array("32089", "275575X2081X32089", "Q00", "A first example question. Please answer this question:", ...))				</div>

				<div class="code"><pre><span class="ln">234</span>         case 'E': //ARRAY (Increase/Same/Decrease) radio-buttons
<span class="ln">235</span>             $values = do_array_increasesamedecrease($ia);
<span class="ln">236</span>             break;
<span class="ln">237</span> 
<span class="ln">238</span>         case 'F': //ARRAY (Flexible) - Row Format
<span class="error"><span class="ln error-ln">239</span>             $values = do_array($ia);
</span><span class="ln">240</span>             break;
<span class="ln">241</span> 
<span class="ln">242</span>         case 'H': //ARRAY (Flexible) - Column Format
<span class="ln">243</span>             $values = do_arraycolumns($ia);
<span class="ln">244</span>             break;
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#1			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/application/helpers/SurveyRuntimeHelper.php(177): <strong>retrieveAnswers</strong>(array("32089", "275575X2081X32089", "Q00", "A first example question. Please answer this question:", ...))				</div>

				<div class="code"><pre><span class="ln">172</span>                         }
<span class="ln">173</span> 
<span class="ln">174</span>                         //Get the answers/inputnames
<span class="ln">175</span>                         // TMSW - can content of retrieveAnswers() be provided by LEM?  Review scope of what it provides.
<span class="ln">176</span>                         // TODO - retrieveAnswers is slow - queries database separately for each question. May be fixed in _CI or _YII ports, so ignore for now
<span class="error"><span class="ln error-ln">177</span>                         list($plus_qanda, $plus_inputnames) = retrieveAnswers($ia);
</span><span class="ln">178</span> 
<span class="ln">179</span>                         if ($plus_qanda) {
<span class="ln">180</span>                             $plus_qanda[] = $ia[4];
<span class="ln">181</span>                             $plus_qanda[] = $ia[6]; // adds madatory identifyer for adding mandatory class to question wrapping div
<span class="ln">182</span> 
</pre></div>			</td>
		</tr>
						<tr class="trace app expanded">
			<td class="number">
				#2			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/application/controllers/survey/index.php(590): <strong>SurveyRuntimeHelper</strong>-&gt;<strong>run</strong>("275575",
 array("surveyid" =&gt; "275575", "thissurvey" =&gt; array("htmlemail" 
=&gt; "Y", "format" =&gt; "G", "template" =&gt; "skelvanilla", 
"language" =&gt; "en", ...), "thisstep" =&gt; "0", "tokensexist" =&gt; 
0, ...))				</div>

				<div class="code"><pre><span class="ln">585</span>         unset($redata);
<span class="ln">586</span>         $redata = compact(array_keys(get_defined_vars()));
<span class="ln">587</span>         Yii::import('application.helpers.SurveyRuntimeHelper');
<span class="ln">588</span>         $tmp = new SurveyRuntimeHelper();
<span class="ln">589</span>         // try {
<span class="error"><span class="ln error-ln">590</span>             $tmp-&gt;run($surveyid, $redata);
</span><span class="ln">591</span>         // } catch (WrongTemplateVersionException $ex) {
<span class="ln">592</span>         //     echo $ex-&gt;getMessage();
<span class="ln">593</span>         // }
<span class="ln">594</span>     }
<span class="ln">595</span> 
</pre></div>			</td>
		</tr>
						<tr class="trace app collapsed">
			<td class="number">
				#3			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/application/controllers/survey/index.php(24): <strong>index</strong>-&gt;<strong>action</strong>()				</div>

				<div class="code"><pre><span class="ln">19</span>     public $oTemplate;
<span class="ln">20</span> 
<span class="ln">21</span>     public function run()
<span class="ln">22</span>     {
<span class="ln">23</span>         useFirebug();
<span class="error"><span class="ln error-ln">24</span>         $this-&gt;action();
</span><span class="ln">25</span>     }
<span class="ln">26</span> 
<span class="ln">27</span>     public function action()
<span class="ln">28</span>     {
<span class="ln">29</span>         global $surveyid;
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#4			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/framework/web/actions/CAction.php(76): <strong>index</strong>-&gt;<strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">71</span>     {
<span class="ln">72</span>         $method=new ReflectionMethod($this, 'run');
<span class="ln">73</span>         if($method-&gt;getNumberOfParameters()&gt;0)
<span class="ln">74</span>             return $this-&gt;runWithParamsInternal($this, $method, $params);
<span class="ln">75</span> 
<span class="error"><span class="ln error-ln">76</span>         $this-&gt;run();
</span><span class="ln">77</span>         return true;
<span class="ln">78</span>     }
<span class="ln">79</span> 
<span class="ln">80</span>     /**
<span class="ln">81</span>      * Executes a method of an object with the supplied named parameters.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#5			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/framework/web/CController.php(308): <strong>CAction</strong>-&gt;<strong>runWithParams</strong>(array("r" =&gt; "survey/index", "sid" =&gt; "275575"))				</div>

				<div class="code"><pre><span class="ln">303</span>     {
<span class="ln">304</span>         $priorAction=$this-&gt;_action;
<span class="ln">305</span>         $this-&gt;_action=$action;
<span class="ln">306</span>         if($this-&gt;beforeAction($action))
<span class="ln">307</span>         {
<span class="error"><span class="ln error-ln">308</span>             if($action-&gt;runWithParams($this-&gt;getActionParams())===false)
</span><span class="ln">309</span>                 $this-&gt;invalidActionParams($action);
<span class="ln">310</span>             else
<span class="ln">311</span>                 $this-&gt;afterAction($action);
<span class="ln">312</span>         }
<span class="ln">313</span>         $this-&gt;_action=$priorAction;
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#6			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/framework/web/CController.php(286): <strong>CController</strong>-&gt;<strong>runAction</strong>(index)				</div>

				<div class="code"><pre><span class="ln">281</span>      * @see runAction
<span class="ln">282</span>      */
<span class="ln">283</span>     public function runActionWithFilters($action,$filters)
<span class="ln">284</span>     {
<span class="ln">285</span>         if(empty($filters))
<span class="error"><span class="ln error-ln">286</span>             $this-&gt;runAction($action);
</span><span class="ln">287</span>         else
<span class="ln">288</span>         {
<span class="ln">289</span>             $priorAction=$this-&gt;_action;
<span class="ln">290</span>             $this-&gt;_action=$action;
<span class="ln">291</span>             CFilterChain::create($this,$action,$filters)-&gt;run();
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#7			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/framework/web/CController.php(265): <strong>CController</strong>-&gt;<strong>runActionWithFilters</strong>(index, array())				</div>

				<div class="code"><pre><span class="ln">260</span>         {
<span class="ln">261</span>             if(($parent=$this-&gt;getModule())===null)
<span class="ln">262</span>                 $parent=Yii::app();
<span class="ln">263</span>             if($parent-&gt;beforeControllerAction($this,$action))
<span class="ln">264</span>             {
<span class="error"><span class="ln error-ln">265</span>                 $this-&gt;runActionWithFilters($action,$this-&gt;filters());
</span><span class="ln">266</span>                 $parent-&gt;afterControllerAction($this,$action);
<span class="ln">267</span>             }
<span class="ln">268</span>         }
<span class="ln">269</span>         else
<span class="ln">270</span>             $this-&gt;missingAction($actionID);
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#8			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/framework/web/CWebApplication.php(282): <strong>CController</strong>-&gt;<strong>run</strong>("index")				</div>

				<div class="code"><pre><span class="ln">277</span>         {
<span class="ln">278</span>             list($controller,$actionID)=$ca;
<span class="ln">279</span>             $oldController=$this-&gt;_controller;
<span class="ln">280</span>             $this-&gt;_controller=$controller;
<span class="ln">281</span>             $controller-&gt;init();
<span class="error"><span class="ln error-ln">282</span>             $controller-&gt;run($actionID);
</span><span class="ln">283</span>             $this-&gt;_controller=$oldController;
<span class="ln">284</span>         }
<span class="ln">285</span>         else
<span class="ln">286</span>             throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span>                 array('{route}'=&gt;$route===''?$this-&gt;defaultController:$route)));
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#9			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-&gt;<strong>runController</strong>("survey/index")				</div>

				<div class="code"><pre><span class="ln">136</span>             foreach(array_splice($this-&gt;catchAllRequest,1) as $name=&gt;$value)
<span class="ln">137</span>                 $_GET[$name]=$value;
<span class="ln">138</span>         }
<span class="ln">139</span>         else
<span class="ln">140</span>             $route=$this-&gt;getUrlManager()-&gt;parseUrl($this-&gt;getRequest());
<span class="error"><span class="ln error-ln">141</span>         $this-&gt;runController($route);
</span><span class="ln">142</span>     }
<span class="ln">143</span> 
<span class="ln">144</span>     /**
<span class="ln">145</span>      * Registers the core application components.
<span class="ln">146</span>      * This method overrides the parent implementation by registering additional core components.
</pre></div>			</td>
		</tr>
						<tr class="trace core collapsed">
			<td class="number">
				#10			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/framework/base/CApplication.php(185): <strong>CWebApplication</strong>-&gt;<strong>processRequest</strong>()				</div>

				<div class="code"><pre><span class="ln">180</span>     public function run()
<span class="ln">181</span>     {
<span class="ln">182</span>         if($this-&gt;hasEventHandler('onBeginRequest'))
<span class="ln">183</span>             $this-&gt;onBeginRequest(new CEvent($this));
<span class="ln">184</span>         register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">185</span>         $this-&gt;processRequest();
</span><span class="ln">186</span>         if($this-&gt;hasEventHandler('onEndRequest'))
<span class="ln">187</span>             $this-&gt;onEndRequest(new CEvent($this));
<span class="ln">188</span>     }
<span class="ln">189</span> 
<span class="ln">190</span>     /**
</pre></div>			</td>
		</tr>
						<tr class="trace app collapsed">
			<td class="number">
				#11			</td>
			<td class="content">
				<div class="trace-file">
											<div class="plus">+</div>
						<div class="minus">–</div>
										&nbsp;/mnt/data/shnoulle/nginx/www/3LTS/index.php(194): <strong>CApplication</strong>-&gt;<strong>run</strong>()				</div>

				<div class="code"><pre><span class="ln">189</span> require_once APPPATH . 'core/LSYii_Application' . EXT;
<span class="ln">190</span> 
<span class="ln">191</span> $config = require_once(APPPATH . 'config/internal' . EXT);
<span class="ln">192</span> 
<span class="ln">193</span> Yii::$enableIncludePath = false;
<span class="error"><span class="ln error-ln">194</span> Yii::createApplication('LSYii_Application', $config)-&gt;run();
</span><span class="ln">195</span> 
<span class="ln">196</span> /* End of file index.php */
<span class="ln">197</span> /* Location: ./index.php */
</pre></div>			</td>
		</tr>
				</tbody></table>
	</div>

	<div class="version">
		2020-09-10 15:24:33 nginx/1.18.0 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.22-dev	</div>
</div>

<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");

var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
	if(traceReg.test(e[j].className)){
		e[j].onclick = function(){
			var trace = this.parentNode.parentNode;
			if(collapsedReg.test(trace.className))
				trace.className = trace.className.replace("collapsed", "expanded");
			else
				trace.className = trace.className.replace("expanded", "collapsed");
		}
	}
}
/*]]>*/
</script>



<div id="grammalecte_menu_main_button_shadow_host" style="width: 0px; height: 0px;"></div></body><script src="PHP%20warning_fichiers/api.js"></script></html>
PHP warning.html (19,924 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)3.23.3
I will donate to the project if issue is resolvedNo
Browsernot relevant ?
Database type & versionnot relevant?
Server OS (if known)fedora/linux
Webserver software & version (if known)nginx
PHP Version7.4.9

Relationships

related to 16758 closedDenisChenu PHP7.1 + debug set : PHP Warning A non-numeric value encountered 

Activities

DenisChenu

DenisChenu

2020-09-10 17:41

developer   ~59770

Please : https://github.com/LimeSurvey/LimeSurvey/pull/1585

Follow fix process …

DenisChenu

DenisChenu

2020-10-19 19:40

developer   ~60276

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=30625

lime_release_bot

lime_release_bot

2020-10-26 08:20

administrator   ~60410

Fixed in Release 3.24.3+201027

Related Changesets

LimeSurvey: 3.x-LTS 8e3113da

2020-10-19 19:40:44

DenisChenu


Committer: GitHub Details Diff
Fixed issue 16659: PHP7.1 + debug set : PHP Warning A non-numeric value encountered (#1585)

Dev: check ctype_digit(trim($aQuestionAttributes['answer_width']))
Dev: allow more than 100 … but like 2.73 and PHP5.3
Affected Issues
16659
mod - application/helpers/qanda_helper.php Diff File

Issue History

Date Modified Username Field Change
2020-09-10 17:32 DenisChenu New Issue
2020-09-10 17:32 DenisChenu Status new => assigned
2020-09-10 17:32 DenisChenu Assigned To => DenisChenu
2020-09-10 17:32 DenisChenu File Added: limesurvey_survey_nonwellnumeric.lss
2020-09-10 17:32 DenisChenu File Added: PHP warning.html
2020-09-10 17:40 DenisChenu Assigned To DenisChenu =>
2020-09-10 17:41 DenisChenu Assigned To => cdorin
2020-09-10 17:41 DenisChenu Status assigned => ready for testing
2020-09-10 17:41 DenisChenu Note Added: 59770
2020-10-19 19:40 DenisChenu Changeset attached => LimeSurvey 3.x-LTS 8e3113da
2020-10-19 19:40 DenisChenu Note Added: 60276
2020-10-19 19:40 DenisChenu Assigned To cdorin => DenisChenu
2020-10-19 19:40 DenisChenu Resolution open => fixed
2020-10-20 08:38 DenisChenu Issue cloned: 16758
2020-10-20 08:39 DenisChenu Relationship added related to 16758
2020-10-20 09:15 DenisChenu Status ready for testing => resolved
2020-10-20 09:15 DenisChenu Fixed in Version => 3.24.2
2020-10-26 08:20 lime_release_bot Note Added: 60410
2020-10-26 08:20 lime_release_bot Status resolved => closed