Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
15919Bug reportsSurvey editingpublic2021-03-29 12:39
Reportertpartner Assigned Togabrieljenik  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version4.1.7 
Target Version4.0.xFixed in Version4.4.15 
Summary15919: Cannot import custom question theme based on an array question
DescriptionWhen I try importing the attached question theme (which works in 3.x), I get an error:

file_get_contents(C:\xampp\htdocs\limeSurvey4x\upload/themes/question/Adjustable-Semantic-Diff-Array/survey/questions/answer/array\config.xml): failed to open stream: No such file or directory

This appears to be because the system is not looking for the full path to find the config file in an array question which is like this (from 3.x and also the path in the 4.x views):

/upload/themes/question/yourThemeName/survey/questions/answer/**arrays**/array/config.xml
TagsNo tags attached.
Complete LimeSurvey version number (& build)4.1.7
I will donate to the project if issue is resolvedNo
BrowserN/A
Database & DB-Versionmysqlnd 5.0.12
Server OS (if known)Windows 10
Webserver software & version (if known)Apache/2.4.39 (Win64)
PHP Version7.3.7

Relationships

related to 17192 assignedollehar Question theme import doesn't respect uploaddir config, 

Activities

tpartner

tpartner

2020-02-26 18:56

developer  

capture_8.png (16,635 bytes)   
capture_8.png (16,635 bytes)   
tpartner

tpartner

2020-02-26 18:59

developer  

capture_9.png (44,632 bytes)   
capture_9.png (44,632 bytes)   
DenisChenu

DenisChenu

2020-02-27 08:06

developer   ~56213

Same QuestionTheme work in 3.X ?
DenisChenu

DenisChenu

2020-04-18 11:40

developer   ~57238

When try to import : «Le fichier de configuration upload/themes/question/Adjustable-Semantic-Diff-Array/survey/questions/answer/arrays/config.xml est introuvable ou ne peut être lu.» i check on 3.X how it's done
DenisChenu

DenisChenu

2020-04-18 11:48

developer   ~57239

In 3.X : we use QuestionTemplate : https://github.com/LimeSurvey/LimeSurvey/blob/f8f28717275c2aec69915d3c2156087003deb28c/application/models/QuestionTemplate.php#L556

in 4.X : we use QuestionTheme ? But leave QuestionTemplate model ?
Why ?
Why update and leave old files ?

Give me one good reason ....
DenisChenu

DenisChenu

2020-04-18 11:51

developer   ~57240

After upload ...
tpartner

tpartner

2020-04-18 12:47

developer   ~57243

Last edited: 2020-04-18 13:57

View 2 revisions

Yes, that is exactly as I described in the original description. I think it's an issue with the file path.

DenisChenu

DenisChenu

2020-04-19 11:55

developer   ~57248

I know @tparner, just look around to see how to fix :)
tpartner

tpartner

2021-02-21 17:31

developer   ~62426

Still a crash a year later...
gabrieljenik

gabrieljenik

2021-03-10 16:19

manager   ~63014

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1799

I think the import results screen could need some update, as it was based for a single theme import.
Could be another story? :)
DenisChenu

DenisChenu

2021-03-10 16:23

developer   ~63016

@gabrieljenik

Then questions/answer/(.*)/config.xml is allowed ?
You think we can use questions/answer/mypluginname/config.xml ?
gabrieljenik

gabrieljenik

2021-03-10 16:36

manager   ~63018

You shouldn't I guess.
I believe it will throw this error: Question theme could not be converted to LimeSurvey 4 standard. Reason: No matching core theme with the name %s could be found
ollehar

ollehar

2021-03-11 12:32

administrator   ~63297

"Template 'Adjustable-Semantic-Diff-Array' does already exist."

Shouldn't it be able to update a theme by installing a later version of same theme?
DenisChenu

DenisChenu

2021-03-11 12:35

developer   ~63298

> Shouldn't it be able to update a theme by installing a later version of same theme?

Currently no, like Survey theme https://bugs.limesurvey.org/view.php?id=8426
ollehar

ollehar

2021-03-11 12:57

administrator   ~63299

Hm.
ollehar

ollehar

2021-03-11 13:00

administrator   ~63301

Pretty serious drawback. :/
gabrieljenik

gabrieljenik

2021-03-18 15:33

manager   ~63432

New update uploaded.
The theme controller should probably be split: one controller for question, another one for themes. At least from my point of view. Or at least some actions in there.
gabrieljenik

gabrieljenik

2021-03-18 15:36

manager   ~63433

Created 17192 upon a comment from @ollehar
gabrieljenik

gabrieljenik

2021-03-25 15:05

manager   ~63610

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31385
tpartner

tpartner

2021-03-25 15:29

developer   ~63611

Can't test - see my last comment in https://bugs.limesurvey.org/view.php?id=17121

Related Changesets

LimeSurvey: master 6ed4e914

2021-03-25 14:46:43

gabrieljenik


Committer: GitHub Details Diff
Fixed bug 15919: Cannot import custom question theme based on an array question (#1799) Affected Issues
15919
mod - application/controllers/admin/themes.php Diff File
mod - application/models/QuestionTheme.php Diff File
mod - application/views/admin/themes/importuploaded_view.php Diff File

Issue History

Date Modified Username Field Change
2020-02-26 18:56 tpartner New Issue
2020-02-26 18:56 tpartner Status new => assigned
2020-02-26 18:56 tpartner Assigned To => cdorin
2020-02-26 18:56 tpartner File Added: Adjustable-Semantic-Diff-Array.zip
2020-02-26 18:56 tpartner File Added: capture_8.png
2020-02-26 18:57 tpartner Description Updated View Revisions
2020-02-26 18:57 tpartner Description Updated View Revisions
2020-02-26 18:58 tpartner Description Updated View Revisions
2020-02-26 18:59 tpartner File Added: capture_9.png
2020-02-26 19:00 tpartner Description Updated View Revisions
2020-02-26 19:05 tpartner Summary Cannot import custom question theme based on a array question => Cannot import custom question theme based on an array question
2020-02-27 08:06 DenisChenu Note Added: 56213
2020-04-17 21:51 cdorin Assigned To cdorin =>
2020-04-17 21:51 cdorin Priority none => normal
2020-04-17 21:51 cdorin Status assigned => confirmed
2020-04-17 21:51 cdorin Zoho Sprints => |Yes|
2020-04-17 21:51 swendrich Zoho Sprints ID => 14469000000052013
2020-04-18 11:40 DenisChenu Note Added: 57238
2020-04-18 11:48 DenisChenu Note Added: 57239
2020-04-18 11:51 DenisChenu File Added: Capture d’écran du 2020-04-18 11-51-27.png
2020-04-18 11:51 DenisChenu Note Added: 57240
2020-04-18 12:47 tpartner Note Added: 57243
2020-04-18 13:57 tpartner Note Edited: 57243 View Revisions
2020-04-19 11:55 DenisChenu Note Added: 57248
2021-02-21 17:31 tpartner Note Added: 62426
2021-02-23 15:43 gabrieljenik Assigned To => gabrieljenik
2021-02-23 15:43 gabrieljenik Status confirmed => assigned
2021-03-10 16:19 gabrieljenik Note Added: 63014
2021-03-10 16:23 DenisChenu Note Added: 63016
2021-03-10 16:36 gabrieljenik Note Added: 63018
2021-03-11 12:25 ollehar Status assigned => testing
2021-03-11 12:32 ollehar Note Added: 63297
2021-03-11 12:35 DenisChenu Note Added: 63298
2021-03-11 12:57 ollehar Note Added: 63299
2021-03-11 13:00 ollehar Note Added: 63301
2021-03-18 15:33 gabrieljenik Note Added: 63432
2021-03-18 15:35 gabrieljenik Issue cloned: 17192
2021-03-18 15:35 gabrieljenik Relationship added related to 17192
2021-03-18 15:36 gabrieljenik Note Added: 63433
2021-03-25 14:47 c_schmitz Status testing => resolved
2021-03-25 14:47 c_schmitz Resolution open => fixed
2021-03-25 15:05 gabrieljenik Changeset attached => LimeSurvey master 6ed4e914
2021-03-25 15:05 gabrieljenik Note Added: 63610
2021-03-25 15:29 tpartner Note Added: 63611
2021-03-29 12:39 c_schmitz Fixed in Version => 4.4.15
2021-03-29 12:39 c_schmitz Status resolved => closed