Relationship Graph

Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

IDProjectCategoryView StatusLast Update
15749Bug reportsUser / Groups / Rolespublic2020-07-24 10:19
ReporterMazi Assigned Tocdorin  
PrioritynoneSeverityminor 
Status resolvedResolutionopen 
Product Version4.0.0-RC12 
Summary15749: Adding new users as superadmins doesn't check all boxes
Description

When adding a new admin user and checking the superadmin checkboxes, other checkboxes are not checked automatically like it was done at LS 3.x

Steps To Reproduce

Createb a new admin user.
Assign superadmin rights

TagsNo tags attached.
Complete LimeSurvey version number (& build)Version 4.0.1+200120
I will donate to the project if issue is resolvedNo
BrowserChrome
Database & DB-VersionMySQL
Server OS (if known)Ubuntu 18
Webserver software & version (if known)Apache 2
PHP Version7.2.26

Relationships

related to 16507 confirmed Mass permissions are not being saved 

Activities

DenisChenu

DenisChenu

2020-06-16 14:26

developer   ~58305

My opinion : it was not mandatory here.

If final rights are OK , why check the other ?
And more : show other checkbox as Indeterminate if : uszer have right, but right is given by another right seems the best solution.

In 3.X : i hate all checkbox was unchecked when deactivate superadmin …

gabrieljenik

gabrieljenik

2020-07-07 14:31

partner   ~58742

Last edited: 2020-07-24 10:19

@mazi what is you expected behaviour? All should be checked?

I agree with Denis that "it was not mandatory here."
We could add some legend to explain more about not being mandatory.
The problem about your comment, Denis, is that after saving, all checkboxes are checked, creating some confusion.

My suggestion, just check all and keep status quo, at least on this ticket.

Mazi

Mazi

2020-07-07 18:48

partner   ~58761

Last edited: 2020-07-24 10:19

Intended behavior would be the original LS3 behavior: Other checkboxes should checked automatically.

DenisChenu

DenisChenu

2020-07-08 16:02

developer   ~58794

Last edited: 2020-07-24 10:19

See usage of inderminate for checkbox in 2.6lts

If we can set indertimate if Permission come from another Permission : i think it's the best solution

gabrieljenik

gabrieljenik

2020-07-20 23:00

partner   ~59001

Last edited: 2020-07-24 10:19

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1489

Original LS3 behavior implemented: Other checkboxes should checked automatically.

There was a missmatch when applying selection queries.
Mass permissions are not working. Will create a new ticket.

sushmanadendla

sushmanadendla

2020-07-21 11:23

manager   ~59014

Last edited: 2020-07-24 10:19

Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, working as expected. Please refer the attachment for more details.

gabrieljenik

gabrieljenik

2020-07-23 18:55

partner   ~59063

Last edited: 2020-07-24 10:19

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30303

Related Changesets

LimeSurvey: master 064663cb

2020-07-20 22:51:35

gabrieljenik

Details Diff
Fixed Issue 15749 - Adding new users as superadmins doesn't check all boxes

Original LS3 behavior: Other checkboxes should checked automatically.
Affected Issues
15749
mod - assets/packages/usermanagement/js/usermanagement.js Diff File

LimeSurvey: master 8dcea156

2020-07-23 18:55:41

eddylackmann


Committer: GitHub Details Diff
Merge pull request #1489 from gabrieljenik/bug/15749-Adding-new-users-as-superadmins-doesn't-check-all-boxes

Fixed Issue 15749 - Adding new users as superadmins doesn't check all boxes
Affected Issues
15749
mod - assets/packages/usermanagement/js/usermanagement.js Diff File

Issue History

Date Modified Username Field Change
2020-01-21 15:36 Mazi New Issue
2020-01-22 16:09 cdorin Assigned To => cdorin
2020-01-22 16:09 cdorin Status new => assigned
2020-06-16 14:26 DenisChenu Note Added: 58305
2020-07-07 14:31 gabrieljenik Note Added: 58742
2020-07-07 18:48 Mazi Note Added: 58761
2020-07-08 16:02 DenisChenu Note Added: 58794
2020-07-08 16:02 DenisChenu File Added: Capture d’écran du 2020-07-08 16-00-39.png
2020-07-08 16:02 DenisChenu File Added: Capture d’écran du 2020-07-08 16-00-48.png
2020-07-20 23:00 gabrieljenik Note Added: 59001
2020-07-20 23:08 gabrieljenik Relationship added related to 16507
2020-07-21 11:23 sushmanadendla Note Added: 59014
2020-07-21 11:23 sushmanadendla File Added: 15749_SuperadminCheckbox.png
2020-07-23 18:55 eddylackmann Changeset attached => LimeSurvey master 8dcea156
2020-07-23 18:55 gabrieljenik Changeset attached => LimeSurvey master 064663cb
2020-07-23 18:55 gabrieljenik Note Added: 59063
2020-07-24 10:19 swendrich Status assigned => resolved