View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
09454Bug reportsSurvey participants (Tokens)public2015-06-12 12:41
Reportermas_carpone Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Summary09454: Token edit fails after mandatory have been added (and left blank)
Description

When a mandatory token field is added - tokens that already existed can no longer be edited unless the mandatory field is also "filled in"

Steps To Reproduce

Create a survey with a token table.
Create a token.
Add a field to the token table and make it mandatory.
Edit fields of the token (without adding any data in the mandatory field).
Validate the edits (at this point it seems the edits are taken into account)

Refresh the page: the edits are gone.

Additional Information

https://www.limesurvey.org/en/forum/installation-a-update-issues/99297-token-edit-after-adding-a-mandatory-field#116121

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)Latest downloadable version
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)Linux
Webserver software & version (if known)Will check if needed
PHP VersionWill check if needed

Users monitoring this issue

There are no users monitoring this issue.

Activities

Mazi

Mazi

2015-01-13 09:38

updater   ~31459

Tony: Can we easily provide some help via the GUI by marking mandatory cells red during editing if empty and green once data was entered?
Maybe in addition to that we can show a pop-up error message on save if a mandatory cell is empty?

tpartner

tpartner

2015-02-28 22:02

partner   ~31738

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14970

tpartner

tpartner

2015-02-28 22:07

partner   ~31739

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14971

tpartner

tpartner

2015-02-28 22:10

partner   ~31740

Mandatory attributes are now required before saving a row.

tpartner

tpartner

2015-02-28 22:43

partner   ~31741

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14972

c_schmitz

c_schmitz

2015-06-12 12:41

administrator   ~32325

2.06 Build 150612 released

Related Changesets

LimeSurvey: master 5865e810

2015-02-28 21:01:01

tpartner

Details Diff
Fixed issue 09454: Token edit fails after mandatory have been added (and left blank)
Dev Added a jqGrid "editrules" option for mandatory attributes (prevents saving the row if madatory attributes are left blank)
Affected Issues
09454
mod - application/views/admin/token/browse.php Diff File
mod - scripts/admin/tokens.js Diff File

LimeSurvey: 2.06 03bfb76a

2015-02-28 21:06:38

tpartner

Details Diff
Fixed issue 09454: Token edit fails after mandatory have been added (and left blank)
Dev Added a jqGrid "editrules" option for mandatory attributes (prevents saving the row if madatory attributes are left blank)
Affected Issues
09454
mod - application/views/admin/token/browse.php Diff File
mod - scripts/admin/tokens.js Diff File

LimeSurvey: 2.06 b89746a5

2015-02-28 21:43:51

tpartner

Details Diff
Fixed issue 09454: Token edit fails after mandatory have been added (and left blank)
Dev Forgot to use a translation variable
Affected Issues
09454
mod - application/views/admin/token/browse.php Diff File

Issue History

Date Modified Username Field Change
2015-01-12 20:16 mas_carpone New Issue
2015-01-13 09:38 Mazi Assigned To => tpartner
2015-01-13 09:38 Mazi Status new => assigned
2015-01-13 09:38 Mazi Note Added: 31459
2015-02-28 22:02 tpartner Changeset attached => LimeSurvey master 5865e810
2015-02-28 22:02 tpartner Note Added: 31738
2015-02-28 22:02 tpartner Resolution open => fixed
2015-02-28 22:07 tpartner Changeset attached => LimeSurvey 2.06 03bfb76a
2015-02-28 22:07 tpartner Note Added: 31739
2015-02-28 22:10 tpartner Note Added: 31740
2015-02-28 22:10 tpartner Status assigned => resolved
2015-02-28 22:43 tpartner Changeset attached => LimeSurvey 2.06 b89746a5
2015-02-28 22:43 tpartner Note Added: 31741
2015-06-12 12:41 c_schmitz Note Added: 32325
2015-06-12 12:41 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)