View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
09447Bug reportsSurvey participants (Tokens)public2015-06-12 12:41
ReporterDenisChenu Assigned Toaesteban  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Summary09447: Token sending email is unusuable with a lot of token
Description

With a lot of token, you see a lit of all tokan, the page start by a big list of number. This make the page very long ... long .... and again after click on next.

Additional Information

This big list is uneresting : maybe we can hide it completely. Minimu is a max heigth.

TagsNo tags attached.
Attached Files
short_implode.png (11,751 bytes)   
short_implode.png (11,751 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)150109
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2015-01-21 01:27

developer   ~31476

@aesteban : i think a global class for this type of "big list" : like the one after sending : just a "max-heigth" and an overflow-y:auto :)

aesteban

aesteban

2015-01-29 01:10

developer   ~31523

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14881

aesteban

aesteban

2015-01-29 01:15

developer   ~31524

Last edited: 2015-01-29 01:16

@DenisChenu: I hope you like this approach, this is a standard way to show very long integer lists: 1, 4, 5, 6, 9, 10, 11, 12, 13 => 1, 4-6, 10-13

Unable to merge into 2.06 because 09483 (I add this task to my TODO list)

DenisChenu

DenisChenu

2015-01-29 08:57

developer   ~31525

Hi,

For 09483 : look at https://bugs.limesurvey.org/view.php?id=9468 think it's same issue here. string(X). This must be fixed in last GIT of 2.06 ?

For the fix : i like the idea of 1-10. Why not in viewHelper for 2.06 ?

aesteban

aesteban

2015-01-29 12:00

developer   ~31535

@DenisChenu: Ok, I will put the code in viewHelper for 2.06. By the way: I changed status of 09468. I just reproduced the bug.

aesteban

aesteban

2015-01-30 16:27

developer   ~31578

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14901

aesteban

aesteban

2015-01-30 17:20

developer   ~31579

I put the code in common_helper.php because viewHelper class is not loaded from views/admin/token/remind.php and invite.php

c_schmitz

c_schmitz

2015-02-11 15:57

administrator   ~31660

Version 2.05 Build 150211 released

DenisChenu

DenisChenu

2015-03-16 10:07

developer   ~31829

Still some issue.

1st : see the screenshot, even with this system : it's too big
2nd : after sending : showing another view with same problem.

aesteban

aesteban

2015-03-16 23:52

developer   ~31833

Last edited: 2015-03-17 00:07

I'm going to replace implode by short_implode in emailpost.php and I'm going to create a new configuration param 'maxstringlengthshortimplode' to choose max string length. If this limit is exceeded, string ends with "..." (see short_implode.png)

aesteban

aesteban

2015-03-16 23:54

developer   ~31834

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15028

aesteban

aesteban

2015-03-17 00:14

developer   ~31835

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15029

c_schmitz

c_schmitz

2015-06-12 12:41

administrator   ~32324

2.06 Build 150612 released

Related Changesets

LimeSurvey: master 651cc9c4

2015-01-29 00:05:59

aesteban

Details Diff
Fixed issue 09447: Token sending email is unusuable with a lot of token Affected Issues
09447
mod - application/config/config-defaults.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/views/admin/token/email.php Diff File
mod - application/views/admin/token/remind.php Diff File

LimeSurvey: 2.06 7ff31a23

2015-01-30 15:27:17

aesteban

Details Diff
Fixed issue 09447: Token sending email is unusuable with a lot of token Affected Issues
09447
mod - application/config/config-defaults.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/views/admin/token/invite.php Diff File
mod - application/views/admin/token/remind.php Diff File

LimeSurvey: master b1318949

2015-03-16 22:48:11

aesteban

Details Diff
Fixed issue 09447: Token sending email is unusuable with a lot of token Affected Issues
09447
mod - application/config/config-defaults.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/views/admin/token/email.php Diff File
mod - application/views/admin/token/emailpost.php Diff File
mod - application/views/admin/token/remind.php Diff File

LimeSurvey: 2.06 94328a67

2015-03-16 22:48:11

aesteban

Details Diff
Fixed issue 09447: Token sending email is unusuable with a lot of token Affected Issues
09447
mod - application/config/config-defaults.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/views/admin/token/emailpost.php Diff File
mod - application/views/admin/token/invite.php Diff File
mod - application/views/admin/token/remind.php Diff File

Issue History

Date Modified Username Field Change
2015-01-09 11:52 DenisChenu New Issue
2015-01-09 11:52 DenisChenu File Added: Token_Survey_-_2015-01-09_09.54.31.png
2015-01-20 20:02 aesteban Assigned To => aesteban
2015-01-20 20:02 aesteban Status new => assigned
2015-01-21 01:27 DenisChenu Note Added: 31476
2015-01-29 01:10 aesteban Changeset attached => LimeSurvey master 651cc9c4
2015-01-29 01:10 aesteban Note Added: 31523
2015-01-29 01:10 aesteban Resolution open => fixed
2015-01-29 01:15 aesteban Note Added: 31524
2015-01-29 01:16 aesteban Note Edited: 31524
2015-01-29 01:18 aesteban Status assigned => resolved
2015-01-29 08:57 DenisChenu Note Added: 31525
2015-01-29 12:00 aesteban Note Added: 31535
2015-01-30 16:27 aesteban Changeset attached => LimeSurvey 2.06 7ff31a23
2015-01-30 16:27 aesteban Note Added: 31578
2015-01-30 17:20 aesteban Note Added: 31579
2015-02-11 15:57 c_schmitz Note Added: 31660
2015-02-11 15:57 c_schmitz Status resolved => closed
2015-03-16 10:07 DenisChenu Note Added: 31829
2015-03-16 10:07 DenisChenu Status closed => feedback
2015-03-16 10:07 DenisChenu Resolution fixed => reopened
2015-03-16 10:07 DenisChenu File Added: Capture du 2015-03-16 10:03:03.png
2015-03-16 10:07 DenisChenu File Added: Capture du 2015-03-16 10:05:30.png
2015-03-16 23:52 aesteban Note Added: 31833
2015-03-16 23:53 aesteban Status feedback => assigned
2015-03-16 23:54 aesteban Changeset attached => LimeSurvey master b1318949
2015-03-16 23:54 aesteban Note Added: 31834
2015-03-17 00:06 aesteban File Added: short_implode.png
2015-03-17 00:07 aesteban Note Edited: 31833
2015-03-17 00:14 aesteban Changeset attached => LimeSurvey 2.06 94328a67
2015-03-17 00:14 aesteban Note Added: 31835
2015-03-17 00:15 aesteban Status assigned => resolved
2015-03-17 00:15 aesteban Resolution reopened => fixed
2015-06-12 12:41 c_schmitz Note Added: 32324
2015-06-12 12:41 c_schmitz Status resolved => closed
2016-12-08 10:39 c_schmitz Category Tokens => Survey participants (Tokens)