View Issue Details

This bug affects 1 person(s).
 14
IDProjectCategoryView StatusLast Update
09207Bug reportsResponse browsingpublic2015-03-05 11:31
ReporterMazi Assigned ToDenisChenu  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.06+ 
Target Version2.06+Fixed in Version2.06+ 
Summary09207: Port new response search/filter feature to Limesurvey 2.06
Description

Since there is currently no real development taking place at the 2.1 version and switching questions to objects is delayed since months, the customer who has paid for the new search/filter responses feature is asking to port this pull request (https://github.com/LimeSurvey/LimeSurvey/pull/69), which already made it into 2.1, into the upcoming 2.06 version.

If this will take you 1-2 hours please drop me a note and I will pay for it, but we can't let generous donors wait for months. They have complained about the missing feature several times now.

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build)20140901
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMySQL 5
Server OS (if known)Ubuntu Linux
Webserver software & version (if known)Apache 2
PHP VersionPHP 5.3

Relationships

parent of 09268 closedDenisChenu Bug reports Allowed memory size on browse response JSON 
parent of 09260 closedDenisChenu Bug reports XSS in browse response 
parent of 09541 closedDenisChenu Bug reports Unable to delete or download files from browse response 
parent of 09545 closedc_schmitz Bug reports Review Upload question type 
parent of 09548 closedc_schmitz Bug reports Token quick access on Browse reponse 
has duplicate 09252 closedMazi Feature requests Admin: Browse responses: the responses can not be sorted 
child of 09333 closedc_schmitz Bug reports 2.06 - Installer stops at optional settings 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2014-09-09 12:06

administrator   ~30510

Ported what's there. Does not work completely yet mainly due to missing parts if non-anonymous tokens are activated.

Mazi

Mazi

2014-09-09 14:04

updater   ~30512

Carsten, you surely have a test survey for the non-anonymous tokens? Can you please upload it so we can do further testing?

Thanks!

c_schmitz

c_schmitz

2014-09-10 11:59

administrator   ~30519

Attached.

Mazi

Mazi

2014-09-26 11:38

updater   ~30704

Carsten, if I remember correctly you had fixed the issue with non-anonymous surveys right away, so can we close this one?

c_schmitz

c_schmitz

2014-09-26 12:40

administrator   ~30705

No, it is not fixed. As said the treatment of token fields is completely missing, even in the original patch - it needs to be coded.

DenisChenu

DenisChenu

2014-10-02 12:07

developer   ~30728

First part : fix the XSS and add complete answer : https://github.com/Shnoulle/LimeSurvey-shnoulle/commit/a499de8a5362205cb2ab6593c86a231362ac9247

And really better CSS too

DenisChenu

DenisChenu

2014-10-02 12:31

developer   ~30730

https://github.com/LimeSurvey/LimeSurvey/pull/224

c_schmitz

c_schmitz

2014-11-22 15:20

administrator   ~31039

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14638

DenisChenu

DenisChenu

2014-11-22 16:12

developer   ~31041

Last edited: 2014-11-22 16:13

This don't fix XSS ( and still a really broken CSS)

In getJson :
Undefined variable: limit (..../limesurvey_GIT/206/application/controllers/admin/responses.php:558)
Undefined variable: tokenRequest (..../limesurvey_GIT/206/application/controllers/admin/responses.php:567
Undefined variable: order (..../limesurvey_GIT/206/application/controllers/admin/responses.php:571)

But more filter : show 50 response, and search is apply only on this 50 response ....

You need to request the json each time the user make a search ....

Mazi

Mazi

2014-11-26 09:42

updater   ~31093

Hi Denis,

can you try to merge your XSS fixes?

@search limit: Do you mean that when switching the drop down for the number of to be listed answers a new query needs to be made?
Because as I see it no action is performed when changing the value at the drop down from e.g. default 25 to 100.
Or is this because my test survey has less than 25 data sets?

DenisChenu

DenisChenu

2014-11-26 10:54

developer   ~31100

Last edited: 2014-11-26 10:56

Yes, it's because your test survey is less to 25 : Add 25 answers , you see only page 1/1 : see :

OK, i review CSS and JS for XSS and better display.

PS: just take the XSS (bug 09260 http://bugs.limesurvey.org/view.php?id=9260)

DenisChenu

DenisChenu

2014-11-28 17:18

developer   ~31130

Fixed the jqgrid with ajax part : sort and filter .

But :

  • Need to fix the upload question type
  • Need to filter by token firstname/lastname (maybe adding attribute)
  • Fix the order type for some question type
  • Add the startdate lastpage etc ....
Mazi

Mazi

2014-12-22 15:05

updater   ~31331

Denis, can we close this one?

DenisChenu

DenisChenu

2014-12-22 15:09

developer   ~31333

  • Need to fix the upload question type
  • Need to filter by token firstname/lastname (maybe adding attribute)
  • Fix the order type for some question type
  • Add the startdate lastpage etc ....
DenisChenu

DenisChenu

2014-12-22 15:11

developer   ~31334

  • In 2.05 : we have startdate/lastpage. Not in 2.06
  • Upload question type are not done: did we need it like before ? Or not ? But we need to allow download single file somewhere.

2 other are more feature request

c_schmitz

c_schmitz

2015-02-02 14:08

administrator   ~31588

Unless these issues are not resolved a 2.06 makes no sense, IMHO.

DenisChenu

DenisChenu

2015-02-02 14:10

developer   ~31589

Another fix to do : Delete response line is not possible actually.

sammousa

sammousa

2015-03-01 17:21

reporter   ~31742

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14974

DenisChenu

DenisChenu

2015-03-02 09:16

developer   ~31743

Not directly related

startdate/ lastoage etc... fixed
token(s) : fixed
TODO : upload question type

Leave the "advanced search" for GSOC https://manual.limesurvey.org/Project_ideas_for_GSoC_2015#Revamp_database_grids_in_LimeSurvey

DenisChenu

DenisChenu

2015-03-04 08:22

developer   ~31757

2.05 same system is done except for http://bugs.limesurvey.org/view.php?id=9545

@MAzi : yesterday pradesh contact me by IRC, saying there are "just" the upload file system. He do this one ? (the upload question type). And make a real non broken system ?

Related Changesets

LimeSurvey: 2.06 d0690914

2014-11-22 14:20:09

c_schmitz

Details Diff
Merge pull request #239 from pradeshc/issue_9207

Fixed issue 09207
Affected Issues
09207
mod - application/controllers/admin/responses.php Diff File
mod - scripts/admin/listresponse.js Diff File

LimeSurvey: 2.06 325f4f55

2014-11-26 23:36:43

DenisChenu

Details Diff
Fixed issue 09260: XSS in browse response
Fixed issue : awfull screen for browse responses
Dev : default permission search is read (just to do : Permission::model()->hasGlobalPermission('superadmin') :) )
Dev : header and footer of jqgris is allways shown completely on screen (if you don't resize the window ?)
Dev : Use .tooltip from jquery-ui in jqgrid table : todo : test with more column ? tested with big example file
Affected Issues
09207, 09260
mod - application/controllers/admin/responses.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/models/Permission.php Diff File
mod - scripts/admin/listresponse.js Diff File
mod - styles/adminstyle.css Diff File

LimeSurvey: 2.06 ba148308

2014-11-28 15:33:54

DenisChenu

Details Diff
Fixed issue 09268: Allowed memory size on browse response JSON or Not all response are shown
Dev: adding quick filter and sort
Dev: TODO : adding filter/sort by firstname/lastname
Dev: TODO : add the lastpage/startdate/timestamp
Dev: Fix upload file question type
Affected Issues
09207, 09268
mod - application/controllers/admin/responses.php Diff File
mod - scripts/admin/listresponse.js Diff File

LimeSurvey: 2.06 66faf530

2015-02-28 16:46:51

DenisChenu

Details Diff
Fixed issue : Allow filter by token information in response table
Dev: allow gris resize only heigth, width is already fixed
Dev: Move id + lastpage at start of response table
Affected Issues
09207
mod - application/controllers/admin/responses.php Diff File
mod - scripts/admin/listresponse.js Diff File
mod - styles/adminstyle.css Diff File

LimeSurvey: 2.06 95605737

2015-02-28 17:03:04

DenisChenu

Details Diff
Dev: fixed allow filter by token Affected Issues
09207
mod - application/controllers/admin/responses.php Diff File

LimeSurvey: 2.06 cd5709b3

2015-03-01 12:16:58

DenisChenu

Details Diff
Dev: Fixed issue : Remove token information from browse table Affected Issues
09207, 09548
mod - application/controllers/admin/responses.php Diff File

LimeSurvey: 2.06 8fcddcae

2015-03-01 16:15:35

sammousa

Details Diff
Fixed incorrect URL in response browse, could be related to / fix for 09207 Affected Issues
09207
mod - application/views/admin/responses/listResponses_view.php Diff File

Issue History

Date Modified Username Field Change
2014-09-03 12:15 Mazi New Issue
2014-09-03 12:15 Mazi Status new => assigned
2014-09-03 12:15 Mazi Assigned To => c_schmitz
2014-09-09 12:05 c_schmitz Assigned To c_schmitz => Mazi
2014-09-09 12:06 c_schmitz Note Added: 30510
2014-09-09 14:04 Mazi Assigned To Mazi => c_schmitz
2014-09-09 14:04 Mazi Note Added: 30512
2014-09-10 11:59 c_schmitz File Added: survey_archive_357511.lsa
2014-09-10 11:59 c_schmitz Assigned To c_schmitz => Mazi
2014-09-10 11:59 c_schmitz Note Added: 30519
2014-09-26 11:37 Mazi Assigned To Mazi => c_schmitz
2014-09-26 11:38 Mazi Note Added: 30704
2014-09-26 12:40 c_schmitz Note Added: 30705
2014-09-26 12:41 c_schmitz Assigned To c_schmitz => Mazi
2014-09-26 21:38 Mazi View Status private => public
2014-09-27 20:49 Mazi View Status public => private
2014-10-02 10:40 DenisChenu Relationship added parent of 09268
2014-10-02 10:40 Mazi Relationship added related to 09260
2014-10-02 10:41 DenisChenu Relationship replaced parent of 09260
2014-10-02 10:42 Mazi Product Version 2.05+ => 2.06+
2014-10-02 12:07 DenisChenu Note Added: 30728
2014-10-02 12:31 DenisChenu Note Added: 30730
2014-10-07 09:01 DenisChenu Relationship added has duplicate 09252
2014-11-12 20:53 Mazi Relationship added child of 09333
2014-11-22 15:20 c_schmitz Changeset attached => LimeSurvey 2.06 d0690914
2014-11-22 15:20 c_schmitz Note Added: 31039
2014-11-22 15:20 c_schmitz Assigned To Mazi => c_schmitz
2014-11-22 15:20 c_schmitz Resolution open => fixed
2014-11-22 15:42 c_schmitz Assigned To c_schmitz => Mazi
2014-11-22 16:12 DenisChenu Note Added: 31041
2014-11-22 16:13 DenisChenu Note Edited: 31041
2014-11-22 16:13 DenisChenu Note Edited: 31041
2014-11-26 09:36 Mazi View Status private => public
2014-11-26 09:37 Mazi File Deleted: survey_archive_357511.lsa
2014-11-26 09:37 Mazi Assigned To Mazi => DenisChenu
2014-11-26 09:42 Mazi Note Added: 31093
2014-11-26 10:54 DenisChenu Note Added: 31100
2014-11-26 10:55 DenisChenu Assigned To DenisChenu => Mazi
2014-11-26 10:56 DenisChenu Note Edited: 31100
2014-11-28 17:18 DenisChenu Note Added: 31130
2014-12-22 15:05 Mazi Assigned To Mazi => DenisChenu
2014-12-22 15:05 Mazi Note Added: 31331
2014-12-22 15:09 DenisChenu Note Added: 31333
2014-12-22 15:09 DenisChenu Assigned To DenisChenu => Mazi
2014-12-22 15:11 DenisChenu Note Added: 31334
2014-12-22 15:12 DenisChenu Changeset attached => LimeSurvey 2.06 ba148308
2014-12-22 15:13 DenisChenu Changeset attached => LimeSurvey 2.06 325f4f55
2015-02-02 14:08 c_schmitz Note Added: 31588
2015-02-02 14:10 DenisChenu Note Added: 31589
2015-03-01 17:21 sammousa Changeset attached => LimeSurvey 2.06 8fcddcae
2015-03-01 17:21 sammousa Note Added: 31742
2015-03-01 17:21 sammousa Assigned To Mazi => sammousa
2015-03-02 09:16 DenisChenu Note Added: 31743
2015-03-02 09:16 DenisChenu Changeset attached => LimeSurvey 2.06 cd5709b3
2015-03-02 09:16 DenisChenu Changeset attached => LimeSurvey 2.06 95605737
2015-03-02 09:16 DenisChenu Changeset attached => LimeSurvey 2.06 66faf530
2015-03-02 11:03 DenisChenu Relationship added parent of 09541
2015-03-04 08:20 DenisChenu Relationship added parent of 09545
2015-03-04 08:22 DenisChenu Note Added: 31757
2015-03-04 12:35 DenisChenu Relationship added parent of 09548
2015-03-05 11:31 c_schmitz Status assigned => closed
2015-03-05 11:31 c_schmitz Assigned To sammousa => DenisChenu
2015-03-05 11:31 c_schmitz Fixed in Version => 2.06+