View Issue Details

This bug affects 1 person(s).
 16
IDProjectCategoryView StatusLast Update
07733Bug reportsRemoteControlpublic2013-10-07 15:44
Reportergabrieljenik Assigned Totrougakoss  
PriorityurgentSeverityblock 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary07733: invite_participants method throws exception when some emails are registered
Description

invite_participants throws the following exceptions.

Exception 0: 'Incorrect response id (request id: 1, response id: )' in /home1/onetwqd8/public_html/bkevaluacion360-com-ar/ls/admin/BK/jsonRPCClient.php(152)

The method works fine until some wrong emails are registered as "noralua@gmail.com." or "" or " ".

The error also appears

Steps To Reproduce

1 - Create a new token with an invalid email, as "" or "noralua@gmail.com."
2 - Execute the invite_participants API to that survey.

TagsNo tags attached.
Bug heat16
Complete LimeSurvey version number (& build)130325
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5.5.30-log
Server OS (if known)linux
Webserver software & version (if known)Apache version 2.2.23
PHP Version5.3.22

Relationships

has duplicate 07880 closedc_schmitz invite_participants will break when a token contains an invalid email address 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2013-04-04 15:50

manager   ~24909

I think one of the problems is that the API is not filtering bad emails, as when the "sent invites" command is launched from the admin panel.

Also, I think that exceptions generated are not being caught in the API as they are caught when the "sent invites" command is launched from the admin panel.

At last, It would be great if that Exception handling could mark in the tokoen that the email is not valid.

Thanks

trougakoss

trougakoss

2013-04-12 08:43

reporter   ~24950

i will look into it as soon as possible

trougakoss

trougakoss

2013-04-20 20:06

reporter   ~25001

I think that a simple mail validatin before executing the invitations will fix the issue.
I have made the pull request...

gabrieljenik

gabrieljenik

2013-04-20 20:39

manager   ~25002

Thanks... By the way, I think the issue is not only avoiding the exception, but also that the exception didn't have any handler... is that OK in an API?

trougakoss

trougakoss

2013-04-20 21:04

reporter   ~25003

I am afraid that the exception is happening in a deeper level( in a helper function) and not in the remotecontrol application.

I try to keep my changes only in the remotecontrol and i thing that the current solution is the most robust for the specific issue.
If this solution is not accepted by the team, i will of course make the appropriate changes.

trougakoss

trougakoss

2013-05-06 00:05

reporter   ~25179

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12370

trougakoss

trougakoss

2013-05-10 15:39

reporter   ~25218

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=12400

c_schmitz

c_schmitz

2013-05-14 14:38

administrator   ~25257

Version 2.0 Build 130514 released

Related Changesets

LimeSurvey: master b07e51b9

2013-04-20 18:04:11

trougakoss

Details Diff
Fixed Issue 07733: invite_participants method throws exception when some emails are registered Affected Issues
07733
mod - application/controllers/admin/remotecontrol.php Diff File

LimeSurvey: 2.05 0dd853ac

2013-04-20 18:04:11

trougakoss

Details Diff
Fixed Issue 07733: invite_participants method throws exception when some emails are registered Affected Issues
07733
mod - application/controllers/admin/remotecontrol.php Diff File

LimeSurvey: master 53932562

2013-05-03 12:05:42

c_schmitz

Details Diff
Merge pull request #77 from trougakoss/Yii

Fixed Issue 07733: invite_participants method throws exception when some...
Affected Issues
07733
mod - application/controllers/admin/remotecontrol.php Diff File

Issue History

Date Modified Username Field Change
2013-04-04 04:30 gabrieljenik New Issue
2013-04-04 14:47 c_schmitz Assigned To => trougakoss
2013-04-04 14:47 c_schmitz Status new => assigned
2013-04-04 15:50 gabrieljenik Note Added: 24909
2013-04-12 08:43 trougakoss Note Added: 24950
2013-04-20 20:06 trougakoss Note Added: 25001
2013-04-20 20:39 gabrieljenik Note Added: 25002
2013-04-20 21:04 trougakoss Note Added: 25003
2013-05-06 00:05 c_schmitz Changeset attached => LimeSurvey master 53932562
2013-05-06 00:05 trougakoss Changeset attached => LimeSurvey master b07e51b9
2013-05-06 00:05 trougakoss Note Added: 25179
2013-05-06 00:05 trougakoss Resolution open => fixed
2013-05-09 17:37 c_schmitz Status assigned => resolved
2013-05-09 17:37 c_schmitz Fixed in Version => 2.00+
2013-05-10 15:39 trougakoss Changeset attached => LimeSurvey 2.05 0dd853ac
2013-05-10 15:39 trougakoss Note Added: 25218
2013-05-14 14:38 c_schmitz Note Added: 25257
2013-05-14 14:38 c_schmitz Status resolved => closed
2013-10-07 15:44 c_schmitz Relationship added has duplicate 07880