View Issue Details

This bug affects 1 person(s).
 254
IDProjectCategoryView StatusLast Update
07652Bug reportsSecuritypublic2013-03-12 12:36
Reporterslansky Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary07652: User groups permissins - Access denied
Description

When setting survey permissions for a group LS throws "Access denied" error.

Steps To Reproduce
  1. Create survey and group of users (Group id MUST NOT exist in Users table IDs!)
  2. In "Survey permissions" select "Groups" and "Add user group"
  3. Select "Set Survey Rights"
  4. Set permissions and "Save now"
  5. LS throws "Access denied"
Additional Information

In the "surveypermission.php" file on line 569 (in version 20130305) is user group id checked whether it exists in user ids array (getUserList('onlyuidarray')). There should be check against user groups ids.

In the attachment is attached proposed patch.

TagsNo tags attached.
Attached Files
surveypermission.php.patch (570 bytes)   
Index: surveypermission.php
===================================================================
--- surveypermission.php	(revision 230)
+++ surveypermission.php	(working copy)
@@ -566,7 +566,7 @@
         {
             $this->getController()->error('Access denied');
         }
-        elseif( $postusergroupid &&  !in_array($postusergroupid,getUserList('onlyuidarray')))
+        elseif( $postusergroupid &&  !in_array($postusergroupid,getUserGroupList(null, 'simplegidarray')))
         {
             $this->getController()->error('Access denied');
         }
surveypermission.php.patch (570 bytes)   
Bug heat254
Complete LimeSurvey version number (& build)201303
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL 5.5.24, MySQL 5.1.6
Server OS (if known)Windows 7, Linux (Debian)
Webserver software & version (if known)Apache 2.2.22, Apache 2.2.16
PHP VersionPHP 5.3.1, PHP 5.3.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

slansky

slansky

2013-03-11 13:02

reporter   ~24611

Build number should be 130305 ;-)

c_schmitz

c_schmitz

2013-03-11 14:49

administrator   ~24616

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=11828

c_schmitz

c_schmitz

2013-03-11 15:03

administrator   ~24618

2.00+ build 130311 released

c_schmitz

c_schmitz

2013-03-12 12:36

administrator   ~24662

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=11839

Related Changesets

LimeSurvey: master 9ca37cc9

2013-03-11 13:46:33

c_schmitz

Details Diff
Fixed issue 07652: User groups permissions shows Access denied Affected Issues
07652
mod - application/controllers/admin/surveypermission.php Diff File

LimeSurvey: 2.05 79cabcfe

2013-03-11 13:46:33

c_schmitz

Details Diff
Fixed issue 07652: User groups permissions shows Access denied Affected Issues
07652
mod - application/controllers/admin/surveypermission.php Diff File

Issue History

Date Modified Username Field Change
2013-03-11 10:22 slansky New Issue
2013-03-11 10:22 slansky File Added: surveypermission.php.patch
2013-03-11 13:02 slansky Note Added: 24611
2013-03-11 14:49 c_schmitz Changeset attached => LimeSurvey master 9ca37cc9
2013-03-11 14:49 c_schmitz Note Added: 24616
2013-03-11 14:49 c_schmitz Assigned To => c_schmitz
2013-03-11 14:49 c_schmitz Resolution open => fixed
2013-03-11 15:03 c_schmitz Status new => assigned
2013-03-11 15:03 c_schmitz Status assigned => resolved
2013-03-11 15:03 c_schmitz Fixed in Version => 2.00+
2013-03-11 15:03 c_schmitz Note Added: 24618
2013-03-11 15:03 c_schmitz Status resolved => closed
2013-03-12 12:36 c_schmitz Changeset attached => LimeSurvey 2.05 79cabcfe
2013-03-12 12:36 c_schmitz Note Added: 24662