06945: Superadmin can't edit all groups - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

254

ID	Project	Category	View Status	Date Submitted	Last Update

06945	Bug reports	Security	public	2012-11-23 18:20	2012-12-07 09:58

Reporter	pfpDave	Assigned To	c_schmitz
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	2.00+
Fixed in Version	2.00+

Summary	06945: Superadmin can't edit all groups
Description	A user with Superadmin rights can't edit a group (and in some instances, can't see a group) if they didn't create it ... this doesn't seem logical? Is this an oversight or is there a reason behind this? Also A superadmin can't give superadmin rights to others unless they are the initial superadmin ... again can't see the logic here although this is clearly intended as in the code it states ..."// Only Initial SuperAdmin can give SuperAdmin rights"... I can work around this by changing my parent id to 0 but surely this isn't logical ... superadmin should be, well, super!?
Tags	No tags attached.

Bug heat	254
Complete LimeSurvey version number (& build)	121115
I will donate to the project if issue is resolved	No
Browser	IE8
Database type & version	SQL Express 2012
Server OS (if known)	Server 2008
Webserver software & version (if known)	IIS 7
PHP Version	5.4.8

User List	There are no users monitoring this issue.

pfpDave 2012-11-28 16:17 reporter ~22635 Last edited: 2012-11-28 16:17	A superadmin also can't give the 'Participant Panel' rights to others unless they are the initial SuperAdmin

c_schmitz 2012-12-05 14:12 administrator ~22902	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10728

c_schmitz 2012-12-05 14:12 administrator ~22903	"Only Initial SuperAdmin can give SuperAdmin rights" will not be changed. I fixed the other issues.

pfpDave 2012-12-05 14:27 reporter ~22907	--> "Only Initial SuperAdmin can give SuperAdmin rights" will not be changed. Can I ask why? This doesn't seem sensible to me?

c_schmitz 2012-12-05 20:56 administrator ~22923	It is a security decision we did at some point in the past and people rely on it.

c_schmitz 2012-12-06 10:45 administrator ~22966	Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10754

pfpDave 2012-12-06 10:45 reporter ~22974	Ok, many thanks.

c_schmitz 2012-12-07 09:58 administrator ~23001	2.00+ build 121207 released.

LimeSurvey: master b833915d 2012-12-05 13:11:58 c_schmitz Details Diff	Fixed issue 06945: Superadmin can't edit all admin groups / Only initial superadmin can give participant panel permissions	Affected Issues 06945
	mod - application/controllers/admin/usergroups.php	Diff File
	mod - application/core/Survey_Common_Action.php	Diff File
	mod - application/helpers/common_helper.php	Diff File
	mod - application/models/User_groups.php	Diff File
	mod - application/views/admin/user/setuserrights.php	Diff File
	mod - application/views/admin/usergroup/usergroupbar_view.php	Diff File
LimeSurvey: 2.1 093c259b 2012-12-06 09:40:04 c_schmitz Details Diff	Fixed issue 06945: Superadmin can't edit all admin groups / Only initial superadmin can give participant panel permissions	Affected Issues 06945
	mod - application/controllers/admin/usergroups.php	Diff File
	mod - application/core/Survey_Common_Action.php	Diff File
	mod - application/helpers/common_helper.php	Diff File
	mod - application/models/User_groups.php	Diff File
	mod - application/views/admin/user/setuserrights.php	Diff File
	mod - application/views/admin/usergroup/usergroupbar_view.php	Diff File

Date Modified	Username	Field	Change
2012-11-23 18:20	pfpDave	New Issue
2012-11-28 16:17	pfpDave	Note Added: 22635
2012-11-28 16:17	pfpDave	Note Edited: 22635
2012-11-30 23:18	c_schmitz	Assigned To	=> c_schmitz
2012-11-30 23:18	c_schmitz	Status	new => assigned
2012-12-05 14:12	c_schmitz	Changeset attached	=> LimeSurvey master b833915d
2012-12-05 14:12	c_schmitz	Note Added: 22902
2012-12-05 14:12	c_schmitz	Resolution	open => fixed
2012-12-05 14:12	c_schmitz	Note Added: 22903
2012-12-05 14:12	c_schmitz	Status	assigned => resolved
2012-12-05 14:12	c_schmitz	Fixed in Version	=> 2.00+
2012-12-05 14:27	pfpDave	Note Added: 22907
2012-12-05 20:56	c_schmitz	Note Added: 22923
2012-12-06 10:45	c_schmitz	Changeset attached	=> LimeSurvey 2.1 093c259b
2012-12-06 10:45	c_schmitz	Note Added: 22966
2012-12-06 10:45	pfpDave	Note Added: 22974
2012-12-07 09:58	c_schmitz	Note Added: 23001
2012-12-07 09:58	c_schmitz	Status	resolved => closed