06256: Touch event support - LimeSurvey bugs, patches and feature requests

(19469)
tpartner (developer)
2012-06-22 15:42

Carsten, are there any plans to include something like this?

I've tested the plugin above and it seems to do the trick.

(19473)
c_schmitz (administrator)
2012-06-22 15:56

Tony, sure, go ahead. Should be include this by default for all surveys?

(19474)
tpartner (developer)
2012-06-22 16:07

Yeah, I would think include it for all surveys. I think it should be a standard add-on to jQuery UI. It's pretty small and some folks may have their own draggables or sortables other than the slider questions.

I've pinged Denis to see if he has an opinion or alternate solution so will wait to see if he weighs in.

(19475)
DenisChenu (developer)
2012-06-22 16:07

Hello,

I have actually a working bug for touchscreen : http://bugs.limesurvey.org/view.php?id=6183 [^]

Actually : Condition + array filter (by ranking) work
I have a bug with max_answer ( have to modify EM)

For slider, i think it's best to use
http://www.w3.org/TR/html-markup/input.range.html [^]
For touch screen and just use jquery slider with other navigator.

Second:
I think it's a very bad idea to have "only javascript" question. It's important to have some accessibility for all squestion type.

(19477)
c_schmitz (administrator)
2012-06-22 17:05

Shnoulle: Slider are imho accessible already. I find it hard to implement a fool proof & accessible version of ranking. But give it a go if you like.

(19540)
DenisChenu (developer)
2012-06-25 11:36

Yep, i have to work on max-answers now for ranking, all other expression manager done. For accessibility, it need some control after in PHP.

I can take time thursday, not before.

But, here, i think it's good to put https://github.com/furf/jquery-ui-touch-punch [^] directly in 1.92+, because slider aren't good on touch screen like webphone.

But i can only test in opera.

(19559)
tpartner (developer)
2012-06-25 21:50

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8860 [^]

(19560)
tpartner (developer)
2012-06-25 21:51

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8861 [^]

(19561)
tpartner (developer)
2012-06-25 22:00

Denis, I think it's great that you are taking the high-road on the accessibility issue but agree with Carsten that some question types and features may be very difficult to achieve with pure HTML5/CSS. I look forward to your solutions.

In the meantime, I've added the plugin to both the surveys and the admin interface for 1.92 and Yii so dragging works on touch screens for sliders in the surveys and sub-question positioning in the back end.

We can remove it when you implement a non-JavaScript solution (or at least load it only when required).

Related Changesets
LimeSurvey: Yii 7b1517ec Timestamp: 2012-06-25 12:46:32 Author: tpartner Committer: tpartner [ Details ] [ Diff ]	Fixed issue 06256: Touch event support Dev : Added "jQuery UI Touch Punch" plugin
	mod - application/helpers/replacements_helper.php	[ Diff ] [ File ]
	mod - application/views/admin/super/header.php	[ Diff ] [ File ]
	add - scripts/jquery/jquery.ui.touch-punch.min.js	[ Diff ] [ File ]

LimeSurvey: master a68713e7 Timestamp: 2012-06-25 12:50:13 Author: tpartner Committer: tpartner [ Details ] [ Diff ]	Fixed issue 06256: Touch event support Dev Added "jQuery UI Touch Punch" plugin
	mod - admin/admin_functions.php	[ Diff ] [ File ]
	mod - common_functions.php	[ Diff ] [ File ]
	add - scripts/jquery/jquery.ui.touch-punch.min.js	[ Diff ] [ File ]

Issue History
Date Modified	Username	Field	Change
2012-06-22 15:39	tpartner	New Issue
2012-06-22 15:39	tpartner	Status	new => assigned
2012-06-22 15:39	tpartner	Assigned To	=> c_schmitz
2012-06-22 15:42	tpartner	Note Added: 19469
2012-06-22 15:56	c_schmitz	Note Added: 19473
2012-06-22 15:56	c_schmitz	Assigned To	c_schmitz => tpartner
2012-06-22 16:07	tpartner	Note Added: 19474
2012-06-22 16:07	DenisChenu	Note Added: 19475
2012-06-22 17:05	c_schmitz	Note Added: 19477
2012-06-25 11:36	DenisChenu	Note Added: 19540
2012-06-25 21:50	tpartner	Changeset attached	=> LimeSurvey master a68713e7
2012-06-25 21:50	tpartner	Note Added: 19559
2012-06-25 21:50	tpartner	Resolution	open => fixed
2012-06-25 21:51	tpartner	Changeset attached	=> LimeSurvey Yii 7b1517ec
2012-06-25 21:51	tpartner	Note Added: 19560
2012-06-25 22:00	tpartner	Note Added: 19561
2012-06-25 22:00	tpartner	Status	assigned => resolved
2012-07-05 22:31	c_schmitz	Status	resolved => closed
2012-07-05 22:31	c_schmitz	Fixed in Version	=> 1.92+

Notes
(19469) tpartner (developer) 2012-06-22 15:42	Carsten, are there any plans to include something like this? I've tested the plugin above and it seems to do the trick.

(19473) c_schmitz (administrator) 2012-06-22 15:56	Tony, sure, go ahead. Should be include this by default for all surveys?

(19474) tpartner (developer) 2012-06-22 16:07	Yeah, I would think include it for all surveys. I think it should be a standard add-on to jQuery UI. It's pretty small and some folks may have their own draggables or sortables other than the slider questions. I've pinged Denis to see if he has an opinion or alternate solution so will wait to see if he weighs in.

(19475) DenisChenu (developer) 2012-06-22 16:07	Hello, I have actually a working bug for touchscreen : http://bugs.limesurvey.org/view.php?id=6183 [^] Actually : Condition + array filter (by ranking) work I have a bug with max_answer ( have to modify EM) For slider, i think it's best to use http://www.w3.org/TR/html-markup/input.range.html [^] For touch screen and just use jquery slider with other navigator. Second: I think it's a very bad idea to have "only javascript" question. It's important to have some accessibility for all squestion type.

(19477) c_schmitz (administrator) 2012-06-22 17:05	Shnoulle: Slider are imho accessible already. I find it hard to implement a fool proof & accessible version of ranking. But give it a go if you like.

(19540) DenisChenu (developer) 2012-06-25 11:36	Yep, i have to work on max-answers now for ranking, all other expression manager done. For accessibility, it need some control after in PHP. I can take time thursday, not before. But, here, i think it's good to put https://github.com/furf/jquery-ui-touch-punch [^] directly in 1.92+, because slider aren't good on touch screen like webphone. But i can only test in opera.

(19559) tpartner (developer) 2012-06-25 21:50	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8860 [^]

(19560) tpartner (developer) 2012-06-25 21:51	Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8861 [^]

(19561) tpartner (developer) 2012-06-25 22:00	Denis, I think it's great that you are taking the high-road on the accessibility issue but agree with Carsten that some question types and features may be very difficult to achieve with pure HTML5/CSS. I look forward to your solutions. In the meantime, I've added the plugin to both the surveys and the admin interface for 1.92 and Yii so dragging works on touch screens for sliders in the surveys and sub-question positioning in the back end. We can remove it when you implement a non-JavaScript solution (or at least load it only when required).

Relationships