View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
06008Bug reportsData Entry (non public)public2012-05-10 20:48
Reportermdekker Assigned Tomdekker  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.92+ 
Fixed in Version1.92+ 
Summary06008: File upload doesn't work from date entry, not available in response edit
Description

File upload doens't work in the date entry although an upload button is available and some information gets saved. The file seems to be missing.

When editing a response, only the text fields can be edited for an uploaded file. It is impossible to add a file that a respondent emailed after they completed the survey.

Additional Information

In my opinion the edit screen should be similar to the data entry screen, at least for the display of the editable fields. This would save on duplicate code that needs to be maintained.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)120405
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql
Server OS (if known)freebsd
Webserver software & version (if known)apache
PHP Version5.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2012-04-12 15:08

developer   ~18334

mdekker : did you know if it work before ?

When i add a new answers : i can upload file, but not when editing it.
Maybe add a 'delete' option too.

Denis

DenisChenu

DenisChenu

2012-04-12 15:10

developer   ~18335

PS: actual code for public upload file is ...
I want to take time to review it for 2.0 but i had to find time ;)

mdekker

mdekker

2012-04-12 15:15

reporter   ~18336

probably never worked, file upload is not really well tested :(
the upload from normal survey works fine, that uses qanda.php and uploader.php / upload.php i think. I don't seem to get a valid json string (in dataentry), maybe that is a starting point?

DenisChenu

DenisChenu

2012-04-12 15:35

developer   ~18337

Last edited: 2012-04-12 15:37

It's uploader.php, calling via qanda.php via ajax.

Maybe the best actually (speed way) is to see the code for 'new answer' and put it in 'edit answer'. And put number of line with max_upload_file.

Denis

mdekker

mdekker

2012-04-26 13:55

reporter   ~18488

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8239

mdekker

mdekker

2012-04-26 13:58

reporter   ~18489

I did a quickfix that seems to work for me, can you please check and see if you have time to work on the edit part and/or a more elegant fix?

I am willing to test but very time-limited for coding a better solution myself

DenisChenu

DenisChenu

2012-04-26 14:08

developer   ~18490

I test and closed this one, if it work i think it's OK. Maybe reworking all upload file for 2.0/2.1 is a good solution.
I make a fork and send you some test if you can (when i found some time too ;) )

mdekker

mdekker

2012-05-01 10:25

reporter   ~18510

seems to work in yii branch without this patch, but yii needed a fix to create the upload directory

mdekker

mdekker

2012-05-01 10:26

reporter   ~18511

Fix committed to Yii branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=8279

Related Changesets

LimeSurvey: master 9e518c9c

2012-04-26 04:53:50

mdekker

Details Diff
dirty fix for 06008: File upload doesn't work from date entry, not available in response edit
dev: seems to work for me, only fixes dataentry, not edit screen
Affected Issues
06008
mod - admin/dataentry.php Diff File

LimeSurvey: Yii f84f4dbf

2012-05-01 01:26:13

mdekker

Details Diff
Fixed issue 06008: File upload doesn't work from data entry, not available in response edit
dev: in yii branch creation of upload directory didn't work other than that data entry file upload works fine
Affected Issues
06008
mod - application/helpers/admin/activate_helper.php Diff File

Issue History

Date Modified Username Field Change
2012-04-12 12:25 mdekker New Issue
2012-04-12 13:33 c_schmitz Assigned To => DenisChenu
2012-04-12 13:33 c_schmitz Status new => assigned
2012-04-12 15:08 DenisChenu Note Added: 18334
2012-04-12 15:10 DenisChenu Note Added: 18335
2012-04-12 15:15 mdekker Note Added: 18336
2012-04-12 15:35 DenisChenu Note Added: 18337
2012-04-12 15:37 DenisChenu Note Edited: 18337
2012-04-26 13:55 mdekker Changeset attached => LimeSurvey master 9e518c9c
2012-04-26 13:55 mdekker Note Added: 18488
2012-04-26 13:55 mdekker Assigned To DenisChenu => mdekker
2012-04-26 13:55 mdekker Resolution open => fixed
2012-04-26 13:58 mdekker Note Added: 18489
2012-04-26 13:58 mdekker Assigned To mdekker => DenisChenu
2012-04-26 13:58 mdekker Status assigned => feedback
2012-04-26 14:08 DenisChenu Note Added: 18490
2012-05-01 10:25 mdekker Note Added: 18510
2012-05-01 10:25 mdekker Status feedback => assigned
2012-05-01 10:25 mdekker Status assigned => resolved
2012-05-01 10:26 mdekker Changeset attached => LimeSurvey Yii f84f4dbf
2012-05-01 10:26 mdekker Note Added: 18511
2012-05-01 10:26 mdekker Assigned To DenisChenu => mdekker
2012-05-10 20:48 c_schmitz Status resolved => closed
2012-05-10 20:48 c_schmitz Fixed in Version => 1.92+