View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
05854Bug reportsSurvey editingpublic2012-02-25 16:182012-03-14 21:08
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.00a2 
Fixed in Version2.00a2 
Summary05854: Unable to remove some value from attribute
Description

Put some value on a text attribute, for example 2 on text short question : OK

Try to remove this value : put "" on this attribute : it don't save.

Steps To Reproduce

See Description ;)

Additional Information

Think the best is to only save the value if:
The ($new_value != $default_value) && ($old_value != $default_value)

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)0000
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2012-02-28 12:23

developer   ~17677

Last edited: 2012-02-28 12:24

Hello Carsten, I assign it to you to have your advice:

I start to work on this issue and i think we have to do is:
Don't save (or delete) attribute if is set to default.
Save only not default attribute.

Actually creat text question save some default attribute ( gmap attribute), i think it's a bad solution.
BUT, maybe the php code look only if it's set for some attribute and don't take default settings if it's not set. The after patching, maybe there are public survey problem.

Did i work on a patch like this:
"Remove (or don't save) attribute set to default"

Thanks
Denis
c_schmitz

c_schmitz

2012-03-01 09:54

administrator   ~17693

Sounds fine. Go for it.
DenisChenu

DenisChenu

2012-03-06 04:18

developer   ~17741

Fixed in
https://github.com/LimeSurvey/LimeSurvey/commit/a9534f1297b57a05d7e7f62fc56b4e4b2424ee75
c_schmitz

c_schmitz

2012-03-11 16:32

administrator   ~17836

2.00alpha 2 Build 120212 released

Related Changesets

LimeSurvey: Yii a9534f12

2012-03-05 19:12:04

DenisChenu

Details Diff 		Fixed issue 05854 : unable to remove or modify some value
Dev : don't save or remove default value for attribute
Dev : fix update for i18n		 Affected Issues
05854
mod - application/controllers/admin/database.php Diff File
mod - application/helpers/common_helper.php Diff File

Issue History

Date Modified Username Field Change
2012-02-25 16:18 DenisChenu New Issue
2012-02-25 16:18 DenisChenu Assigned To => DenisChenu
2012-02-25 16:18 DenisChenu Status new => assigned
2012-02-28 12:20 DenisChenu Assigned To DenisChenu => c_schmitz
2012-02-28 12:23 DenisChenu Note Added: 17677
2012-02-28 12:24 DenisChenu Note Edited: 17677
2012-03-01 09:54 c_schmitz Note Added: 17693
2012-03-01 09:54 c_schmitz Assigned To c_schmitz => DenisChenu
2012-03-06 04:18 DenisChenu Note Added: 17741
2012-03-06 04:18 DenisChenu Status assigned => resolved
2012-03-06 04:18 DenisChenu Fixed in Version => 2.00a2
2012-03-06 04:18 DenisChenu Resolution open => fixed
2012-03-11 16:32 c_schmitz Note Added: 17836
2012-03-11 16:32 c_schmitz Status resolved => closed
2012-03-14 21:08 DenisChenu Changeset attached => Import 2012-03-09 13:30:34 Yii a9534f12
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing