View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
05743Bug reportsSurvey takingpublic2012-02-01 19:082012-02-14 14:10
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.92RC3 
Target Version1.92RC4Fixed in Version1.92RC4 
Summary05743: Star rating : Bad html element for accessibility if javascript is deactivate ( or for blind people)
Description

Without javascript activated , with star rating system and slider with emoticon : you have a lot of HTML element without accessibility

Steps To Reproduce

Add a survey
Add a group
Add a question "5 point choice" ( validate or not)
Select Use slider layout / Yes - star

Look at survey taking without javascript : there are first good line of 5 radio button and another line with radio button

Additional Information

Put the patch in a minute.

Just use document.write javascript function.

The "slider with emoticon" have a very very very bad looking .... :(

TagsNo tags attached.
Attached Files
diff_bug_5743.diff (4,040 bytes)    
979c979,985
<     	$answer.='<br/><center><div id="'.$id.'div"><input type="radio" id="stars1" name="stars" class="'.$id.'st" value="1"/><input type="radio" id="stars2" name="stars" class="'.$id.'st" value="2"/><input type="radio" name="stars" id="stars3" class="'.$id.'st" value="3"/><input type="radio" id="stars4" name="stars" class="'.$id.'st" value="4"/><input type="radio" name="stars" id="stars5" class="'.$id.'st" value="5"/></div></center><br/>';
---
> 	    $answer.="
> 			<script type=\"text/javascript\">
> 			document.write('";
> 	    $answer.='<div id="'.$id.'div"><input type="radio" id="stars1" name="stars" class="'.$id.'st" value="1"/><input type="radio" id="stars2" name="stars" class="'.$id.'st" value="2"/><input type="radio" name="stars" id="stars3" class="'.$id.'st" value="3"/><input type="radio" id="stars4" name="stars" class="'.$id.'st" value="4"/><input type="radio" name="stars" id="stars5" class="'.$id.'st" value="5"/></div>';
> 	    $answer.="');
> 			</script>
> 			";
986c992
<     			}
---
> 				}
988,997c994,1003
<     				callback: function(value,link){
<     					if(value==undefined || value==''){
<     						$('#$id input').each(function(){ $(this).removeAttr('checked');});
<     						$('#{$id} #NoAnswer').attr('checked','checked');
<     					}
<     					else{
<     						$('#$id input').each(function(){ $(this).removeAttr('checked');});
<     						$('#answer$ia[1]'+value).attr('checked','checked');
<     					}
<     				}
---
> 					callback: function(value,link){
> 						if(value==undefined || value==''){
> 							$('#$id input').each(function(){ $(this).removeAttr('checked');});
> 							$('#{$id} #NoAnswer').attr('checked','checked');
> 						}
> 						else{
> 							$('#$id input').each(function(){ $(this).removeAttr('checked');});
> 							$('#answer$ia[1]'+value).attr('checked','checked');
> 						}
> 					}
999c1005
<     			});
---
> 				});
1002c1008
<     }
---
> 	}
1010,1018c1016,1031
<     	$answer.="
<     		<div style=\"float:left;\">
<     		<div style=\"text-align:center; margin-bottom:6px; width:370px;\"><div style=\"width:2%; float:left;\">1</div><div style=\"width:46%;float:left;\">2</div><div style=\"width:4%;float:left;\">3</div><div style=\"width:46%;float:left;\">4</div><div style=\"width:2%;float:left;\">5</div></div><br/>
<     	 	<div id=\"{$id}sliderBg\" style=\"background-image:url('{$imageurl}/sliderBg.png'); text-align:center; background-repeat:no-repeat; height:22px; width:396px;\">
<     	 	<center>
<     		<div id=\"{$id}slider\" style=\"width:365px;\"></div>
<     		</center>
<     		</div></div>
<     	 	<div id=\"{$id}emoticon\" style=\"text-align:left; margin:10px; padding-left:10px;\"><img id=\"{$id}img1\" style=\"margin-left:10px;\" src=\".{$imageurl}/emoticons/{$value}.png\"/><img id=\"{$id}img2\" style=\"margin-left:-31px;margin-top:-31px;\" src=\"{$imageurl}/emoticons/{$value}.png\" /></div>
---
> 	    $answer.="
> 			<script type=\"text/javascript\">
> 			document.write('";
> 	    $answer.="<div style=\"float:left;\">'+
>     		'<div style=\"text-align:center; margin-bottom:6px; width:370px;\"><div style=\"width:2%; float:left;\">1</div><div style=\"width:46%;float:left;\">2</div><div style=\"width:4%;float:left;\">3</div><div style=\"width:46%;float:left;\">4</div><div style=\"width:2%;float:left;\">5</div></div><br/>'+
>     		'<div id=\"{$id}sliderBg\" style=\"background-image:url(\'{$imageurl}/sliderBg.png\'); text-align:center; background-repeat:no-repeat; height:22px; width:396px;\">'+
>     		'<center>'+
>     		'<div id=\"{$id}slider\" style=\"width:365px;\"></div>'+
>     		'</center>'+
>     		'</div></div>'+
>     		'<div id=\"{$id}emoticon\" style=\"text-align:left; margin:10px; padding-left:10px;\"><img id=\"{$id}img1\" style=\"margin-left:10px;\" src=\".{$imageurl}/emoticons/{$value}.png\"/><img id=\"{$id}img2\" style=\"margin-left:-31px;margin-top:-31px;\" src=\"{$imageurl}/emoticons/{$value}.png\" />'+
>     		'</div>";
> 	    $answer.="');
> 			</script>
> 			";
> 		$answer.="
diff_bug_5743.diff (4,040 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)12282
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionMysql 5.1.49
Server OS (if known)debian/linux
Webserver software & version (if known)apache
PHP VersionPHP Version 5.3.3-7

Users monitoring this issue

There are no users monitoring this issue.

Activities

TMSWhite

TMSWhite

2012-02-02 15:36

reporter   ~17171

Shnoulle -I don't have an easy way to test this. Can you do the patch and test it?
DenisChenu

DenisChenu

2012-02-02 18:04

developer   ~17180

K

Tomorrow ;).

Priority : Low ?
DenisChenu

DenisChenu

2012-02-02 19:32

developer   ~17186

Revision: 12310
c_schmitz

c_schmitz

2012-02-14 14:10

administrator   ~17428

1.92RC4 released

Issue History

Date Modified Username Field Change
2012-02-01 19:08 DenisChenu New Issue
2012-02-01 19:09 DenisChenu File Added: diff_bug_5743.diff
2012-02-02 15:36 TMSWhite Assigned To => DenisChenu
2012-02-02 15:36 TMSWhite Status new => assigned
2012-02-02 15:36 TMSWhite Note Added: 17171
2012-02-02 18:04 DenisChenu Note Added: 17180
2012-02-02 19:32 DenisChenu Note Added: 17186
2012-02-02 19:32 DenisChenu Status assigned => resolved
2012-02-02 19:32 DenisChenu Fixed in Version => 1.92RC4
2012-02-02 19:32 DenisChenu Resolution open => fixed
2012-02-14 14:10 c_schmitz Note Added: 17428
2012-02-14 14:10 c_schmitz Status resolved => closed