|Anonymous | Login||2014-11-28 07:40 CET|
|My View | View Issues | Change Log | Roadmap | Repositories|
|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|05460||Development||[All Projects] Templates||public||2011-09-14 11:07||2012-10-30 14:05|
|Target Version||1.91+||Fixed in Version|
|Summary||05460: allow upload of extra css / js files and allow them to be edited|
|Description||The template system would be more flexible if one could upload his own css / js files and edit them from the editor|
|Tags||No tags attached.|
|Attached Files|| cssjsedit.diff [^] (15,517 bytes) 2011-10-11 09:20 [Show Content]
wTooltip.1.4.min.js [^] (6,141 bytes) 2012-03-01 09:45
edited on: 2011-09-14 11:12
Carsten, can you review the patch for me? I apologize for the white-space changes, i can undo them when i commit the patch if you like.
What I did is:
* add a setting to the global settings so the allowed extensions can be edited. (maybe css/js should be added to the default?)
* add css/js files to the cssfiles var, but after the copy/check for needed files is done
* also fixed a helper function that left out some files
* leave the extra css/js files in the right box so one can still delete them if desired
|(added the right patch)|
|Edit: new patch works with templates that have no extra files and allows names with uppercase|
|Could you please review my patch? Will work on de CI when approved.|
I would love to review the patch. Unfortunately it is not created with Subversion.
Can you try again and attach it please?
|Hope this one works?|
In general the patch for templates.php looks fine.
I just don't want the file extensions be editable in globalsettings.php for security reasons, so maybe you can leave that part out and just add .css and .js to the config-defaults.php.
Please don't forget to apply the changes to the CI version. No new features anymore on stable, please.
*to the Yii version.
Menno, can you give feedback please on the status of this issue?
|I am moving this to the development tracker for now - maybe someone else can pick up on this later.|
|This is an excellent addition guys! The only thing that I would suggest is to have a subdirectory for these aux files that the admins can put in their custom graphics and other custom files - this would keep the template files separated from the rest of the 'stuff.'|
|2011-09-14 11:07||mdekker||New Issue|
|2011-09-14 11:07||mdekker||File Added: cssjsedit.diff|
|2011-09-14 11:10||mdekker||Note Added: 16275|
|2011-09-14 11:10||mdekker||Assigned To||=> c_schmitz|
|2011-09-14 11:10||mdekker||Status||new => feedback|
|2011-09-14 11:12||mdekker||Note Edited: 16275||View Revisions|
|2011-09-14 11:17||mdekker||File Deleted: cssjsedit.diff|
|2011-09-14 11:17||mdekker||File Added: cssjsedit.diff|
|2011-09-14 11:18||mdekker||Note Added: 16276|
|2011-09-14 11:18||mdekker||Status||feedback => assigned|
|2011-09-23 11:10||mdekker||File Deleted: cssjsedit.diff|
|2011-09-23 11:10||mdekker||File Added: cssjsedit.diff|
|2011-09-23 11:11||mdekker||Note Added: 16318|
|2011-10-10 13:53||mdekker||Note Added: 16386|
|2011-10-10 17:10||c_schmitz||Note Added: 16387|
|2011-10-11 09:20||mdekker||File Deleted: cssjsedit.diff|
|2011-10-11 09:20||mdekker||File Added: cssjsedit.diff|
|2011-10-11 09:21||mdekker||Note Added: 16389|
|2011-10-18 18:24||c_schmitz||Assigned To||c_schmitz => mdekker|
|2011-10-18 18:26||c_schmitz||Note Added: 16452|
|2012-01-23 16:57||c_schmitz||Note Added: 16919|
|2012-01-23 16:58||c_schmitz||Status||assigned => feedback|
|2012-03-01 09:45||ludostev||File Added: wTooltip.1.4.min.js|
|2012-06-22 10:27||c_schmitz||Note Added: 19458|
|2012-07-27 13:53||c_schmitz||Assigned To||mdekker => c_schmitz|
|2012-07-27 13:53||c_schmitz||Status||feedback => assigned|
|2012-07-27 13:53||c_schmitz||Assigned To||c_schmitz => mdekker|
|2012-07-27 13:53||c_schmitz||Status||assigned => feedback|
|2012-10-02 12:33||c_schmitz||Note Added: 20977|
|2012-10-02 12:33||c_schmitz||Project||Bug reports => Development|
|2012-10-30 09:11||mdekker||Assigned To||mdekker =>|
|2012-10-30 09:14||mdekker||Status||feedback => new|
|2012-10-30 14:05||helper||Note Added: 21771|
|Copyright © 2000 - 2014 MantisBT Team|