View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
05424 | Bug reports | Survey taking | public | 2011-08-26 11:42 | 2012-03-14 21:08 |
Reporter | Assigned To | TMSWhite | |||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 1.91+ | ||||
Fixed in Version | 1.92RC4 | ||||
Summary | 05424: validation fails on mandatory comment field in list(radio) | ||||
Description | When you don't enter text in the mandatory field you will still pass and go to the next page. | ||||
Steps To Reproduce |
Open the question, choose other, don't fill in anything at the comment | ||||
Additional Information | I extensively searched myself, saw a few things that might be related. I consider it a bit remarkable to submit a form in the onclick event of a button of type submit. Is not necessary and I should not recommend this. If you do so the form onsubmit with a false return does not stop the form from being submitted. If you remove it, behavior is OK, BUT, now the buttons get greyed out and you cannot go on, I think because of jquery doing something. After many hours of testing this seems to be very complicated. I've worked with phpsurvyer since the 0.9 series and I get a it frightened by all the complexity that has been introduced. Fancy is nice, but working and understandable code is even nicer. | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 10120 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | firefox | ||||
Database type & version | mysql | ||||
Server OS (if known) | linux | ||||
Webserver software & version (if known) | apache | ||||
PHP Version | 5 | ||||
jwajwa, are you using the latest release? As far as I know the redundant submit function has already been removed from the onclick event. |
|
This works fine in 1.92 RC as long as you do not use a custom "Label for 'Other:' option" that required EM-based tailoring. Here is the default JavaScript: However, this is broken in 1.92 RC2 if you use a custom "Label for 'Other:' option". Although the proper JavaScript is created, the alert tries to include a <span> element so that it can dynamically tailored. This needs to be re-factored into EM to be a "validation" message that will appear as a color-coded tip rather than a pop-up message. Here is the generated JavaScript: |
|
Fixed in revision 12322 |
|
1.92RC4 released |
|
LimeSurvey: Yii 959f488b 2012-02-03 00:01:43 Details Diff |
Fixed issue 05424: validation fails on mandatory comment field in list(radio) Dev removed all onsubmit popup alerts saying that other comment had to be filled. Replaced with EM-based validation and CSS styling to indicate that the other comment needs to be filled. git-svn-id: file:///Users/Shitiz/Downloads/lssvn/source/limesurvey_yii@12323 b72ed6b6-b9f8-46b5-92b4-906544132732 |
Affected Issues 05424 |
|
mod - application/helpers/expressions/em_manager_helper.php | Diff File | ||
mod - application/helpers/qanda_helper.php | Diff File | ||
mod - templates/basic/template.css | Diff File | ||
mod - templates/bluengrey/template.css | Diff File | ||
mod - templates/citronade/template.css | Diff File | ||
mod - templates/clear_logo/template.css | Diff File | ||
mod - templates/default/template.css | Diff File | ||
mod - templates/eirenicon/template.css | Diff File | ||
mod - templates/limespired/template.css | Diff File | ||
mod - templates/mint_idea/template.css | Diff File | ||
mod - templates/sherpa/template.css | Diff File | ||
mod - templates/vallendar/template.css | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2011-08-26 11:42 |
|
New Issue | |
2011-08-26 11:42 |
|
Status | new => assigned |
2011-08-26 11:42 |
|
Assigned To | => lemeur |
2011-08-26 15:16 | lemeur | Assigned To | lemeur => c_schmitz |
2011-08-26 15:16 | lemeur | Category | Conditions => Survey taking |
2011-09-02 00:28 | c_schmitz | Assigned To | c_schmitz => user9586 |
2011-09-05 18:54 | tpartner | Note Added: 16231 | |
2012-01-20 17:07 | TMSWhite | Note Added: 16873 | |
2012-01-20 17:07 | TMSWhite | Assigned To | user9586 => TMSWhite |
2012-01-20 17:07 | TMSWhite | Status | assigned => confirmed |
2012-02-03 08:59 | TMSWhite | Note Added: 17199 | |
2012-02-03 08:59 | TMSWhite | Status | confirmed => resolved |
2012-02-03 08:59 | TMSWhite | Fixed in Version | => 1.92RC4 |
2012-02-03 08:59 | TMSWhite | Resolution | open => fixed |
2012-02-14 14:10 | c_schmitz | Note Added: 17425 | |
2012-02-14 14:10 | c_schmitz | Status | resolved => closed |
2012-03-14 21:08 | TMSWhite | Changeset attached | => Import 2012-03-09 13:30:34 Yii 959f488b |