View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
04669Bug reportsConditionspublic2010-10-19 21:12
Reporterledut Assigned Toc_schmitz  
PrioritynormalSeveritycrash 
Status closedResolutionfixed 
Product Version1.90+ 
Fixed in Version1.90+ 
Summary04669: "conditions edit page" displayed incompletely if there is a tag error on questions
Description

on the condition page (http://www.mysite/limesurvey/admin/admin.php?action=orderquestion)
if there is a tag error in a question, for exemple an unclosed <div> : the page end prematuraly on this question. Questions below are not displayed.

Steps To Reproduce

create a question #2 with an unclosed div,
create normal questions #3 and #4.
try to change question order : You won't see the questions #3 and #4.

Additional Information

to solve it :
on limesurvey/admin/questionhandling.php
add strip_tags() [or strip_tags(strip_javascript()] on 2 lines :

  • line 632 : become $orderquestions .= "<li><a href='#' onclick=\"window.open('admin.php?sid=".$surveyid."&gid=".$gid."&qid=".$depqid."&action=conditions&markcid=".$listcid."','_top')\">".$question['title'].": ".strip_tags($question['question']). " [QID: ".$depqid."] </a> ";

  • line 735 : become : $orderquestions.= "<a href='admin.php?sid=$surveyid&gid=$gid&qid={$oqarray[$i]['qid']}' title='".$clang->gT("View Question")."'>".$oqarray[$i]['title']."</a>: ".strip_tags($oqarray[$i]['question']);

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)9169
I will donate to the project if issue is resolved
BrowserMozilla/5.0 (Windows; U; Windows NT 6.1; fr; rv:1.9.2) Gecko/20100115 Firefox/3.6
Database type & versionMysql 5.1.36
Server OS (if known)wamp on Windows seven
Webserver software & version (if known)localhost
PHP Version5.2.11

Users monitoring this issue

There are no users monitoring this issue.

Activities

ledut

ledut

2010-10-13 17:52

reporter   ~13142

Last edited: 2010-10-13 20:49

I have made a mistake : this bug doesn't ocure on the condtitions edit page ! It is on the ordering question page.

c_schmitz

c_schmitz

2010-10-13 18:26

administrator   ~13144

Thank you very much! Resolved in rev 9230.

ledut

ledut

2010-10-13 20:48

reporter   ~13151

you're welcome !

c_schmitz

c_schmitz

2010-10-19 21:12

administrator   ~13280

Released in 1.90 plus release.

Issue History

Date Modified Username Field Change
2010-10-11 20:11 ledut New Issue
2010-10-11 20:11 ledut Status new => assigned
2010-10-11 20:11 ledut Assigned To => lemeur
2010-10-12 01:00 c_schmitz Assigned To lemeur => c_schmitz
2010-10-13 17:52 ledut Note Added: 13142
2010-10-13 18:26 c_schmitz Note Added: 13144
2010-10-13 18:26 c_schmitz Status assigned => resolved
2010-10-13 18:26 c_schmitz Fixed in Version => 1.90+
2010-10-13 18:26 c_schmitz Resolution open => fixed
2010-10-13 20:48 ledut Note Added: 13151
2010-10-13 20:49 ledut Note Edited: 13142
2010-10-19 21:12 c_schmitz Note Added: 13280
2010-10-19 21:12 c_schmitz Status resolved => closed