View Issue Details

This bug affects 1 person(s).
 14
IDProjectCategoryView StatusLast Update
04600Bug reportsSurvey editingpublic2010-10-13 16:22
Reportermdekker Assigned Tomdekker  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.90+ 
Target Version1.90+Fixed in Version1.90+ 
Summary04600: IE6 can not add subquestions
Description

In IE6 it is impossible to use the + and - signs to add or delete subquestions.

Additional Information

I researched a little and noticed the event doesn't get fired on the img tags, but when I enclose them in a div tag it seems to work ok. As I am no javascript / jquery expert this might break something with ids and stuff so please review my patch.

TagsNo tags attached.
Bug heat14
Complete LimeSurvey version number (& build)9131
I will donate to the project if issue is resolved
BrowserInternet Explorer 6
Database type & versiondna
Server OS (if known)dna
Webserver software & version (if known)dna
PHP Versiondna

Users monitoring this issue

There are no users monitoring this issue.

Activities

ronvdburg

ronvdburg

2010-09-15 12:00

reporter   ~12846

Hi mdekker,

Although I cannot check using IE6, have you seen the bugfix in 9131 in admin/html.php?

Could the erroneous </th> tag influence your problem/solution?

--- source/limesurvey/admin/html.php (revision 9130)
+++ source/limesurvey/admin/html.php (revision 9131)
@@ -1778,7 +1778,7 @@
."<thead>"
."<tr><th> </th>\n"
."<th align='right'>".$clang->gT("Code")."</th>\n"

  • ."</th><th align='center'>".$clang->gT("Subquestion")."</th>\n";
  • ."<th align='center'>".$clang->gT("Subquestion")."</th>\n";
    if ($activated != 'Y' && $first)
    {
    $vasummary .="<th align='center'>".$clang->gT("Action")."</th>\n";
mdekker

mdekker

2010-09-15 12:21

reporter   ~12850

I did that fix myself searching for a solution for this problem :) Unfortunately it didn't solve the problem.

I hate IE6 but a lot of people are in such a restricted environment that it is the only browser they can use :( The 1.90 is working pretty well on IE6 compared to older versions though :)

DenisChenu

DenisChenu

2010-09-17 11:24

developer   ~12856

And did someone test with Netscape navigator 4.0 ?
And did someone test with elinks ?

IE6 is old, plenty of bug, security risk .... I think it's a bad idea to continue to support IE6 in admin page.

Ask for FireFox, Chromium ... etc ...

Mazi

Mazi

2010-09-20 12:25

updater   ~12869

Tony, can you have a look?

tpartner

tpartner

2010-09-21 02:04

partner   ~12882

I was under the impression that we were not supporting IE6 in the admin interface due to the instability of some of the new jQuery functions and lack of PNG support.

Mazi

Mazi

2010-09-21 10:41

updater   ~12883

Tony, I think so, too. I'll assign this one to Thibault so he can decide.

tpartner

tpartner

2010-09-22 00:49

partner   ~12889

Thibault, your thoughts?

mdekker

mdekker

2010-09-25 14:27

reporter   ~12907

You loose a lot of university and corporate people if you don't support the IE6 that is still offered in a lot of closed environments. It is not extended functionality, but one of the basics you need to be able to set up a survey.

And besides, I patched it already I only need somebody to review it... come on...

lemeur

lemeur

2010-10-02 21:08

developer   ~12978

I prefer to let Carsten give his opinion on this.

c_schmitz

c_schmitz

2010-10-04 15:30

administrator   ~12983

I consider this not as a bug so I don't see the need to fix this personally.
IE6 is now 12 years old and supporting it is like trying to revive a dead horse.
However if the patch is tested and creates no problems in newer browsers I am fine with it.

mdekker, it is impossible to find out by 'review' if the patch is working. If you have tested it with all latest browsers and everything still work JS-wise (quick-add and label set browser) feel free to apply it.

mdekker

mdekker

2010-10-08 11:08

reporter   ~13043

Removed the previous patch, as it MIGHT break something. It turned out that the PNG fix broken some stuff so by disabling that i get some grey backgrounds, but all seems to work fine again :)

Only a small fix to the subquestions javascript is needed that I am sure breaks nothing else. The fixes makes sure the question code calculation works.

Maybe we need something special for the release notes or just be aware of forum messages telling us about the ugly grey backgrounds. So we can respond correctly.

c_schmitz

c_schmitz

2010-10-13 16:22

administrator   ~13128

Released in latest Plus version

Issue History

Date Modified Username Field Change
2010-09-15 10:45 mdekker New Issue
2010-09-15 10:45 mdekker File Added: subquestion_ie6.diff
2010-09-15 12:00 ronvdburg Note Added: 12846
2010-09-15 12:21 mdekker Note Added: 12850
2010-09-17 11:24 DenisChenu Note Added: 12856
2010-09-20 12:25 Mazi Assigned To => tpartner
2010-09-20 12:25 Mazi Status new => assigned
2010-09-20 12:25 Mazi Note Added: 12869
2010-09-21 02:04 tpartner Note Added: 12882
2010-09-21 10:41 Mazi Note Added: 12883
2010-09-22 00:48 tpartner Assigned To tpartner => lemeur
2010-09-22 00:49 tpartner Note Added: 12889
2010-09-25 14:27 mdekker Note Added: 12907
2010-10-02 21:08 lemeur Assigned To lemeur => c_schmitz
2010-10-02 21:08 lemeur Note Added: 12978
2010-10-04 15:30 c_schmitz Note Added: 12983
2010-10-04 15:30 c_schmitz Assigned To c_schmitz => mdekker
2010-10-08 11:05 mdekker File Deleted: subquestion_ie6.diff
2010-10-08 11:08 mdekker Note Added: 13043
2010-10-08 11:08 mdekker Status assigned => resolved
2010-10-08 11:08 mdekker Fixed in Version => 1.90+
2010-10-08 11:08 mdekker Resolution open => fixed
2010-10-13 16:22 c_schmitz Note Added: 13128
2010-10-13 16:22 c_schmitz Status resolved => closed
2010-10-25 00:17 c_schmitz Category Survey Design => Survey design
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing