View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
04598Bug reportsSurvey takingpublic2010-09-14 17:562010-09-29 16:29
Reporterronvdburg Assigned Tomdekker  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version1.90+ 
Fixed in Version1.90+ 
Summary04598: Wrong path to DD_belatedPNG_0.0.8a-min.js
Description

common.php uses the public scripts directory in stead of the admin/scripts directory when refering to DD_belatedPNG_0.0.8a-min.js.

This has only effect when IE < 7.

Steps To Reproduce

Check common.php for DD_belated. It is used twice.

TagsNo tags attached.
Attached Files
fix_DD_belatedPNG.patch (918 bytes)    
Index: common.php
===================================================================
--- common.php	(revision 9129)
+++ common.php	(working copy)
@@ -4306,7 +4306,7 @@
     }
 
     $strAdminHeader.= "<!--[if lt IE 7]>\n"
-    . "<script type=\"text/javascript\" src=\"scripts/DD_belatedPNG_0.0.8a-min.js\"></script>\n"
+    . "<script type=\"text/javascript\" src=\"".$homeurl."/scripts/DD_belatedPNG_0.0.8a-min.js\"></script>\n"
     ."<script>
   DD_belatedPNG.fix('img');
 </script>\n"
@@ -4363,7 +4363,7 @@
             <script type="text/javascript" src="'.$homeurl.'/scripts/printablesurvey.js"></script>
 
     <!--[if lt IE 7]>
-            <script type="text/javascript" src="'.$rooturl.'/scripts/DD_belatedPNG_0.0.8a-min.js"></script>
+            <script type="text/javascript" src="'.$homeurl.'/scripts/DD_belatedPNG_0.0.8a-min.js"></script>
             <script>
   DD_belatedPNG.fix("img");
 </script>
fix_DD_belatedPNG.patch (918 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)9129
I will donate to the project if issue is resolved
Browser
Database type & versionmysql 5.0.77
Server OS (if known)Centos 5.3 / Linux 2.6.18
Webserver software & version (if known)apache 2.2.3
PHP Version5.1.6

Users monitoring this issue

There are no users monitoring this issue.

Activities

mdekker

mdekker

2010-09-15 10:51

reporter   ~12843

Hi Ron,

Are you sure this is a problem? When I use IE6 I have no problem as the path is relative and it starts from the admin directory so effectively it uses /admin/scripts

Btw, if you use IE6 too would you be so kind to check that adding subquestions using the + / - buttons is not working and if my patch in http://bugs.limesurvey.org/view.php?id=4600 is working for you too?
ronvdburg

ronvdburg

2010-09-15 11:14

reporter   ~12844

Hi mdekker,

Ad "Are you sure?"
For the first instance of calling DD_belatedPNG.patch you are right, the path is relative to admin/ (or better, $homeurl).
However, the second instance is absolute and referring to $rooturl.

So the second instance is wrong indeed.

However, I have a user patch enabling the user taking a survey to print an empty survey. This way, he/she can print a hardcopy version, discuss in the board and then take the electronic survey. This patch uses the admin/printablesurvey.php script. I know that it is not clean, but it works. However, this way, the relative path is not suitable.

Anyway, since the second instance of the 'DD_belatedPNG' script uses an absolute path (although wrong), I thought the first instance can also be using an absolute path. And this absolute path will make my user patch work ;-)

You assume that I use IE6 but I am not. My users are in business units all over the world and apparently at least one of them is using IE6. I was triggered on a 404 on DD_belatedPNG_0.0.8a-min.js in the Apache's errorlog.

Sorry.
mdekker

mdekker

2010-09-15 11:54

reporter   ~12845

fixed in 9132
ronvdburg

ronvdburg

2010-09-15 12:06

reporter   ~12848

Hi mdekker,
Please review the patch, you may have omitted a slash (/) in the first occurrence.

...$homeurl."/scripts...

in stead of

...$homeurl."scripts...
mdekker

mdekker

2010-09-15 12:11

reporter   ~12849

tijd voor koffie...

Fixed in next commit :)
c_schmitz

c_schmitz

2010-09-29 16:29

administrator   ~12938

New 1.90+ version was released.

Issue History

Date Modified Username Field Change
2010-09-14 17:56 ronvdburg New Issue
2010-09-14 17:57 ronvdburg File Added: fix_DD_belatedPNG.patch
2010-09-15 10:51 mdekker Note Added: 12843
2010-09-15 11:14 ronvdburg Note Added: 12844
2010-09-15 11:54 mdekker Note Added: 12845
2010-09-15 11:54 mdekker Status new => resolved
2010-09-15 11:54 mdekker Fixed in Version => 1.90+
2010-09-15 11:54 mdekker Resolution open => fixed
2010-09-15 11:54 mdekker Assigned To => mdekker
2010-09-15 12:06 ronvdburg Note Added: 12848
2010-09-15 12:06 ronvdburg Status resolved => feedback
2010-09-15 12:06 ronvdburg Resolution fixed => reopened
2010-09-15 12:11 mdekker Note Added: 12849
2010-09-16 10:44 mdekker Status feedback => resolved
2010-09-16 10:44 mdekker Resolution reopened => fixed
2010-09-29 16:29 c_schmitz Note Added: 12938
2010-09-29 16:29 c_schmitz Status resolved => closed
2010-10-25 00:18 c_schmitz Category Survey at Runtime => Survey taking