View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
04512Bug reportsConditionspublic2012-01-30 18:41
ReporterMallo Assigned Tolemeur  
PrioritylowSeveritytweak 
Status closedResolutionfixed 
Product Version1.90RC3 
Fixed in Version1.92RC3 
Summary04512: Javascript validation also takes affect while going one step backwards (moveprev)
Description

If eg. "Min answers" is set for one question and you want to go to the previous step - without selecting appropriate answers - the Javascript validation message shows up. I am not quite sure if it's a wanted behaviour.

Steps To Reproduce

I temporarily fixed it by adding ...

. "\tif(document.limesurvey.move.value == 'moveprev') return false;\n"

...

just in the beginning of the javascript function "ensureminansw_"

File: quanda.php
Line: 2776

Additional Information

There might be some other functions to update. Also it is possibly not the best solution, but until now it works for me.

Kind regards
Mallo

TagsNo tags attached.
Bug heat10
Complete LimeSurvey version number (& build)8963
I will donate to the project if issue is resolved
BrowserFirefox
Database type & versionMySQL
Server OS (if known)Debian
Webserver software & version (if known)Apache
PHP Version5.3

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2010-08-01 18:49

administrator   ~12522

Values are saved on moving backwards too - so if a user gives a value at all it must be within required parameters.

Mallo

Mallo

2010-08-05 18:55

reporter   ~12577

Last edited: 2010-08-05 18:55

Alright, that makes sense.
But then there shouldn't be a redirect to the previous page after the Javascript alert. That is just something that irritates a bit imho (or I just do not get it completely ;-)).

Mazi

Mazi

2010-08-05 23:57

updater   ~12579

Mallo, you have to give a valid (e.g. sufficient number of) answer(s) before you are able to proceed (meaning clicking next or previous.

This behavior is a little weird, I would also expect to be able to move backwards when not having entered any data.

c_schmitz, lemeur do you think we can/should change this?

c_schmitz

c_schmitz

2010-08-06 00:53

administrator   ~12580

Mazi, did you check it?

lemeur

lemeur

2010-09-04 22:58

developer   ~12754

We have to decide here if we prefer:

  • to ensure that the temporary data recorded into DB are always consistent with min/max constraints
    OR
  • we prefer to ease the participant's navigation

In any case, I agree that showing the warning message and yet going backward is a weird behaviour.

I personally vote for the solution proposed by Mallo: max/min scripts could be bypassed when going backward. This of course would authorize Non-Completed responses to be inconsistent with min/max constraints, but anyway I always consider these incomplete responses as possibly inconsistent...

Carsten, Mazi your thoughts ?

c_schmitz

c_schmitz

2010-09-05 23:57

administrator   ~12759

I vote for 'to ensure that the temporary data recorded into DB are always consistent with min/max constraints' - I rather not have any invalid data in the tables.

Mazi

Mazi

2010-09-09 13:09

updater   ~12800

From my point of view it's netter to not irritate the user by showing alert messages. If you didn't fill out anything and just want to move back you don't expect to have to fill out all questions at first. Having a survey in group-by-group mode with many questions really causes a problem then.

I think there will be only some very few cases where users enter some answers, then want to go back, maybe change a question so that following questions which were answered previously are hidden by cvonditions.
Only in this case invalid data will remain in the DB I guess?!

So I vote for improving the usability.

c_schmitz

c_schmitz

2010-10-13 20:39

administrator   ~13149

From my point of view it's netter to not irritate the user by showing alert messages. If you didn't fill out anything and just want to move back you don't expect to have to fill out all questions at first.

I totally agree on that. A question responses being still empty (although mandatory) should be fine. But invalid values should should not be tolerated.
We could quietly discard these (not preferred) or force the user to give a valid value.

c_schmitz

c_schmitz

2011-09-11 10:08

administrator   ~16260

lemeur, do you think you can have another shot at this for CI 1.92?

TMSWhite

TMSWhite

2012-01-20 17:11

reporter   ~16875

This is fixed in 1.92. There are no longer any pop-up messages for min/max answers - instead the validation criteria are color-coded green/red.

c_schmitz

c_schmitz

2012-01-30 18:41

administrator   ~17071

1.92RC3 released

Issue History

Date Modified Username Field Change
2010-07-30 16:22 Mallo New Issue
2010-07-30 16:22 Mallo Status new => assigned
2010-07-30 16:22 Mallo Assigned To => lemeur
2010-08-01 14:50 c_schmitz Assigned To lemeur => c_schmitz
2010-08-01 14:50 c_schmitz Assigned To c_schmitz => lemeur
2010-08-01 18:49 c_schmitz Note Added: 12522
2010-08-05 18:55 Mallo Note Added: 12577
2010-08-05 18:55 Mallo Note Edited: 12577
2010-08-05 23:57 Mazi Note Added: 12579
2010-08-06 00:53 c_schmitz Note Added: 12580
2010-09-04 22:58 lemeur Note Added: 12754
2010-09-05 23:57 c_schmitz Note Added: 12759
2010-09-09 13:09 Mazi Note Added: 12800
2010-10-13 20:39 c_schmitz Note Added: 13149
2011-09-11 10:08 c_schmitz Note Added: 16260
2011-09-11 10:09 c_schmitz Status assigned => feedback
2012-01-20 17:11 TMSWhite Note Added: 16875
2012-01-20 17:11 TMSWhite Status feedback => resolved
2012-01-20 17:11 TMSWhite Resolution open => fixed
2012-01-24 21:40 c_schmitz Fixed in Version => 1.92RC3
2012-01-30 18:41 c_schmitz Note Added: 17071
2012-01-30 18:41 c_schmitz Status resolved => closed