View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
04353Bug reportsTheme editorpublic2010-07-05 12:37
ReporterJade Assigned Tomdekker  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version1.87+ 
Fixed in Version1.90RC1 
Summary04353: Problem in editing template-rtl.css
Description

What I am doing is that im creating a new template for use in Arabic surveys.
I creat my survey, the problem is when i want to edit "template-rtl.css", I click on it, but it don`t select and the selection goes to "startpage.pstpl".

Note: i have attached a screen shot of my edit page, with a red rectangle where "Template-rtl.css" lies, which I clicked.

Steps To Reproduce

-I loged in as an admin.
-Go to template editing.
-Creat a new template.
-Click on "template-rtl.css".
-The selection doesn`t stick to "template-rtl.css".

TagsNo tags attached.
Attached Files
Edit_temp.JPG (105,904 bytes)
Bug heat10
Complete LimeSurvey version number (& build)8518
I will donate to the project if issue is resolved
Browser
Database type & versionMySQL 5.0.77
Server OS (if known)RHEL 5.4
Webserver software & version (if known)APACHE 2.2.9
PHP Version5.3

Users monitoring this issue

alikaafarani

Activities

mdekker

mdekker

2010-05-20 09:54

reporter   ~11884

Found the problem... sanitize_paranoid_string doesn't allow a dash in the filename. So question is, do we allow a dash, or change the dash to underscore? Leaving this open for someone to take a decision on security and what way to go.

Mazi

Mazi

2010-05-20 13:50

updater   ~11888

I could also reproduce the problem.

Thibault, any suggestions on how to deal with it?

lemeur

lemeur

2010-05-20 13:57

developer   ~11890

Let's replace the call to sanitize_paranoid_string to a new function "sanitize_filename".
mdekker, can you do this:

  • copy sanitize_paranoid_string to sanitize_filename and add the dash, then change the call to check the filename to use the new function instead ?

Thibault

mdekker

mdekker

2010-05-20 15:24

reporter   ~11893

Sure, will do.

mdekker

mdekker

2010-05-20 15:55

reporter   ~11894

Too easy, function already existed :) Fixed in 8737

Jade

Jade

2010-05-21 15:37

reporter   ~11902

Thanks alot!! :)
In the download page i cannot find the limesurvey "8737" with the fixed issue.

http://sourceforge.net/projects/limesurvey/files/

Is it possible to tell me what code did you change or were exactly is the fixed file to download.

Thank you again!!:)

Mazi

Mazi

2010-05-21 16:12

updater   ~11903

The fixed file can be found here: http://limesurvey.svn.sourceforge.net/viewvc/limesurvey?view=rev&revision=8737

I'm not sure if this file will work at your 1.87 installation because it might contain further previous changes based on the 1.90 code base.
You can test but definately have to make a backup.

lemeur

lemeur

2010-05-21 19:05

developer   ~11914

1.90 beta3 release

Issue History

Date Modified Username Field Change
2010-05-20 07:33 Jade New Issue
2010-05-20 07:33 Jade Status new => assigned
2010-05-20 07:33 Jade Assigned To => user372
2010-05-20 07:33 Jade File Added: Edit_temp.JPG
2010-05-20 09:54 mdekker Note Added: 11884
2010-05-20 13:50 Mazi Note Added: 11888
2010-05-20 13:50 Mazi Assigned To user372 => lemeur
2010-05-20 13:57 lemeur Note Added: 11890
2010-05-20 14:16 Mazi Assigned To lemeur => mdekker
2010-05-20 15:24 mdekker Note Added: 11893
2010-05-20 15:55 mdekker Note Added: 11894
2010-05-20 15:55 mdekker Status assigned => resolved
2010-05-20 15:55 mdekker Fixed in Version => 1.90RC1
2010-05-20 15:55 mdekker Resolution open => fixed
2010-05-21 15:37 Jade Note Added: 11902
2010-05-21 16:12 Mazi Note Added: 11903
2010-05-21 19:05 lemeur Note Added: 11914
2010-05-21 19:05 lemeur Status resolved => closed
2010-07-05 12:37 alikaafarani Issue Monitored: alikaafarani
2015-12-11 14:40 c_schmitz Category Templates => Theme editor
2021-08-04 03:51 guest Bug heat 8 => 10